From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
frankc@nvidia.com, hverkuil@xs4all.nl, sakari.ailus@iki.fi,
helen.koike@collabora.com
Cc: sboyd@kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v7 6/9] media: tegra: Add Tegra210 Video input driver
Date: Wed, 15 Apr 2020 17:22:26 +0300 [thread overview]
Message-ID: <4118112f-f865-5460-6319-d71271fd78d1@gmail.com> (raw)
In-Reply-To: <1586919463-30542-7-git-send-email-skomatineni@nvidia.com>
15.04.2020 05:57, Sowjanya Komatineni пишет:
> +static int tegra_csi_remove(struct platform_device *pdev)
> +{
> + struct tegra_csi *csi = platform_get_drvdata(pdev);
> + int err;
> +
> + err = host1x_client_unregister(&csi->client);
> + if (err < 0) {
> + dev_err(csi->dev,
> + "failed to unregister host1x client: %d\n", err);
> + return err;
> + }
> +
> + pm_runtime_disable(csi->dev);
> + kfree(csi);
IIRC, the driver removal is invoked on the unbinding. Hence, I'm not
sure how moving away from the resource-managed API helps here. Could you
please explain in a more details?
Have you tried to test this driver under KASAN? I suspect that you just
masked the problem, instead of fixing it.
next prev parent reply other threads:[~2020-04-15 14:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 2:57 [RFC PATCH v7 0/9] Add Tegra driver for video capture Sowjanya Komatineni
2020-04-15 2:57 ` [RFC PATCH v7 1/9] arm64: tegra: Fix sor powergate clocks and reset Sowjanya Komatineni
2020-04-15 2:57 ` [RFC PATCH v7 2/9] arm64: tegra: Add reset-cells to mc Sowjanya Komatineni
2020-04-15 2:57 ` [RFC PATCH v7 3/9] dt-bindings: clock: tegra: Add clk id for CSI TPG clock Sowjanya Komatineni
2020-04-15 2:57 ` [RFC PATCH v7 4/9] clk: tegra: Add Tegra210 CSI TPG clock gate Sowjanya Komatineni
2020-04-15 2:57 ` [RFC PATCH v7 5/9] dt-binding: tegra: Add VI and CSI bindings Sowjanya Komatineni
2020-04-15 2:57 ` [RFC PATCH v7 6/9] media: tegra: Add Tegra210 Video input driver Sowjanya Komatineni
2020-04-15 14:22 ` Dmitry Osipenko [this message]
2020-04-15 16:54 ` Sowjanya Komatineni
2020-04-15 17:21 ` Sowjanya Komatineni
2020-04-15 17:47 ` Sowjanya Komatineni
2020-04-15 17:48 ` Sowjanya Komatineni
2020-04-15 18:39 ` Sowjanya Komatineni
2020-04-15 18:53 ` Sowjanya Komatineni
2020-04-15 19:21 ` Dmitry Osipenko
2020-04-15 19:51 ` Sowjanya Komatineni
2020-04-15 23:08 ` Sowjanya Komatineni
2020-04-15 23:28 ` Sowjanya Komatineni
2020-04-16 15:12 ` Sowjanya Komatineni
2020-04-15 2:57 ` [RFC PATCH v7 7/9] MAINTAINERS: Add Tegra Video driver section Sowjanya Komatineni
2020-04-15 2:57 ` [RFC PATCH v7 8/9] dt-bindings: reset: Add ID for Tegra210 VI reset Sowjanya Komatineni
2020-04-15 2:57 ` [RFC PATCH v7 9/9] arm64: tegra: Add Tegra VI CSI support in device tree Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4118112f-f865-5460-6319-d71271fd78d1@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frankc@nvidia.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sboyd@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox