Re: [PATCH v3 3/3] media: imx: imx7-media-csi: Include headers explicitly

[Alexander Stein <alexander.stein@ew.tq-group.com>]

Hi Laurent,

thanks for the additional cleanup.

Am Dienstag, 25. Juli 2023, 22:02:49 CEST schrieb Laurent Pinchart:
> Include all the headers that the driver needs explicitly instead of
> relying on indirect inclusion. While at it, drop a few unneeded headers.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  drivers/media/platform/nxp/imx7-media-csi.c | 27 ++++++++++++++++-----
>  1 file changed, 21 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/media/platform/nxp/imx7-media-csi.c
> b/drivers/media/platform/nxp/imx7-media-csi.c index
> 3aa7978d3f8a..95e9f22f21be 100644
> --- a/drivers/media/platform/nxp/imx7-media-csi.c
> +++ b/drivers/media/platform/nxp/imx7-media-csi.c
> @@ -3,31 +3,46 @@
>   * V4L2 Capture CSI Subdev for Freescale i.MX6UL/L / i.MX7 SOC
>   *
>   * Copyright (c) 2019 Linaro Ltd
> - *
>   */
> 
>  #include <linux/clk.h>
> +#include <linux/completion.h>
> +#include <linux/container_of.h>
>  #include <linux/delay.h>
> +#include <linux/device.h>
> +#include <linux/dma-mapping.h>
> +#include <linux/err.h>
>  #include <linux/interrupt.h>
> +#include <linux/io.h>
> +#include <linux/jiffies.h>
> +#include <linux/kernel.h>
> +#include <linux/list.h>
>  #include <linux/math.h>
> -#include <linux/mfd/syscon.h>
>  #include <linux/minmax.h>
>  #include <linux/module.h>
> +#include <linux/mutex.h>
>  #include <linux/of.h>
> -#include <linux/of_graph.h>
> -#include <linux/pinctrl/consumer.h>
>  #include <linux/platform_device.h>
> -#include <linux/regmap.h>
> +#include <linux/property.h>
>  #include <linux/slab.h>
>  #include <linux/spinlock.h>
> +#include <linux/string.h>
> +#include <linux/timekeeping.h>
>  #include <linux/types.h>
> 
> +#include <media/media-device.h>
> +#include <media/media-entity.h>
> +#include <media/v4l2-async.h>
> +#include <media/v4l2-common.h>
> +#include <media/v4l2-dev.h>
>  #include <media/v4l2-device.h>
> -#include <media/v4l2-fwnode.h>
> +#include <media/v4l2-fh.h>
>  #include <media/v4l2-ioctl.h>
>  #include <media/v4l2-mc.h>
>  #include <media/v4l2-subdev.h>
> +#include <media/videobuf2-core.h>
>  #include <media/videobuf2-dma-contig.h>
> +#include <media/videobuf2-v4l2.h>
> 
>  #define IMX7_CSI_PAD_SINK		0
>  #define IMX7_CSI_PAD_SRC		1

Looks good to me.
Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/