Re: Re: Re: [PATCH 07/19] media: i2c: imx290: Support variable-sized registers

Sakari Ailus
2022-07-22T14:38:00Z

Hi Alexander,

On Thu, Jul 21, 2022 at 01:43:54PM +0200, Alexander Stein wrote:
...
> Nice the following snippet does the trick already:
> ---8<---
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -221,6 +221,7 @@ static const struct imx290_pixfmt imx290_formats[] = {
> static const struct regmap_config imx290_regmap_config = {
> .reg_bits = 16,
> .val_bits = 8,
> + .use_single_read = true,
> };
>
> static const char * const imx290_test_pattern_menu[] = {
> ---8<---
>
> As this affects the VC OV9281 as well, any suggestions for a common property?

If there's a 1:1 I²C mux in there between the host and the sensor, should
it be in DT as well? I'm not entirely certain it's necessary.

The property could be called e.g. "single-octet-read". I think this should
probably be documented in I²C bindings (or even regmap).

--
Regards,

Sakari Ailus