Re: [PATCH 04/19] media: i2c: imx290: Replace macro with explicit ARRAY_SIZE()

Alexander Stein
2022-07-21T09:23:53Z

Am Donnerstag, 21. Juli 2022, 10:35:25 CEST schrieb Laurent Pinchart:
> Use ARRAY_SIZE(imx290->supplies) for code that needs the size of the
> array, instead of relying on the IMX290_NUM_SUPPLIES. The result is less
> error-prone as it ties the size to the array.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/imx290.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
> index f60a4135dc9c..9a0c458a3af0 100644
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -790,10 +790,10 @@ static int imx290_get_regulators(struct device *dev,
> struct imx290 *imx290) {
> unsigned int i;
>
> - for (i = 0; i < IMX290_NUM_SUPPLIES; i++)
> + for (i = 0; i < ARRAY_SIZE(imx290->supplies); i++)
> imx290->supplies[i].supply = imx290_supply_name[i];
>
> - return devm_regulator_bulk_get(dev, IMX290_NUM_SUPPLIES,
> + return devm_regulator_bulk_get(dev, ARRAY_SIZE(imx290->supplies),
> imx290->supplies);
> }
>
> @@ -852,7 +852,8 @@ static int imx290_power_on(struct device *dev)
> return ret;
> }
>
> - ret = regulator_bulk_enable(IMX290_NUM_SUPPLIES, imx290->supplies);
> + ret = regulator_bulk_enable(ARRAY_SIZE(imx290->supplies),
> + imx290->supplies);
> if (ret) {
> dev_err(dev, "Failed to enable regulators\n");
> clk_disable_unprepare(imx290->xclk);
> @@ -876,7 +877,7 @@ static int imx290_power_off(struct device *dev)
>
> clk_disable_unprepare(imx290->xclk);
> gpiod_set_value_cansleep(imx290->rst_gpio, 1);
> - regulator_bulk_disable(IMX290_NUM_SUPPLIES, imx290->supplies);
> + regulator_bulk_disable(ARRAY_SIZE(imx290->supplies), imx290-
>supplies);
>
> return 0;
> }

Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>