Re: [PATCH 12/19] media: i2c: imx290: Fix max gain value

Alexander Stein
2022-07-21T10:02:32Z

Am Donnerstag, 21. Juli 2022, 10:35:33 CEST schrieb Laurent Pinchart:
> The gain is expressed in multiple of 0.3dB, as a value between 0.0dB
> and 72.0dB. The maximum value is thus 240, not 72.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/imx290.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
> index 3cb024b73ee7..1bd464932432 100644
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -1020,7 +1020,7 @@ static int imx290_probe(struct i2c_client *client)
> imx290->ctrls.lock = &imx290->lock;
>
> v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops,
> - V4L2_CID_GAIN, 0, 72, 1, 0);
> + V4L2_CID_GAIN, 0, 240, 1, 0);
>
> v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops,
> V4L2_CID_EXPOSURE, 1, IMX290_VMAX_DEFAULT -
2, 1,

Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>