[PATCH 01/19] media: i2c: imx290: Use device lock for the control handler

Laurent Pinchart
2022-07-21T08:35:47Z

The link frequency and pixel rate controls are set without holding the
control handler lock, resulting in kernel warnings. As the value of
those controls depend on the format, the simplest fix is to use the
device lock for the control handler.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/media/i2c/imx290.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
index 99f2a50d39a4..d97a5fb1d501 100644
--- a/drivers/media/i2c/imx290.c
+++ b/drivers/media/i2c/imx290.c
@@ -1043,6 +1043,7 @@ static int imx290_probe(struct i2c_client *client)
imx290_entity_init_cfg(&imx290->sd, NULL);

v4l2_ctrl_handler_init(&imx290->ctrls, 4);
+ imx290->ctrls.lock = &imx290->lock;

v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops,
V4L2_CID_GAIN, 0, 72, 1, 0);
--
Regards,

Laurent Pinchart