Re: [PATCH 06/19] media: i2c: imx290: Drop regmap cache

Alexander Stein
2022-07-21T09:27:06Z

Am Donnerstag, 21. Juli 2022, 10:35:27 CEST schrieb Laurent Pinchart:
> Only two registers are ever read, and once only. There's no need to
> cache values.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/imx290.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
> index f280ded2dac3..711282126c34 100644
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -97,7 +97,6 @@ static const struct imx290_pixfmt imx290_formats[] = {
> static const struct regmap_config imx290_regmap_config = {
> .reg_bits = 16,
> .val_bits = 8,
> - .cache_type = REGCACHE_RBTREE,
> };
>
> static const char * const imx290_test_pattern_menu[] = {

Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>