Re: [PATCH 19/19] media: i2c: imx290: Replace GAIN control with ANALOGUE_GAIN

Alexander Stein
2022-07-21T10:12:00Z

Am Donnerstag, 21. Juli 2022, 10:35:40 CEST schrieb Laurent Pinchart:
> The IMX290 gain register controls the analogue gain. Replace the
> V4L2_CID_GAIN control with V4L2_CID_ANALOGUE_GAIN.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/imx290.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
> index 0cb11ec1cf0f..871e3e69a8a4 100644
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -524,7 +524,7 @@ static int imx290_set_ctrl(struct v4l2_ctrl *ctrl)
> return 0;
>
> switch (ctrl->id) {
> - case V4L2_CID_GAIN:
> + case V4L2_CID_ANALOGUE_GAIN:
> ret = imx290_write(imx290, IMX290_GAIN, ctrl->val,
NULL);
> break;
>
> @@ -1006,7 +1006,7 @@ static int imx290_ctrl_init(struct imx290 *imx290)
> imx290->ctrls.lock = &imx290->lock;
>
> v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops,
> - V4L2_CID_GAIN, 0, 240, 1, 0);
> + V4L2_CID_ANALOGUE_GAIN, 0, 240, 1, 0);
>
> v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops,
> V4L2_CID_EXPOSURE, 1, IMX290_VMAX_DEFAULT -
2, 1,

Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>