Re: [PATCH 15/19] media: i2c: imx290: Create controls for fwnode properties

Alexander Stein
2022-07-21T10:06:36Z

Am Donnerstag, 21. Juli 2022, 10:35:36 CEST schrieb Laurent Pinchart:
> Create the V4L2_CID_ORIENTATION and V4L2_CID_ROTATION controls to
> expose the corresponding fwnode properties.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/imx290.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
> index 7190399f4111..78772c6327a2 100644
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -896,10 +896,15 @@ static const struct media_entity_operations
> imx290_subdev_entity_ops = {
>
> static int imx290_ctrl_init(struct imx290 *imx290)
> {
> + struct v4l2_fwnode_device_properties props;
> unsigned int blank;
> int ret;
>
> - v4l2_ctrl_handler_init(&imx290->ctrls, 7);
> + ret = v4l2_fwnode_device_parse(imx290->dev, &props);
> + if (ret < 0)
> + return ret;
> +
> + v4l2_ctrl_handler_init(&imx290->ctrls, 9);
> imx290->ctrls.lock = &imx290->lock;
>
> v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops,
> @@ -947,6 +952,9 @@ static int imx290_ctrl_init(struct imx290 *imx290)
> if (imx290->vblank)
> imx290->vblank->flags |= V4L2_CTRL_FLAG_READ_ONLY;
>
> + v4l2_ctrl_new_fwnode_properties(&imx290->ctrls, &imx290_ctrl_ops,
> + &props);
> +
> imx290->sd.ctrl_handler = &imx290->ctrls;
>
> if (imx290->ctrls.error) {

Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>