From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Hadli, Manjunath" <manjunath.hadli@ti.com>
Cc: dlos <davinci-linux-open-source@linux.davincidsp.com>,
LMML <linux-media@vger.kernel.org>,
Sakari Ailus <sakari.ailus@iki.fi>,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH v4 1/2] media: add new mediabus format enums for dm365
Date: Wed, 18 Jul 2012 13:05:18 +0200 [thread overview]
Message-ID: <41958950.qGmmsSpAPM@avalon> (raw)
In-Reply-To: <E99FAA59F8D8D34D8A118DD37F7C8F753E93EE3C@DBDE01.ent.ti.com>
Hi Manjunath,
On Tuesday 17 July 2012 12:22:42 Hadli, Manjunath wrote:
> On Tue, Jul 17, 2012 at 17:25:42, Laurent Pinchart wrote:
> > On Tuesday 17 July 2012 11:41:11 Hadli, Manjunath wrote:
> > > On Tue, Jul 17, 2012 at 16:26:24, Laurent Pinchart wrote:
> > > > On Friday 30 March 2012 10:09:13 Hadli, Manjunath wrote:
> > > > > add new enum entries for supporting the media-bus formats on dm365.
> > > > > These include some bayer and some non-bayer formats.
> > > > > V4L2_MBUS_FMT_YDYC8_1X16 and V4L2_MBUS_FMT_UV8_1X8 are used
> > > > > internal to the hardware by the resizer.
> > > > > V4L2_MBUS_FMT_SBGGR10_ALAW8_1X8 represents the bayer ALAW format
> > > > > that is supported by dm365 hardware.
> > > > >
> > > > > Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
> > > > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > > > Cc: Sakari Ailus <sakari.ailus@iki.fi>
> > > > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > > > ---
> > > > >
> > > > > Documentation/DocBook/media/v4l/subdev-formats.xml | 171
> > > > > ++++++++++++
> > > > > include/linux/v4l2-mediabus.h | 10 +-
> > > > > 2 files changed, 179 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml
> > > > > b/Documentation/DocBook/media/v4l/subdev-formats.xml index
> > > > > 49c532e..48d92bb
> > > > > 100644
> > > > > --- a/Documentation/DocBook/media/v4l/subdev-formats.xml
> > > > > +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
> >
> > [snip]
> >
> > > > > @@ -965,6 +1036,56 @@
> > > > >
> > > > > <entry>y<subscript>1</subscript></entry>
> > > > > <entry>y<subscript>0</subscript></entry>
> > > > >
> > > > > </row>
> > > > >
> > > > > + <row id="V4L2-MBUS-FMT-UV8-1X8">
> > > >
> > > > That's a weird one. Just out of curiosity, what's the point of
> > > > transferring chroma information without luma ?
> > >
> > > DM365 supports this format.
> >
> > Right, but what is it used for ?
>
> Sorry about that. The Resizer in Dm365 can take only chroma and resize the
> buffer. It can also take luma of course. In general it can take UV8, Y8 and
> also UYVY.
So UV8 is used to resize an NV buffer in two passes (first Y8 then UV8) ?
> > [snip]
> >
> > > > > @@ -2415,6 +2536,56 @@
> > > > >
> > > > > <entry>u<subscript>1</subscript></entry>
> > > > > <entry>u<subscript>0</subscript></entry>
> > > > >
> > > > > </row>
> > > > >
> > > > > + <row id="V4L2-MBUS-FMT-YDYC8-1X16">
> > > >
> > > > What is this beast ? We at least need a textual description, as I have
> > > > no
> > > > idea what the format corresponds to.
> > >
> > > This was discussed earlier over here
> > > http://patchwork.linuxtv.org/patch/8843/
> >
> > My bad, I should have remembered that. Please add a textual description of
> > the format, it's not clear from the name what D and C are.
>
> I see no description for individual MBUS formats but a collective para on
> everything together. Would you like me to add in the same or otherwise can
> you point to me where I can add this description?
What about the following patch ? Note that I've renamed YDYC to YDYU, as we
might later need a YDYV format.
(Hans, Sakari, any opinion ?)
diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml
index 49c532e..47a485e 100644
--- a/Documentation/DocBook/media/v4l/subdev-formats.xml
+++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
@@ -853,10 +853,15 @@
<title>Packed YUV Formats</title>
<para>Those data formats transfer pixel data as (possibly downsampled) Y, U
- and V components. The format code is made of the following information.
+ and V components. Some formats include dummy bits in some of their samples
+ and are collectively referred to as "YDYC" (Y-Dummy-Y-Chroma) formats.
+ </para>
+
+ <para>The format code is made of the following information.
<itemizedlist>
<listitem><para>The Y, U and V components order code, as transferred on the
- bus. Possible values are YUYV, UYVY, YVYU and VYUY.</para></listitem>
+ bus. Possible values are YUYV, UYVY, YVYU and VYUY for formats with no
+ dummy bit, and YDYU, YDYV, YUYD and YVYD for YDYC formats.</para></listitem>
<listitem><para>The number of bits per pixel component. All components are
transferred on the same number of bits. Common values are 8, 10 and 12.</para>
</listitem>
@@ -877,7 +882,21 @@
U, Y, V, Y order will be named <constant>V4L2_MBUS_FMT_UYVY8_2X8</constant>.
</para>
- <para>The following table lisst existing packet YUV formats.</para>
+ <para><xref linkend="v4l2-mbus-pixelcode-yuv8"/> list existing packet YUV
+ formats and describes the organization of each pixel data in each sample.
+ When a format pattern is split across multiple samples each of the samples
+ in the pattern is described.</para>
+
+ <para>The role of each bit transferred over the bus is identified by one
+ of the following codes.</para>
+
+ <itemizedlist>
+ <listitem><para>y<subscript>x</subscript> for luma component bit number x</para></listitem>
+ <listitem><para>u<subscript>x</subscript> for blue chroma component bit number x</para></listitem>
+ <listitem><para>v<subscript>x</subscript> for red chroma component bit number x</para></listitem>
+ <listitem><para>- for non-available bits (for positions higher than the bus width)</para></listitem>
+ <listitem><para>/ for dummy bits</para></listitem>
+ </itemizedlist>
<table pgwide="0" frame="none" id="v4l2-mbus-pixelcode-yuv8">
<title>YUV Formats</title>
@@ -2415,6 +2434,106 @@
<entry>u<subscript>1</subscript></entry>
<entry>u<subscript>0</subscript></entry>
</row>
+ <row id="V4L2-MBUS-FMT-YDYU8-1X16">
+ <entry>V4L2_MBUS_FMT_YDYU8_1X16</entry>
+ <entry>0x2014</entry>
+ <entry></entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>y<subscript>7</subscript></entry>
+ <entry>y<subscript>6</subscript></entry>
+ <entry>y<subscript>5</subscript></entry>
+ <entry>y<subscript>4</subscript></entry>
+ <entry>y<subscript>3</subscript></entry>
+ <entry>y<subscript>2</subscript></entry>
+ <entry>y<subscript>1</subscript></entry>
+ <entry>y<subscript>0</subscript></entry>
+ <entry>/</entry>
+ <entry>/</entry>
+ <entry>/</entry>
+ <entry>/</entry>
+ <entry>/</entry>
+ <entry>/</entry>
+ <entry>/</entry>
+ <entry>/</entry>
+ </row>
+ <row>
+ <entry></entry>
+ <entry></entry>
+ <entry></entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>y<subscript>7</subscript></entry>
+ <entry>y<subscript>6</subscript></entry>
+ <entry>y<subscript>5</subscript></entry>
+ <entry>y<subscript>4</subscript></entry>
+ <entry>y<subscript>3</subscript></entry>
+ <entry>y<subscript>2</subscript></entry>
+ <entry>y<subscript>1</subscript></entry>
+ <entry>y<subscript>0</subscript></entry>
+ <entry>u<subscript>7</subscript></entry>
+ <entry>u<subscript>6</subscript></entry>
+ <entry>u<subscript>5</subscript></entry>
+ <entry>u<subscript>4</subscript></entry>
+ <entry>u<subscript>3</subscript></entry>
+ <entry>u<subscript>2</subscript></entry>
+ <entry>u<subscript>1</subscript></entry>
+ <entry>u<subscript>0</subscript></entry>
+ </row>
+ <row>
+ <entry></entry>
+ <entry></entry>
+ <entry></entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>y<subscript>7</subscript></entry>
+ <entry>y<subscript>6</subscript></entry>
+ <entry>y<subscript>5</subscript></entry>
+ <entry>y<subscript>4</subscript></entry>
+ <entry>y<subscript>3</subscript></entry>
+ <entry>y<subscript>2</subscript></entry>
+ <entry>y<subscript>1</subscript></entry>
+ <entry>y<subscript>0</subscript></entry>
+ <entry>/</entry>
+ <entry>/</entry>
+ <entry>/</entry>
+ <entry>/</entry>
+ <entry>/</entry>
+ <entry>/</entry>
+ <entry>/</entry>
+ <entry>/</entry>
+ </row>
+ <row>
+ <entry></entry>
+ <entry></entry>
+ <entry></entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>y<subscript>7</subscript></entry>
+ <entry>y<subscript>6</subscript></entry>
+ <entry>y<subscript>5</subscript></entry>
+ <entry>y<subscript>4</subscript></entry>
+ <entry>y<subscript>3</subscript></entry>
+ <entry>y<subscript>2</subscript></entry>
+ <entry>y<subscript>1</subscript></entry>
+ <entry>y<subscript>0</subscript></entry>
+ <entry>v<subscript>7</subscript></entry>
+ <entry>v<subscript>6</subscript></entry>
+ <entry>v<subscript>5</subscript></entry>
+ <entry>v<subscript>4</subscript></entry>
+ <entry>v<subscript>3</subscript></entry>
+ <entry>v<subscript>2</subscript></entry>
+ <entry>v<subscript>1</subscript></entry>
+ <entry>v<subscript>0</subscript></entry>
+ </row>
<row id="V4L2-MBUS-FMT-YUYV10-1X20">
<entry>V4L2_MBUS_FMT_YUYV10_1X20</entry>
<entry>0x200d</entry>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-07-18 11:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1333102154-24657-1-git-send-email-manjunath.hadli@ti.com>
[not found] ` <1333102154-24657-2-git-send-email-manjunath.hadli@ti.com>
2012-07-17 10:56 ` [PATCH v4 1/2] media: add new mediabus format enums for dm365 Laurent Pinchart
2012-07-17 11:41 ` Hadli, Manjunath
2012-07-17 11:55 ` Laurent Pinchart
2012-07-17 12:22 ` Hadli, Manjunath
2012-07-18 11:05 ` Laurent Pinchart [this message]
2012-07-19 11:33 ` Hadli, Manjunath
2012-07-19 11:39 ` Laurent Pinchart
2012-07-19 11:43 ` Guennadi Liakhovetski
2012-07-19 12:58 ` Hans Verkuil
2012-07-19 13:41 ` Laurent Pinchart
[not found] ` <1333102154-24657-3-git-send-email-manjunath.hadli@ti.com>
2012-07-17 10:59 ` [PATCH v4 2/2] v4l2: add new pixel formats supported on dm365 Laurent Pinchart
2012-07-17 11:43 ` Hadli, Manjunath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41958950.qGmmsSpAPM@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=manjunath.hadli@ti.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).