From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-175.mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50FD4183072 for ; Wed, 12 Jun 2024 18:10:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718215849; cv=none; b=IP3jL9mIzNKEafUZN6qemLi5OzSoB0bubuMAd/ntX/BXBAyG3pjK93BR2EQETT4NKzHg8Hg2ndDA7c6q79z2C6APVUQh4OWPUIaRzXqsPk/9LgaCW8oTh7BRihJxvC9C+LoqqTwHB/6M/1/uv9BbII88X6zjYKVY6Od6Tagod9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718215849; c=relaxed/simple; bh=+XnHRTnS9LdzjAnCfXLi+O0dR/LBhekA4iksGxNsJfw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oQ4xvpSQAtuw2Uf7nWi/vwYBW7Tx607DoUpjj6EIXvNyqyzD0FOGfSXA88pZVZiRMpCYeiVmefljmFaIN9uTt073dw3Dlsg3ONmTz0Wpf2tbKutyqYK1xm1lLm90GkRys3TGxwabYpdOSGOy6HF0E7nK62qz/qc2jYHr8jU+plk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org; spf=pass smtp.mailfrom=cknow.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b=tQXH8/Xq; arc=none smtp.client-ip=95.215.58.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b="tQXH8/Xq" X-Envelope-To: ezequiel@vanguardiasur.com.ar DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1718215845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7Wwh90v24Qe0BQdwYakUsPolSiapUti7KGb/PL1W8ms=; b=tQXH8/Xq1QwVd4wMRAzNCmzYZzKLwohN/fYu1HQM4kXHE6+bf2CX1BhmaEvz3S/Hg3SPKy 87DEEJ6ISuSnNmwLRBcaqGex7Bxy0nahTAxNfXA/B+VJ87tJWcgbu97vRj6gpo5TchKCPY mjpYLhImN/fkkrTqDuctfIyl/PIQxHa+WHB5fM3NFGtWxKQ+zBbN3kPV6sxOu4N3ZGIXC+ 8mrczhGNnlxVPOGPvff1s/5YuwwE2bOL1PfB7wITly/t5jnO/0Fq3dNP+pU/wBsczUIhVi 26rDjcJfWZyO7caBLM/8sBaFKy6JEUViMJOwrqA5MyvSwrqRkK6+c8EHUvx1iw== X-Envelope-To: p.zabel@pengutronix.de X-Envelope-To: frattaroli.nicolas@gmail.com X-Envelope-To: heiko@sntech.de X-Envelope-To: linux-rockchip@lists.infradead.org X-Envelope-To: robh@kernel.org X-Envelope-To: krzk+dt@kernel.org X-Envelope-To: conor+dt@kernel.org X-Envelope-To: liujianfeng1994@gmail.com X-Envelope-To: linkmauve@linkmauve.fr X-Envelope-To: nicolas.dufresne@collabora.com X-Envelope-To: linux-media@vger.kernel.org X-Envelope-To: linux-rockchip@lists.infradead.org X-Envelope-To: devicetree@vger.kernel.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: kernel@collabora.com X-Envelope-To: sigmaris@gmail.com X-Envelope-To: sebastian.reichel@collabora.com X-Envelope-To: sebastian.reichel@collabora.com X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Diederik de Haas To: Ezequiel Garcia , Philipp Zabel , Nicolas Frattaroli , Heiko Stuebner , linux-rockchip@lists.infradead.org Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jianfeng Liu , Emmanuel Gil Peyrot , Nicolas Dufresne , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Hugh Cole-Baker , Sebastian Reichel , Sebastian Reichel Subject: Re: [PATCH v5 5/5] arm64: dts: rockchip: Add VPU121 support for RK3588 Date: Wed, 12 Jun 2024 20:10:30 +0200 Message-ID: <4207056.GSNtieVc0Q@bagend> Organization: Connecting Knowledge In-Reply-To: <20240612173213.42827-6-sebastian.reichel@collabora.com> References: <20240612173213.42827-1-sebastian.reichel@collabora.com> <20240612173213.42827-6-sebastian.reichel@collabora.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart5992854.hoJakhlImG"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Migadu-Flow: FLOW_OUT --nextPart5992854.hoJakhlImG Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Diederik de Haas Date: Wed, 12 Jun 2024 20:10:30 +0200 Message-ID: <4207056.GSNtieVc0Q@bagend> Organization: Connecting Knowledge In-Reply-To: <20240612173213.42827-6-sebastian.reichel@collabora.com> MIME-Version: 1.0 Hi, On Wednesday, 12 June 2024 19:15:45 CEST Sebastian Reichel wrote: > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi index > 9edbcfe778ca..e7e1b456b9b9 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > @@ -1239,6 +1239,27 @@ jpeg_enc3_mmu: iommu@fdbac800 { > #iommu-cells = <0>; > }; > > + vpu: video-codec@fdb50000 { > + compatible = "rockchip,rk3588-vpu121", > "rockchip,rk3568-vpu"; + reg = <0x0 0xfdb50000 0x0 0x800>; > + interrupts = ; > + interrupt-names = "vdpu"; > + clocks = <&cru ACLK_VPU>, <&cru HCLK_VPU>; > + clock-names = "aclk", "hclk"; > + iommus = <&vpu_mmu>; > + power-domains = <&power RK3588_PD_VDPU>; > + }; > + > + vpu_mmu: iommu@fdb50800 { > + compatible = "rockchip,rk3588-iommu", > "rockchip,rk3568-iommu"; + reg = <0x0 0xfdb50800 0x0 0x40>; > + interrupts = ; > + clock-names = "aclk", "iface"; > + clocks = <&cru ACLK_VPU>, <&cru HCLK_VPU>; > + power-domains = <&power RK3588_PD_VDPU>; > + #iommu-cells = <0>; > + }; > + > av1d: video-codec@fdc70000 { Shouldn't these nodes come *before* jpeg_enc0: video-codec@fdba0000 As fdb50000 is lower then fdba0000? Cheers, Diederik --nextPart5992854.hoJakhlImG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZmnklgAKCRDXblvOeH7b bjdlAQD4lJfAZ+uWdf2M0bt3TgJkdY9aeTap7nRn/OtdhFmyLwD+KKaiUZBld2Py aS3zD6719QKISeO69bc5PwdusH9GXAA= =RLxZ -----END PGP SIGNATURE----- --nextPart5992854.hoJakhlImG--