From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Cc: m.chehab@samsung.com, gregkh@linuxfoundation.org,
prabhakar.csengg@gmail.com, yongjun_wei@trendmicro.com.cn,
sakari.ailus@iki.fi, hans.verkuil@cisco.com,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED
Date: Thu, 20 Feb 2014 12:36:57 +0100 [thread overview]
Message-ID: <4210530.AR5GZgidVz@avalon> (raw)
In-Reply-To: <1386584182-5400-1-git-send-email-michael.opdenacker@free-electrons.com>
Hi Michael,
What's the status of this patch ? Do expect Prabhakar to pick it up, or do you
plan to push all your IRQF_DISABLED removal patches in one go ?
On Monday 09 December 2013 11:16:22 Michael Opdenacker wrote:
> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
> drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c index
> d8ce20d2fbda..cda8388cbb89 100644
> --- a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> +++ b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> @@ -298,7 +298,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
> {
> int ret = 0;
>
> - ret = request_irq(vpfe_dev->ccdc_irq0, vpfe_isr, IRQF_DISABLED,
> + ret = request_irq(vpfe_dev->ccdc_irq0, vpfe_isr, 0,
> "vpfe_capture0", vpfe_dev);
> if (ret < 0) {
> v4l2_err(&vpfe_dev->v4l2_dev,
> @@ -306,7 +306,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
> return ret;
> }
>
> - ret = request_irq(vpfe_dev->ccdc_irq1, vpfe_vdint1_isr, IRQF_DISABLED,
> + ret = request_irq(vpfe_dev->ccdc_irq1, vpfe_vdint1_isr, 0,
> "vpfe_capture1", vpfe_dev);
> if (ret < 0) {
> v4l2_err(&vpfe_dev->v4l2_dev,
> @@ -316,7 +316,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
> }
>
> ret = request_irq(vpfe_dev->imp_dma_irq, vpfe_imp_dma_isr,
> - IRQF_DISABLED, "Imp_Sdram_Irq", vpfe_dev);
> + 0, "Imp_Sdram_Irq", vpfe_dev);
> if (ret < 0) {
> v4l2_err(&vpfe_dev->v4l2_dev,
> "Error: requesting IMP IRQ interrupt\n");
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-02-20 11:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 6:23 [PATCH] [media] davinci: vpfe: remove deprecated IRQF_DISABLED Michael Opdenacker
2013-10-07 6:12 ` Prabhakar Lad
2013-12-09 10:16 ` [PATCH][RESEND] " Michael Opdenacker
2014-02-20 11:36 ` Laurent Pinchart [this message]
2014-02-20 13:17 ` Michael Opdenacker
2014-02-20 13:30 ` Laurent Pinchart
2014-02-24 5:31 ` Prabhakar Lad
2014-02-25 6:02 ` Prabhakar Lad
2014-02-25 7:58 ` Michael Opdenacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4210530.AR5GZgidVz@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=michael.opdenacker@free-electrons.com \
--cc=prabhakar.csengg@gmail.com \
--cc=sakari.ailus@iki.fi \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox