From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:42576 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750928AbcKOTHv (ORCPT ); Tue, 15 Nov 2016 14:07:51 -0500 From: Laurent Pinchart To: Sakari Ailus Cc: Edgar Thier , linux-media@vger.kernel.org Subject: Re: [PATCH] uvcvideo: Add bayer 16-bit format patterns Date: Tue, 15 Nov 2016 21:07:59 +0200 Message-ID: <4228838.ihduIDFkeB@avalon> In-Reply-To: <20161115170402.GY3217@valkosipuli.retiisi.org.uk> References: <87h97achun.fsf@edgarthier.net> <1640565.qtzjRM8HWd@avalon> <20161115170402.GY3217@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sakari, On Tuesday 15 Nov 2016 19:04:02 Sakari Ailus wrote: > On Tue, Nov 15, 2016 at 04:44:04PM +0200, Laurent Pinchart wrote: > > Hi Sakari, > > ... > > >> +Description > >> +=========== > >> + > >> +These four pixel formats are raw sRGB / Bayer formats with 16 bits per > >> +sample. Each sample is stored in a 16-bit word. Each n-pixel row > >> contains > >> +n/2 green samples and n/2 blue or red samples, with alternating red and > >> blue > >> +rows. Bytes are stored in memory in little endian order. They are > >> +conventionally described as GRGR... BGBG..., RGRG... GBGB..., etc. > >> Below is > >> +an example of one of these formats: > > > > To make it clearer, how about telling which format that is ? > > I don't object the change as such, but the text is the same than on other > bayer formats as well. The fix should not be done on this one only. > > I propose to handle that separately if that's ok for you. I'm fine with that, can you submit a patch ? :-) -- Regards, Laurent Pinchart