linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* V4L: mt9m032: fix compilation breakage
@ 2012-04-18  7:59 Guennadi Liakhovetski
  2012-04-18 10:05 ` Laurent Pinchart
  0 siblings, 1 reply; 2+ messages in thread
From: Guennadi Liakhovetski @ 2012-04-18  7:59 UTC (permalink / raw)
  To: Linux Media Mailing List; +Cc: Laurent Pinchart

Fix the following compilation failure:

linux-2.6/drivers/media/video/mt9m032.c: In function '__mt9m032_get_pad_crop':
linux-2.6/drivers/media/video/mt9m032.c:337: error: implicit declaration of function 'v4l2_subdev_get_try_crop'
linux-2.6/drivers/media/video/mt9m032.c:337: warning: return makes pointer from integer without a cast
linux-2.6/drivers/media/video/mt9m032.c: In function '__mt9m032_get_pad_format':
linux-2.6/drivers/media/video/mt9m032.c:359: error: implicit declaration of function 'v4l2_subdev_get_try_format'
linux-2.6/drivers/media/video/mt9m032.c:359: warning: return makes pointer from integer without a cast
linux-2.6/drivers/media/video/mt9m032.c: In function 'mt9m032_probe':
linux-2.6/drivers/media/video/mt9m032.c:767: error: 'struct v4l2_subdev' has no member named 'entity'
linux-2.6/drivers/media/video/mt9m032.c:826: error: 'struct v4l2_subdev' has no member named 'entity'
linux-2.6/drivers/media/video/mt9m032.c: In function 'mt9m032_remove':
linux-2.6/drivers/media/video/mt9m032.c:842: error: 'struct v4l2_subdev' has no member named 'entity'
make[4]: *** [drivers/media/video/mt9m032.o] Error 1

by adding a dependency on VIDEO_V4L2_SUBDEV_API.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
 drivers/media/video/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index f2479c5..ce1e7ba 100644
--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -492,7 +492,7 @@ config VIDEO_VS6624
 
 config VIDEO_MT9M032
 	tristate "MT9M032 camera sensor support"
-	depends on I2C && VIDEO_V4L2
+	depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
 	select VIDEO_APTINA_PLL
 	---help---
 	  This driver supports MT9M032 camera sensors from Aptina, monochrome
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: V4L: mt9m032: fix compilation breakage
  2012-04-18  7:59 V4L: mt9m032: fix compilation breakage Guennadi Liakhovetski
@ 2012-04-18 10:05 ` Laurent Pinchart
  0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2012-04-18 10:05 UTC (permalink / raw)
  To: Guennadi Liakhovetski; +Cc: Linux Media Mailing List

Hi Guennadi,

Thanks for the patch.

On Wednesday 18 April 2012 09:59:01 Guennadi Liakhovetski wrote:
> Fix the following compilation failure:
> 
> linux-2.6/drivers/media/video/mt9m032.c: In function
> '__mt9m032_get_pad_crop': linux-2.6/drivers/media/video/mt9m032.c:337:
> error: implicit declaration of function 'v4l2_subdev_get_try_crop'
> linux-2.6/drivers/media/video/mt9m032.c:337: warning: return makes pointer
> from integer without a cast linux-2.6/drivers/media/video/mt9m032.c: In
> function '__mt9m032_get_pad_format':
> linux-2.6/drivers/media/video/mt9m032.c:359: error: implicit declaration of
> function 'v4l2_subdev_get_try_format'
> linux-2.6/drivers/media/video/mt9m032.c:359: warning: return makes pointer
> from integer without a cast linux-2.6/drivers/media/video/mt9m032.c: In
> function 'mt9m032_probe': linux-2.6/drivers/media/video/mt9m032.c:767:
> error: 'struct v4l2_subdev' has no member named 'entity'
> linux-2.6/drivers/media/video/mt9m032.c:826: error: 'struct v4l2_subdev'
> has no member named 'entity' linux-2.6/drivers/media/video/mt9m032.c: In
> function 'mt9m032_remove': linux-2.6/drivers/media/video/mt9m032.c:842:
> error: 'struct v4l2_subdev' has no member named 'entity' make[4]: ***
> [drivers/media/video/mt9m032.o] Error 1
> 
> by adding a dependency on VIDEO_V4L2_SUBDEV_API.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Applied to my tree.

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-04-18 10:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-18  7:59 V4L: mt9m032: fix compilation breakage Guennadi Liakhovetski
2012-04-18 10:05 ` Laurent Pinchart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).