From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:47251 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751676Ab2HFHea (ORCPT ); Mon, 6 Aug 2012 03:34:30 -0400 From: Federico Vaga To: Hans Verkuil Cc: Mauro Carvalho Chehab , Pawel Osciak , Marek Szyprowski , Hans Verkuil , Giancarlo Asnaghi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Corbet Subject: Re: Update VIP to videobuf2 and control framework Date: Mon, 06 Aug 2012 09:38:10 +0200 Message-ID: <4296967.xtOULN4YkB@harkonnen> In-Reply-To: <201208060926.40164.hverkuil@xs4all.nl> References: <1343765829-6006-1-git-send-email-federico.vaga@gmail.com> <5055608.KkUHWr6mgc@harkonnen> <201208060926.40164.hverkuil@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: > > I applied all your suggestions, and some extra simplification; > > [...] > > --------------- > > - flags: optional. Set to V4L2_FL_USE_FH_PRIO if you want to let the > > framework handle the VIDIOC_G/S_PRIORITY ioctls. This requires that > > you use struct v4l2_fh. > > ^^^^^^^^^^^^^^^^^^ > > Are you using struct v4l2_fh? The version you posted didn't. You need > this anyway to implement control events. Yes I'm using it now, it is part of the extra simplification that I did. -- Federico Vaga