From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:38200 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932608AbeENQDI (ORCPT ); Mon, 14 May 2018 12:03:08 -0400 Received: by mail-pl0-f66.google.com with SMTP id c11-v6so7639134plr.5 for ; Mon, 14 May 2018 09:03:08 -0700 (PDT) Subject: Re: [PATCH 5/7] imx: fix compiler warning To: Hans Verkuil , linux-media@vger.kernel.org Cc: Hans Verkuil , Philipp Zabel References: <20180514131346.15795-1-hverkuil@xs4all.nl> <20180514131346.15795-6-hverkuil@xs4all.nl> From: Steve Longerbeam Message-ID: <42a74bf5-6c5e-b5d7-d0ae-1eb015e16c32@gmail.com> Date: Mon, 14 May 2018 09:03:05 -0700 MIME-Version: 1.0 In-Reply-To: <20180514131346.15795-6-hverkuil@xs4all.nl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-media-owner@vger.kernel.org List-ID: Acked-by: Steve Longerbeam On 05/14/2018 06:13 AM, Hans Verkuil wrote: > From: Hans Verkuil > > drivers/staging/media/imx/imx-media-capture.c: In function 'vidioc_querycap': > drivers/staging/media/imx/imx-media-capture.c:76:2: warning: 'strncpy' output truncated copying 15 bytes from a string of length 17 [-Wstringop-truncation] > strncpy(cap->driver, "imx-media-capture", sizeof(cap->driver) - 1); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Signed-off-by: Hans Verkuil > Cc: Steve Longerbeam > Cc: Philipp Zabel > --- > drivers/staging/media/imx/imx-media-capture.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/imx/imx-media-capture.c b/drivers/staging/media/imx/imx-media-capture.c > index 0ccabe04b0e1..4e3fdf8aeef5 100644 > --- a/drivers/staging/media/imx/imx-media-capture.c > +++ b/drivers/staging/media/imx/imx-media-capture.c > @@ -73,8 +73,8 @@ static int vidioc_querycap(struct file *file, void *fh, > { > struct capture_priv *priv = video_drvdata(file); > > - strncpy(cap->driver, "imx-media-capture", sizeof(cap->driver) - 1); > - strncpy(cap->card, "imx-media-capture", sizeof(cap->card) - 1); > + strlcpy(cap->driver, "imx-media-capture", sizeof(cap->driver)); > + strlcpy(cap->card, "imx-media-capture", sizeof(cap->card)); > snprintf(cap->bus_info, sizeof(cap->bus_info), > "platform:%s", priv->src_sd->name); >