From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] s5k6aa: off by one in s5k6aa_enum_frame_interval()
Date: Fri, 23 Aug 2013 14:54:01 +0200 [thread overview]
Message-ID: <4319865.UMEVfJshWy@avalon> (raw)
In-Reply-To: <20130823093306.GH31293@elgon.mountain>
Hi Dan,
Thank you for the patch.
On Friday 23 August 2013 12:33:06 Dan Carpenter wrote:
> The check is off by one so we could read one space past the end of the
> array.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Mauro, I have no other pending sensor patches, can you pick this one up from
the list, or should I send you a pull request ?
> diff --git a/drivers/media/i2c/s5k6aa.c b/drivers/media/i2c/s5k6aa.c
> index 789c02a..629a5cd 100644
> --- a/drivers/media/i2c/s5k6aa.c
> +++ b/drivers/media/i2c/s5k6aa.c
> @@ -1003,7 +1003,7 @@ static int s5k6aa_enum_frame_interval(struct
> v4l2_subdev *sd, const struct s5k6aa_interval *fi;
> int ret = 0;
>
> - if (fie->index > ARRAY_SIZE(s5k6aa_intervals))
> + if (fie->index >= ARRAY_SIZE(s5k6aa_intervals))
> return -EINVAL;
>
> v4l_bound_align_image(&fie->width, S5K6AA_WIN_WIDTH_MIN,
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-08-23 12:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 9:33 [patch] [media] s5k6aa: off by one in s5k6aa_enum_frame_interval() Dan Carpenter
2013-08-23 12:54 ` Laurent Pinchart [this message]
2013-08-23 13:11 ` Sylwester Nawrocki
2013-08-23 13:16 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4319865.UMEVfJshWy@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox