From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 2/3] smiapp: Set sub-device owner
Date: Thu, 17 Jul 2014 12:22:47 +0200 [thread overview]
Message-ID: <4340191.d162iopR0n@avalon> (raw)
In-Reply-To: <1396017313-3990-3-git-send-email-sakari.ailus@linux.intel.com>
Hi Sakari,
What happened to this patch ? 1/3 and 3/3 from the same series seem to have
been applied, but not 2/3.
On Friday 28 March 2014 16:35:12 Sakari Ailus wrote:
> The smiapp driver is the owner of the sub-devices exposed by the smiapp
> driver. This prevents unloading the module whilst it's in use.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/media/i2c/smiapp/smiapp-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
> b/drivers/media/i2c/smiapp/smiapp-core.c index 69c11ec..5179cf4 100644
> --- a/drivers/media/i2c/smiapp/smiapp-core.c
> +++ b/drivers/media/i2c/smiapp/smiapp-core.c
> @@ -2569,7 +2569,7 @@ static int smiapp_registered(struct v4l2_subdev
> *subdev)
>
> this->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
> this->sd.internal_ops = &smiapp_internal_ops;
> - this->sd.owner = NULL;
> + this->sd.owner = THIS_MODULE;
> v4l2_set_subdevdata(&this->sd, client);
>
> rval = media_entity_init(&this->sd.entity,
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-07-17 10:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 14:35 [PATCH 0/3] Small smiapp changes Sakari Ailus
2014-03-28 14:35 ` [PATCH 1/3] smiapp: Use I2C adapter ID and address in the sub-device name Sakari Ailus
2014-03-28 14:35 ` [PATCH 2/3] smiapp: Set sub-device owner Sakari Ailus
2014-07-17 10:22 ` Laurent Pinchart [this message]
2014-07-17 11:00 ` Sakari Ailus
2014-03-28 14:35 ` [PATCH 3/3] smiapp: Make PLL flags separate from regular quirk flags Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4340191.d162iopR0n@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox