From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <m.chehab@samsung.com>
Subject: Re: [linuxtv-media:master 447/499] drivers/media/common/saa7146/saa7146_fops.c:536:13: sparse: incorrect type in assignment (different base types)
Date: Fri, 18 Jul 2014 14:22:59 +0200 [thread overview]
Message-ID: <4422409.ePkxGiM47W@avalon> (raw)
In-Reply-To: <53C90BED.4040805@xs4all.nl>
On Friday 18 July 2014 13:58:37 Hans Verkuil wrote:
> On 07/18/14 13:53, Laurent Pinchart wrote:
> > On Friday 18 July 2014 07:56:52 kbuild test robot wrote:
> >> tree: git://linuxtv.org/media_tree.git master
> >> head: 0ca1ba2aac5f6b26672099b13040c5b40db93486
> >> commit: d52e23813672c3c72f92e7b39c7408d4b9a40a96 [447/499] [media] v4l:
> >> Support extending the v4l2_pix_format structure reproduce: make C=1
> >> CF=-D__CHECK_ENDIAN__
> >>
> >>
> >> sparse warnings: (new ones prefixed by >>)
> >>
> >>>> drivers/media/common/saa7146/saa7146_fops.c:536:13: sparse: incorrect
> >>>> type in assignment (different base types)
> >>>>
> >> drivers/media/common/saa7146/saa7146_fops.c:536:13: expected struct
> >>
> >> v4l2_pix_format *fmt drivers/media/common/saa7146/saa7146_fops.c:536:13:
> >> got struct <noident> *<noident>
> >> drivers/media/common/saa7146/saa7146_fops.c: In function
> >> 'saa7146_vv_init':
> >> drivers/media/common/saa7146/saa7146_fops.c:536:6: warning: assignment
> >> from
> >> incompatible pointer type [enabled by default] fmt = &vv->ov_fb.fmt;
> >>
> >> ^
> >
> > I'll send a patch to fix that.
>
> I posted a fix for that already:
>
> [PATCH for v3.17] saa7146: fix compile warning
>
> Part of pull request https://patchwork.linuxtv.org/patch/24885/
Thank you. For what it's worth,
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2014-07-18 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 23:56 [linuxtv-media:master 447/499] drivers/media/common/saa7146/saa7146_fops.c:536:13: sparse: incorrect type in assignment (different base types) kbuild test robot
2014-07-18 11:53 ` Laurent Pinchart
2014-07-18 11:58 ` Hans Verkuil
2014-07-18 12:22 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4422409.ePkxGiM47W@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox