linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [linuxtv-media:master 447/499] drivers/media/common/saa7146/saa7146_fops.c:536:13: sparse: incorrect type in assignment (different base types)
@ 2014-07-17 23:56 kbuild test robot
  2014-07-18 11:53 ` Laurent Pinchart
  0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2014-07-17 23:56 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: linux-media, Mauro Carvalho Chehab, kbuild-all

tree:   git://linuxtv.org/media_tree.git master
head:   0ca1ba2aac5f6b26672099b13040c5b40db93486
commit: d52e23813672c3c72f92e7b39c7408d4b9a40a96 [447/499] [media] v4l: Support extending the v4l2_pix_format structure
reproduce: make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/media/common/saa7146/saa7146_fops.c:536:13: sparse: incorrect type in assignment (different base types)
   drivers/media/common/saa7146/saa7146_fops.c:536:13:    expected struct v4l2_pix_format *fmt
   drivers/media/common/saa7146/saa7146_fops.c:536:13:    got struct <noident> *<noident>
   drivers/media/common/saa7146/saa7146_fops.c: In function 'saa7146_vv_init':
   drivers/media/common/saa7146/saa7146_fops.c:536:6: warning: assignment from incompatible pointer type [enabled by default]
     fmt = &vv->ov_fb.fmt;
         ^

vim +536 drivers/media/common/saa7146/saa7146_fops.c

^1da177e4 drivers/media/common/saa7146_fops.c Linus Torvalds        2005-04-16  520  	   configuration data) */
^1da177e4 drivers/media/common/saa7146_fops.c Linus Torvalds        2005-04-16  521  	dev->ext_vv_data = ext_vv;
afd1a0c9a drivers/media/common/saa7146_fops.c Mauro Carvalho Chehab 2005-12-12  522  
afd1a0c9a drivers/media/common/saa7146_fops.c Mauro Carvalho Chehab 2005-12-12  523  	vv->d_clipping.cpu_addr = pci_alloc_consistent(dev->pci, SAA7146_CLIPPING_MEM, &vv->d_clipping.dma_handle);
^1da177e4 drivers/media/common/saa7146_fops.c Linus Torvalds        2005-04-16  524  	if( NULL == vv->d_clipping.cpu_addr ) {
44d0b80e5 drivers/media/common/saa7146_fops.c Joe Perches           2011-08-21  525  		ERR("out of memory. aborting.\n");
^1da177e4 drivers/media/common/saa7146_fops.c Linus Torvalds        2005-04-16  526  		kfree(vv);
6e65ca942 drivers/media/common/saa7146_fops.c Hans Verkuil          2012-04-29  527  		v4l2_ctrl_handler_free(hdl);
^1da177e4 drivers/media/common/saa7146_fops.c Linus Torvalds        2005-04-16  528  		return -1;
^1da177e4 drivers/media/common/saa7146_fops.c Linus Torvalds        2005-04-16  529  	}
^1da177e4 drivers/media/common/saa7146_fops.c Linus Torvalds        2005-04-16  530  	memset(vv->d_clipping.cpu_addr, 0x0, SAA7146_CLIPPING_MEM);
^1da177e4 drivers/media/common/saa7146_fops.c Linus Torvalds        2005-04-16  531  
^1da177e4 drivers/media/common/saa7146_fops.c Linus Torvalds        2005-04-16  532  	saa7146_video_uops.init(dev,vv);
5b0fa4fff drivers/media/common/saa7146_fops.c Oliver Endriss        2006-01-09  533  	if (dev->ext_vv_data->capabilities & V4L2_CAP_VBI_CAPTURE)
5b0fa4fff drivers/media/common/saa7146_fops.c Oliver Endriss        2006-01-09  534  		saa7146_vbi_uops.init(dev,vv);
afd1a0c9a drivers/media/common/saa7146_fops.c Mauro Carvalho Chehab 2005-12-12  535  
5da545ad0 drivers/media/common/saa7146_fops.c Hans Verkuil          2012-05-01 @536  	fmt = &vv->ov_fb.fmt;
5da545ad0 drivers/media/common/saa7146_fops.c Hans Verkuil          2012-05-01  537  	fmt->width = vv->standard->h_max_out;
5da545ad0 drivers/media/common/saa7146_fops.c Hans Verkuil          2012-05-01  538  	fmt->height = vv->standard->v_max_out;
5da545ad0 drivers/media/common/saa7146_fops.c Hans Verkuil          2012-05-01  539  	fmt->pixelformat = V4L2_PIX_FMT_RGB565;
5da545ad0 drivers/media/common/saa7146_fops.c Hans Verkuil          2012-05-01  540  	fmt->bytesperline = 2 * fmt->width;
5da545ad0 drivers/media/common/saa7146_fops.c Hans Verkuil          2012-05-01  541  	fmt->sizeimage = fmt->bytesperline * fmt->height;
5da545ad0 drivers/media/common/saa7146_fops.c Hans Verkuil          2012-05-01  542  	fmt->colorspace = V4L2_COLORSPACE_SRGB;
fd74d6eb4 drivers/media/common/saa7146_fops.c Hans Verkuil          2012-05-01  543  
fd74d6eb4 drivers/media/common/saa7146_fops.c Hans Verkuil          2012-05-01  544  	fmt = &vv->video_fmt;

:::::: The code at line 536 was first introduced by commit
:::::: 5da545ad08a3c6ea71d3ba074adc7582e7e9a024 [media] saa7146: move overlay information from saa7146_fh into saa7146_vv

:::::: TO: Hans Verkuil <hans.verkuil@cisco.com>
:::::: CC: Mauro Carvalho Chehab <mchehab@redhat.com>

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [linuxtv-media:master 447/499] drivers/media/common/saa7146/saa7146_fops.c:536:13: sparse: incorrect type in assignment (different base types)
  2014-07-17 23:56 [linuxtv-media:master 447/499] drivers/media/common/saa7146/saa7146_fops.c:536:13: sparse: incorrect type in assignment (different base types) kbuild test robot
@ 2014-07-18 11:53 ` Laurent Pinchart
  2014-07-18 11:58   ` Hans Verkuil
  0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2014-07-18 11:53 UTC (permalink / raw)
  To: linux-media; +Cc: Mauro Carvalho Chehab

On Friday 18 July 2014 07:56:52 kbuild test robot wrote:
> tree:   git://linuxtv.org/media_tree.git master
> head:   0ca1ba2aac5f6b26672099b13040c5b40db93486
> commit: d52e23813672c3c72f92e7b39c7408d4b9a40a96 [447/499] [media] v4l:
> Support extending the v4l2_pix_format structure reproduce: make C=1
> CF=-D__CHECK_ENDIAN__
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
> >> drivers/media/common/saa7146/saa7146_fops.c:536:13: sparse: incorrect
> >> type in assignment (different base types)
>    drivers/media/common/saa7146/saa7146_fops.c:536:13:    expected struct
> v4l2_pix_format *fmt drivers/media/common/saa7146/saa7146_fops.c:536:13:   
> got struct <noident> *<noident>
> drivers/media/common/saa7146/saa7146_fops.c: In function 'saa7146_vv_init':
> drivers/media/common/saa7146/saa7146_fops.c:536:6: warning: assignment from
> incompatible pointer type [enabled by default] fmt = &vv->ov_fb.fmt;
>          ^

I'll send a patch to fix that.

> vim +536 drivers/media/common/saa7146/saa7146_fops.c
> 
> ^1da177e4 drivers/media/common/saa7146_fops.c Linus Torvalds       
> 2005-04-16  520  	   configuration data) */ ^1da177e4
> drivers/media/common/saa7146_fops.c Linus Torvalds        2005-04-16  521 
> 	dev->ext_vv_data = ext_vv; afd1a0c9a drivers/media/common/saa7146_fops.c
> Mauro Carvalho Chehab 2005-12-12  522 afd1a0c9a
> drivers/media/common/saa7146_fops.c Mauro Carvalho Chehab 2005-12-12  523 
> 	vv->d_clipping.cpu_addr = pci_alloc_consistent(dev->pci,
> SAA7146_CLIPPING_MEM, &vv->d_clipping.dma_handle); ^1da177e4
> drivers/media/common/saa7146_fops.c Linus Torvalds        2005-04-16  524 
> 	if( NULL == vv->d_clipping.cpu_addr ) { 44d0b80e5
> drivers/media/common/saa7146_fops.c Joe Perches           2011-08-21  525 
> 		ERR("out of memory. aborting.\n"); ^1da177e4
> drivers/media/common/saa7146_fops.c Linus Torvalds        2005-04-16  526 
> 		kfree(vv); 6e65ca942 drivers/media/common/saa7146_fops.c Hans Verkuil    
>      2012-04-29  527  		v4l2_ctrl_handler_free(hdl); ^1da177e4
> drivers/media/common/saa7146_fops.c Linus Torvalds        2005-04-16  528 
> 		return -1; ^1da177e4 drivers/media/common/saa7146_fops.c Linus 
Torvalds  
>      2005-04-16  529  	} ^1da177e4 drivers/media/common/saa7146_fops.c
> Linus Torvalds        2005-04-16  530  	memset(vv->d_clipping.cpu_addr,
> 0x0, SAA7146_CLIPPING_MEM); ^1da177e4 drivers/media/common/saa7146_fops.c
> Linus Torvalds        2005-04-16  531 ^1da177e4
> drivers/media/common/saa7146_fops.c Linus Torvalds        2005-04-16  532 
> 	saa7146_video_uops.init(dev,vv); 5b0fa4fff
> drivers/media/common/saa7146_fops.c Oliver Endriss        2006-01-09  533 
> 	if (dev->ext_vv_data->capabilities & V4L2_CAP_VBI_CAPTURE) 5b0fa4fff
> drivers/media/common/saa7146_fops.c Oliver Endriss        2006-01-09  534 
> 		saa7146_vbi_uops.init(dev,vv); afd1a0c9a
> drivers/media/common/saa7146_fops.c Mauro Carvalho Chehab 2005-12-12  535
> 5da545ad0 drivers/media/common/saa7146_fops.c Hans Verkuil         
> 2012-05-01 @536  	fmt = &vv->ov_fb.fmt; 5da545ad0
> drivers/media/common/saa7146_fops.c Hans Verkuil          2012-05-01  537 
> 	fmt->width = vv->standard->h_max_out; 5da545ad0
> drivers/media/common/saa7146_fops.c Hans Verkuil          2012-05-01  538 
> 	fmt->height = vv->standard->v_max_out; 5da545ad0
> drivers/media/common/saa7146_fops.c Hans Verkuil          2012-05-01  539 
> 	fmt->pixelformat = V4L2_PIX_FMT_RGB565; 5da545ad0
> drivers/media/common/saa7146_fops.c Hans Verkuil          2012-05-01  540 
> 	fmt->bytesperline = 2 * fmt->width; 5da545ad0
> drivers/media/common/saa7146_fops.c Hans Verkuil          2012-05-01  541 
> 	fmt->sizeimage = fmt->bytesperline * fmt->height; 5da545ad0
> drivers/media/common/saa7146_fops.c Hans Verkuil          2012-05-01  542 
> 	fmt->colorspace = V4L2_COLORSPACE_SRGB; fd74d6eb4
> drivers/media/common/saa7146_fops.c Hans Verkuil          2012-05-01  543
> fd74d6eb4 drivers/media/common/saa7146_fops.c Hans Verkuil         
> 2012-05-01  544  	fmt = &vv->video_fmt;
> :::::: The code at line 536 was first introduced by commit
> :::::: 5da545ad08a3c6ea71d3ba074adc7582e7e9a024 [media] saa7146: move
> :::::: overlay information from saa7146_fh into saa7146_vv
> :::::: 
> :::::: TO: Hans Verkuil <hans.verkuil@cisco.com>
> :::::: CC: Mauro Carvalho Chehab <mchehab@redhat.com>

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [linuxtv-media:master 447/499] drivers/media/common/saa7146/saa7146_fops.c:536:13: sparse: incorrect type in assignment (different base types)
  2014-07-18 11:53 ` Laurent Pinchart
@ 2014-07-18 11:58   ` Hans Verkuil
  2014-07-18 12:22     ` Laurent Pinchart
  0 siblings, 1 reply; 4+ messages in thread
From: Hans Verkuil @ 2014-07-18 11:58 UTC (permalink / raw)
  To: Laurent Pinchart, linux-media; +Cc: Mauro Carvalho Chehab

On 07/18/14 13:53, Laurent Pinchart wrote:
> On Friday 18 July 2014 07:56:52 kbuild test robot wrote:
>> tree:   git://linuxtv.org/media_tree.git master
>> head:   0ca1ba2aac5f6b26672099b13040c5b40db93486
>> commit: d52e23813672c3c72f92e7b39c7408d4b9a40a96 [447/499] [media] v4l:
>> Support extending the v4l2_pix_format structure reproduce: make C=1
>> CF=-D__CHECK_ENDIAN__
>>
>>
>> sparse warnings: (new ones prefixed by >>)
>>
>>>> drivers/media/common/saa7146/saa7146_fops.c:536:13: sparse: incorrect
>>>> type in assignment (different base types)
>>    drivers/media/common/saa7146/saa7146_fops.c:536:13:    expected struct
>> v4l2_pix_format *fmt drivers/media/common/saa7146/saa7146_fops.c:536:13:   
>> got struct <noident> *<noident>
>> drivers/media/common/saa7146/saa7146_fops.c: In function 'saa7146_vv_init':
>> drivers/media/common/saa7146/saa7146_fops.c:536:6: warning: assignment from
>> incompatible pointer type [enabled by default] fmt = &vv->ov_fb.fmt;
>>          ^
> 
> I'll send a patch to fix that.

I posted a fix for that already:

[PATCH for v3.17] saa7146: fix compile warning

Part of pull request https://patchwork.linuxtv.org/patch/24885/

Regards,

	Hans

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [linuxtv-media:master 447/499] drivers/media/common/saa7146/saa7146_fops.c:536:13: sparse: incorrect type in assignment (different base types)
  2014-07-18 11:58   ` Hans Verkuil
@ 2014-07-18 12:22     ` Laurent Pinchart
  0 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2014-07-18 12:22 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: linux-media, Mauro Carvalho Chehab

On Friday 18 July 2014 13:58:37 Hans Verkuil wrote:
> On 07/18/14 13:53, Laurent Pinchart wrote:
> > On Friday 18 July 2014 07:56:52 kbuild test robot wrote:
> >> tree:   git://linuxtv.org/media_tree.git master
> >> head:   0ca1ba2aac5f6b26672099b13040c5b40db93486
> >> commit: d52e23813672c3c72f92e7b39c7408d4b9a40a96 [447/499] [media] v4l:
> >> Support extending the v4l2_pix_format structure reproduce: make C=1
> >> CF=-D__CHECK_ENDIAN__
> >> 
> >> 
> >> sparse warnings: (new ones prefixed by >>)
> >> 
> >>>> drivers/media/common/saa7146/saa7146_fops.c:536:13: sparse: incorrect
> >>>> type in assignment (different base types)
> >>>> 
> >>    drivers/media/common/saa7146/saa7146_fops.c:536:13:    expected struct
> >> 
> >> v4l2_pix_format *fmt drivers/media/common/saa7146/saa7146_fops.c:536:13:
> >> got struct <noident> *<noident>
> >> drivers/media/common/saa7146/saa7146_fops.c: In function
> >> 'saa7146_vv_init':
> >> drivers/media/common/saa7146/saa7146_fops.c:536:6: warning: assignment
> >> from
> >> incompatible pointer type [enabled by default] fmt = &vv->ov_fb.fmt;
> >> 
> >>          ^
> > 
> > I'll send a patch to fix that.
> 
> I posted a fix for that already:
> 
> [PATCH for v3.17] saa7146: fix compile warning
> 
> Part of pull request https://patchwork.linuxtv.org/patch/24885/

Thank you. For what it's worth,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-18 12:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-17 23:56 [linuxtv-media:master 447/499] drivers/media/common/saa7146/saa7146_fops.c:536:13: sparse: incorrect type in assignment (different base types) kbuild test robot
2014-07-18 11:53 ` Laurent Pinchart
2014-07-18 11:58   ` Hans Verkuil
2014-07-18 12:22     ` Laurent Pinchart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).