Re: [PATCH v3 04/33] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

Laurent Pinchart
2012-02-21T16:15:04Z

Hi Sakari,

One more comment.

On Monday 20 February 2012 03:56:43 Sakari Ailus wrote:

[snip]

> +/* active cropping area */
> +#define V4L2_SUBDEV_SEL_TGT_CROP_ACTIVE 0x0000
> +/* cropping bounds */
> +#define V4L2_SUBDEV_SEL_TGT_CROP_BOUNDS 0x0002
> +/* current composing area */
> +#define V4L2_SUBDEV_SEL_TGT_COMPOSE_ACTIVE 0x0100
> +/* composing bounds */

I'm not sure if ACTIVE is a good name here. It sounds confusing as we already
have V4L2_SUBDEV_FORMAT_ACTIVE.

--
Regards,

Laurent Pinchart