Re: [PATCH v3 05/33] v4l: vdev_to_v4l2_subdev() should have return type "struct v4l2_subdev *"

Laurent Pinchart
2012-02-21T14:37:41Z

Hi Sakari,

Thanks for the patch.

On Monday 20 February 2012 03:56:44 Sakari Ailus wrote:
> vdev_to_v4l2_subdev() should return struct v4l2_subdev *, not void *. Fix
> this.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>

Sounds like you've been bitten by this :-)

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> include/media/v4l2-subdev.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> index feab950..bcaf6b8 100644
> --- a/include/media/v4l2-subdev.h
> +++ b/include/media/v4l2-subdev.h
> @@ -545,7 +545,7 @@ struct v4l2_subdev {
> #define media_entity_to_v4l2_subdev(ent) \
> container_of(ent, struct v4l2_subdev, entity)
> #define vdev_to_v4l2_subdev(vdev) \
> - video_get_drvdata(vdev)
> + ((struct v4l2_subdev *)video_get_drvdata(vdev))
>
> /*
> * Used for storing subdev information per file handle
--
Regards,

Laurent Pinchart