Re: [PATCH] scsi: buslogic: replace strcpy() with strscpy()

[Atharv Dubey <atharvd440@gmail.com>]

A Gentle Reminder for reviewing the patch.

Thanks,
Atharv

On 3/14/26 01:58, Atharv Dubey wrote:
> strcpy() is deprecated as it does not perform bounds checking[1].
> Using it can risk buffer overflows if the source string exceeds
> the destination.
>
> Replace occurrences of strcpy() with the safer strscpy() where
> the size of buffer is being checked.
>
> Compile tested.
>
> [1] Documentation/process/deprecated.rst
>
> Signed-off-by: Atharv Dubey <atharvd440@gmail.com>
> ---
>   drivers/scsi/BusLogic.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
> index da6599ae3d0d..c070f3b8197e 100644
> --- a/drivers/scsi/BusLogic.c
> +++ b/drivers/scsi/BusLogic.c
> @@ -1262,7 +1262,7 @@ static bool __init blogic_rdconfig(struct blogic_adapter *adapter)
>   		for (i = 0; i < sizeof(fpinfo->model); i++)
>   			*tgt++ = fpinfo->model[i];
>   		*tgt++ = '\0';
> -		strcpy(adapter->fw_ver, FLASHPOINT_FW_VER);
> +		strscpy(adapter->fw_ver, FLASHPOINT_FW_VER);
>   		adapter->scsi_id = fpinfo->scsi_id;
>   		adapter->ext_trans_enable = fpinfo->ext_trans_enable;
>   		adapter->parity = fpinfo->parity;
> @@ -3451,12 +3451,12 @@ static void blogic_msg(enum blogic_msglevel msglevel, char *fmt,
>   	va_end(args);
>   	if (msglevel == BLOGIC_ANNOUNCE_LEVEL) {
>   		static int msglines = 0;
> -		strcpy(&adapter->msgbuf[adapter->msgbuflen], buf);
> +		strscpy(&adapter->msgbuf[adapter->msgbuflen], buf);
>   		adapter->msgbuflen += len;
>   		if (++msglines <= 2)
>   			printk("%sscsi: %s", blogic_msglevelmap[msglevel], buf);
>   	} else if (msglevel == BLOGIC_INFO_LEVEL) {
> -		strcpy(&adapter->msgbuf[adapter->msgbuflen], buf);
> +		strscpy(&adapter->msgbuf[adapter->msgbuflen], buf);
>   		adapter->msgbuflen += len;
>   		if (begin) {
>   			if (buf[0] != '\n' || len > 1)
>
> ---
> base-commit: 173b959a8bb814f55660f7c34ddedd4e75c203d2
> change-id: 20260314-strcpy-da7093836551
>
> Best regards,