Re: [PATCH 3/3] media: add V4L2_CAP_VDEV_CENTERED flag on vdev-centric drivers

Lubomir Rintel
2017-08-25T09:53:18Z

On Fri, 2017-08-25 at 06:40 -0300, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>
> Those devices are controlled via their V4L2 device. Add a
> flag to indicate them as such.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

Acked-by: Lubomir Rintel <lkundrak@v3.sk>

for the usbtv driver.

> ---
> drivers/media/usb/usbtv/usbtv-video.c | 2 +-

> diff --git a/drivers/media/usb/usbtv/usbtv-video.c b/drivers/media/usb/usbtv/usbtv-video.c
> index 8135614f395a..724dbcb8de9b 100644
> --- a/drivers/media/usb/usbtv/usbtv-video.c
> +++ b/drivers/media/usb/usbtv/usbtv-video.c
> @@ -520,7 +520,7 @@ static int usbtv_querycap(struct file *file, void *priv,
> strlcpy(cap->driver, "usbtv", sizeof(cap->driver));
> strlcpy(cap->card, "usbtv", sizeof(cap->card));
> usb_make_path(dev->udev, cap->bus_info, sizeof(cap->bus_info));
> - cap->device_caps = V4L2_CAP_VIDEO_CAPTURE;
> + cap->device_caps = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_VDEV_CENTERED;
> cap->device_caps |= V4L2_CAP_READWRITE | V4L2_CAP_STREAMING;
> cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
> return 0;
>