From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Aakarsh Jain <aakarsh.jain@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com,
mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com,
benjamin.gaignard@collabora.com,
krzysztof.kozlowski+dt@linaro.org, stanimir.varbanov@linaro.org,
dillon.minfei@gmail.com, david.plowman@raspberrypi.com,
mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org,
andi@etezian.org, alim.akhtar@samsung.com,
aswani.reddy@samsung.com, pankaj.dubey@samsung.com,
smitha.t@samsung.com
Subject: Re: [Patch v4 3/3] ARM: dts: exynos: Add new SoC specific compatible string for Exynos3250 SoC
Date: Mon, 14 Nov 2022 08:50:51 +0100 [thread overview]
Message-ID: <451069cd-9e8f-055e-5711-fbae9e2799e8@linaro.org> (raw)
In-Reply-To: <20221114054655.68090-4-aakarsh.jain@samsung.com>
On 14/11/2022 06:46, Aakarsh Jain wrote:
> commit "752d3a23d1f68de87e3c" which adds MFC codec device node
Please run scripts/checkpatch.pl and fix reported warnings.
> for exynos3250 SoC. Since exynos3250.dtsi and exynos5420.dtsi are
> using same compatible string as "samsung,mfc-v7" but their node
> properties are different. As both SoCs have MFC v7 hardware module
> but with different clock hierarchy and complexity.
> Add new compatible string followed by mfc-v7 fallback for Exynos3250
> SoC.
>
> Reviewed-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> Suggested-by: Alim Akhtar <alim.akhtar@samsung.com>
> Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
> ---
> arch/arm/boot/dts/exynos3250.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> index 326b9e0ed8d3..1a29993fca0b 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -485,7 +485,7 @@
> };
>
> mfc: codec@13400000 {
> - compatible = "samsung,mfc-v7";
> + compatible = "samsung,exynos3250-mfc","samsung,mfc-v7";
Missing space.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-11-14 7:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221114054040epcas5p2fe1bca3fbef7f4addb5906a03f397e4e@epcas5p2.samsung.com>
2022-11-14 5:46 ` [Patch v4 0/3] Add new compatible for Exynos3250 Aakarsh Jain
2022-11-14 5:46 ` [Patch v4 1/3] media: dt-bindings: s5p-mfc: Add new compatible string for Exynos3250 SoC Aakarsh Jain
2022-11-14 7:49 ` Krzysztof Kozlowski
2022-11-14 5:46 ` [Patch v4 2/3] media: s5p-mfc: Add variant data for MFC v7 hardware for Exynos 3250 SoC Aakarsh Jain
2022-11-14 7:51 ` Krzysztof Kozlowski
2022-11-14 9:44 ` Aakarsh Jain
2022-11-14 10:05 ` Krzysztof Kozlowski
2022-11-14 5:46 ` [Patch v4 3/3] ARM: dts: exynos: Add new SoC specific compatible string for Exynos3250 SoC Aakarsh Jain
2022-11-14 7:50 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451069cd-9e8f-055e-5711-fbae9e2799e8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aakarsh.jain@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=andi@etezian.org \
--cc=andrzej.hajda@intel.com \
--cc=aswani.reddy@samsung.com \
--cc=benjamin.gaignard@collabora.com \
--cc=david.plowman@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
--cc=smitha.t@samsung.com \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox