Linux Media Controller development
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bod@kernel.org>
To: Jesse Casco <jesse.casco@gmail.com>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>,
	Allan Siriani <allan@fatecpompeia.edu.br>,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] media: qcom: camss: x1e80100: Use the lite clocks for the lite CSIDs
Date: Sat, 21 Nov 2026 09:44:03 +0000	[thread overview]
Message-ID: <455da85b-b11a-46d6-9c39-09cd59d09c8b@kernel.org> (raw)
In-Reply-To: <bf48f3c809f33c060e2944e5896f8a5a93fd78ea.1795196107.git.jesse.casco@gmail.com>

On 20/11/2026 17:40, Jesse Casco wrote:
> The X1E80100 CSID_LITE0 and CSID_LITE1 resources list the full CSID
> clocks, "csid" and "csid_csiphy_rx", instead of "vfe_lite_csid" and
> "vfe_lite_cphy_rx", which the binding provides for them. The lite CSIDs
> then run with their own CSI-2 receiver unclocked: their registers can be
> read and they raise the reset interrupt, but they never report RX, RDI
> or buffer-done interrupts, so no frame arrives.
> 
> Use the lite clocks, with the vfe_lite_csid rates the IFE_LITE entries
> already use.
> 
> Fixes: 1830cf0f56c3 ("media: qcom: camss: Add x1e80100 specific support")
> Signed-off-by: Jesse Casco <jesse.casco@gmail.com>
> ---
>   drivers/media/platform/qcom/camss/camss.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index f8e5cf9f3..7d9622097 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -4287,13 +4287,13 @@ static const struct camss_subdev_resources csid_res_x1e80100[] = {
>   	{
>   		.regulators = {},
>   		.clock = { "gcc_axi_hf", "gcc_axi_sf", "cpas_ahb",
> -			   "cpas_fast_ahb", "csid", "csid_csiphy_rx" },
> +			   "cpas_fast_ahb", "vfe_lite_csid", "vfe_lite_cphy_rx" },
>   		.clock_rate = { { 0 },
>   				{ 0 },
>   				{ 64000000, 80000000 },
>   				{ 80000000,  100000000, 200000000,
>   				  300000000, 400000000 },
> -				{ 300000000, 400000000, 480000000 },
> +				{ 266666667, 400000000, 480000000 },
>   				{ 300000000, 400000000, 480000000 }, },
>   		.reg = { "csid_lite0" },
>   		.interrupt = { "csid_lite0" },
> @@ -4308,13 +4308,13 @@ static const struct camss_subdev_resources csid_res_x1e80100[] = {
>   	{
>   		.regulators = {},
>   		.clock = { "gcc_axi_hf", "gcc_axi_sf", "cpas_ahb",
> -			   "cpas_fast_ahb", "csid", "csid_csiphy_rx" },
> +			   "cpas_fast_ahb", "vfe_lite_csid", "vfe_lite_cphy_rx" },
>   		.clock_rate = { { 0 },
>   				{ 0 },
>   				{ 64000000, 80000000 },
>   				{ 80000000,  100000000, 200000000,
>   				  300000000, 400000000 },
> -				{ 300000000, 400000000, 480000000 },
> +				{ 266666667, 400000000, 480000000 },
>   				{ 300000000, 400000000, 480000000 }, },
> 
>   		.reg = { "csid_lite1" },
> --
> 2.56.1
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

  parent reply	other threads:[~2026-11-21  9:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 17:40 [PATCH 0/2] media: qcom: camss: Fix the X1E80100 lite CSID paths Jesse Casco
2026-11-20 17:40 ` [PATCH 1/2] media: qcom: camss: x1e80100: Use the lite clocks for the lite CSIDs Jesse Casco
2026-11-20 19:29   ` Loic Poulain
2026-11-21  9:44   ` Bryan O'Donoghue [this message]
2026-11-20 17:40 ` [PATCH 2/2] media: qcom: camss: Map each CSID to the VFE it feeds Jesse Casco
2026-11-20 19:39   ` Loic Poulain
2026-11-20 19:56     ` Gjorgji Rosikopulos (Consultant)
2026-11-20 20:32       ` Gjorgji Rosikopulos (Consultant)
2026-11-20 20:51   ` Gjorgji Rosikopulos (Consultant)
2026-11-20 22:00     ` Allan Siriani
2026-11-20 20:01 ` [PATCH 0/2] media: qcom: camss: Fix the X1E80100 lite CSID paths Gjorgji Rosikopulos (Consultant)
2026-11-20 23:55   ` Jesse Casco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=455da85b-b11a-46d6-9c39-09cd59d09c8b@kernel.org \
    --to=bod@kernel.org \
    --cc=allan@fatecpompeia.edu.br \
    --cc=jesse.casco@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mchehab@kernel.org \
    --cc=nihal.gupta@oss.qualcomm.com \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox