From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed2-f35.google.com (mail-ed2-f35.google.com [74.125.228.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 886E931E822 for ; Fri, 2 Oct 2026 14:35:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790951753; cv=none; b=un6EWWeijxUSzc4L4bnFuEUMGbjuhtYysXCZg9vFnSaAV8bs2/e+ZyaBC1S5lN78Zg1H+3VxVF85ChC8QaMd2h+LXk4ksmKtB0f3npiRYkErn7Io5Arxvy41KBPK5zWFtZRzT6/nabB5H/ImREw/MnEEpbMEIMvRm9TbJR4wvzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790951753; c=relaxed/simple; bh=sEskR/3ExQTLHI71NqLlpzs/JE6M5OOwwHG9YZNTZAY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qrfr+VR0VnSLU7V3JwgrRgSnkNwU3uTEgIJ3jIVlVIg5oNe81LINw7OoiHWMveObhrDnnQaa3nGafHFzhjsUFLiXG7S0AYmSVTLnOwa+gd7Sb7+SGRHpElEZw2qjS8K77+77ZCtDx32NX+MmLJ2zKQw2gzRdHR5qOqxEaadeeBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OM7fjLjt; arc=none smtp.client-ip=74.125.228.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OM7fjLjt" Received: by mail-ed2-f35.google.com with SMTP id 4fb4d7f45d1cf-6aa1d00daaaso13317912a12.1 for ; Fri, 02 Oct 2026 07:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1790951750; x=1791556550; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=tnnaK1bgjoHXdx4TLwgBNAZANL+ZBN5rHCxr30tdrTw=; b=OM7fjLjthjUwEd0GpjeI8BQRE7H8dKViyY9tMVjlOk3mh4SRm1wpryj8WyanqV+qeX bc2PbvW09240D6r9g+3PRl3XtqISSfiCWEhTZ9Xdk5NU2C4KPil/aUP/NgzIypJw0eSt ybZsGUurjdNY6uXbz/+sU2EJVKu8Aci92SWB0+XKUZh+yw9fh0hsFi76LsyoJEY0QmOp gYANqf/kmpL6bpm22VIKnMFmlfk8vYTjYwaXjSEydMEzH6ows7TgL1yzGo7ZijNPSxzQ 06PQxgreAxbPjVa80MvNyldbr+hB9vG5sjTifjO5fFiHF74F3BJvnejqLnEGYdz8XNGq BtuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790951750; x=1791556550; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tnnaK1bgjoHXdx4TLwgBNAZANL+ZBN5rHCxr30tdrTw=; b=ZDeSYuWrV4AZUzu3QwMJnp7h9CnKoaMda/HfVTFU8mkYy78fu4FDLqTljSxCjP7U7+ voH+agGdYNP6pLi4tqEk4rP3FIsAmpqVmuyEDWyOAwR9JlHtYXpbn9zWGsZuLNXsF408 IyaiaPkY5iDy9ls4+wnrj/UTfj+yww9lU/EQXDFDIu5DVH6QNUPJWPpP77BVoO4wR8Sl KEYPlgP2OZKHUNIy981SiKqiM0F3fmCVNZ4tCWF7OC+reeRehvuCGS8ZOXcUm3umkLNt XrUoO3ZcoP+js8n9pWUWi+07MxNuCJF7TtiYnzqFn8kP/fADO0/OMjBV9ScA/otDCC7c ruVw== X-Forwarded-Encrypted: i=1; AKwUvBxV5PO93IQ9lr/rVaGxyeba795GNZMhFAmllh6YQ4df/1VSe0qDwAKsF0P5dyContVIiY92urt28SnCDg==@vger.kernel.org X-Gm-Message-State: AFq9FYIdttCgVK3A047xdGTJ3a4oCvXAU5ekVio7q+NN87xHwvspGr4D pjFb029DUOZyYa2O+Wl7L8YizDLpeeXVEOjXD4q1rfvnf5KhtXOy4W8g68feA459QY0= X-Gm-Gg: AYBFou29URiQUUMbBXqHzntg5zPsHxfbsnTd2q855VP/63Zz2GAceQQwpdXfl9z+wlm AY5TM4VA2arTx9ZHwjzQjzaPWjoJVjwoynzihqGJC9YEsUhb0zykkwrfBxicdLUnyJmLNAKV+34 3aNP5QGqVhG+37i0sGMhQYkvCALTuC0QgbdJ0+gXLAwJ5xnnNY20MbeH9VyUa1EL5ODXE3PZJc0 MwVcNSYuywRvXk2CBwxtLZBKaFN9X2yFjLmbcN/OaV1LvTUpIyuvDlo5LhTIYQ/QdgQyJEkwtI8 x3pVmzzNbcA703pCvjssdx0phZAJj8C3PNfTsWeKjq+rC8VaMI8h7eKGMi6wKRK/GFy7fp9adnq Wb+PXCSPkW8Hhgn0TLMiLG2wbMoTJKtHZMjto1g5lqnzkdhrWkLuh52w5R3FtRFWVh8LlePhahW oq6oPsKvhXeBs+nLqHb/+HBPY2pFZm12fT7rmxjVCRS00AJPNiZAxRp8FXO4mq8znWHJdabx6cL 4a0x4TRGpX8 X-Received: by 2002:a05:6402:254b:b0:6aa:fac1:3bff with SMTP id 4fb4d7f45d1cf-6af9e357989mr2066365a12.32.1790951749730; Fri, 02 Oct 2026 07:35:49 -0700 (PDT) Received: from [192.168.0.167] ([109.76.210.127]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6af9d873682sm929326a12.10.2026.10.02.07.35.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Oct 2026 07:35:49 -0700 (PDT) Message-ID: <45d79c84-cc76-4bee-835d-ed11ce07bf2f@linaro.org> Date: Fri, 2 Oct 2026 15:35:48 +0100 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 06/15] media: qcom: camss: vfe: Add support for VFE 1190 To: Nihal Kumar Gupta , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue , Manivannan Sadhasivam , Hangxiang Ma , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Suresh Vankadara , Vikram Sharma References: <20260923-hawi-maili-camss-v1-0-cbbb42e534ef@oss.qualcomm.com> <20260923-hawi-maili-camss-v1-6-cbbb42e534ef@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-GB In-Reply-To: <20260923-hawi-maili-camss-v1-6-cbbb42e534ef@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23/09/2026 12:02, Nihal Kumar Gupta wrote: > drivers/media/platform/qcom/camss/camss-vfe-gen4.c So I'd like to completely drop the genX.c stuff it is not descriptive. For example: diff --git a/drivers/media/platform/qcom/camss/camss-vfe-gen3.c b/drivers/media/platform/qcom/camss/camss-vfe-gen3.c index 93d16b0951e99..f2001140ead12 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-gen3.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-gen3.c @@ -12,13 +12,43 @@ #include "camss.h" #include "camss-vfe.h" -#define BUS_REG_BASE (vfe_is_lite(vfe) ? 0x200 : 0xC00) +#define IS_VFE_690(vfe) \ + (vfe->camss->res->version == CAMSS_8775P) + +#define BUS_REG_BASE_690 \ + (vfe_is_lite(vfe) ? 0x480 : 0x400) +#define BUS_REG_BASE_780 \ + (vfe_is_lite(vfe) ? 0x200 : 0xC00) +#define BUS_REG_BASE \ + (IS_VFE_690(vfe) ? BUS_REG_BASE_690 : BUS_REG_BASE_780) + +#define VFE_TOP_CORE_CFG (0x24) +#define VFE_DISABLE_DSCALING_DS4 BIT(21) +#define VFE_DISABLE_DSCALING_DS16 BIT(22) + +#define VFE_BUS_WM_TEST_BUS_CTRL_690 (BUS_REG_BASE + 0xFC) +#define VFE_BUS_WM_TEST_BUS_CTRL_780 (BUS_REG_BASE + 0xDC) +#define VFE_BUS_WM_TEST_BUS_CTRL \ + (IS_VFE_690(vfe) ? VFE_BUS_WM_TEST_BUS_CTRL_690 \ + : VFE_BUS_WM_TEST_BUS_CTRL_780) +/* + * Bus client mapping: + * + * Full VFE: + * VFE_690: 16 = RDI0, 17 = RDI1, 18 = RDI2 + * VFE_780: 23 = RDI0, 24 = RDI1, 25 = RDI2 + * + * VFE LITE: + * VFE_690 : 0 = RDI0, 1 = RDI1, 2 = RDI2, 3 = RDI3, 4 = RDI4, 5 = RDI5 + * VFE_780 : 0 = RDI0, 1 = RDI1, 2 = RDI2, 3 = RDI3, 4 = RDI4 + */ +#define RDI_WM_690(n) ((vfe_is_lite(vfe) ? 0x0 : 0x10) + (n)) +#define RDI_WM_780(n) ((vfe_is_lite(vfe) ? 0x0 : 0x17) + (n)) +#define RDI_WM(n) (IS_VFE_690(vfe) ? RDI_WM_690(n) : RDI_WM_780(n)) In other words VFE 690 and VFE 780/880 don't share the same write-master index. So they aren't the same silicon. I'll go and find the Kaanapali thread but the feedback here will apply there. Name the files per their silicon version not some genX.c moniker, please. It _looks_ like 690 and 780 will need to be separated so, I'd like to move away from this misleading genX notation - it may mean things to qcom but I feel we are burying inappropriate hacks inside of convenient gen files. --- bod