From: Arnd Bergmann <arnd@arndb.de>
To: linux-media@vger.kernel.org
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [RFC] [media] omap3isp: try to fix dependencies
Date: Fri, 13 Jun 2014 14:02:01 +0200 [thread overview]
Message-ID: <46586956.hxqoJOmDbk@wuerfel> (raw)
commit 2a0a5472af5c ("omap3isp: Use the ARM DMA IOMMU-aware operations")
brought the omap3isp driver closer to using standard APIs, but also
introduced two problems:
a) it selects a particular IOMMU driver for no good reason. This just
causes hard to track dependency chains, in my case breaking an
experimental patch set that tries to reenable !MMU support on ARM
multiplatform kernels. Since the driver doesn't have a dependency
on the actual IOMMU implementation (other than sitting on the same
SoC), this changes the 'select OMAP_IOMMU' to a generic 'depends on
IOMMU_API' that reflects the actual usage.
b) The driver incorrectly calls into low-level helpers designed to
be used by the IOMMU implementation:
arm_iommu_{create,attach,release}_mapping. I'm not fixing this
here, but adding a FIXME and a dependency on ARM_DMA_USE_IOMMU.
I believe the correct solution is to move the calls into the
omap iommu driver that currently doesn't have them, and change
the isp driver to call generic functions.
In addition, this also adds the missing 'select VIDEOBUF2_DMA_CONTIG'
that is needed since fbac1400bd1 ("[media] omap3isp: Move to videobuf2")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
----
Hi Laurent,
Could you have a look at this? It's possible I'm missing something
important here, but this is what I currently need to get randconfig
builds to use the omap3isp driver.
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index 8108c69..15bf61b 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -94,8 +94,9 @@ config VIDEO_M32R_AR_M64278
config VIDEO_OMAP3
tristate "OMAP 3 Camera support"
depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && ARCH_OMAP3
- select ARM_DMA_USE_IOMMU
- select OMAP_IOMMU
+ depends on ARM_DMA_USE_IOMMU # FIXME: use iommu API instead of low-level ARM calls
+ depends on IOMMU_API
+ select VIDEOBUF2_DMA_CONTIG
---help---
Driver for an OMAP 3 camera controller.
next reply other threads:[~2014-06-13 12:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 12:02 Arnd Bergmann [this message]
2014-07-17 12:35 ` [PATCH] [RFC] [media] omap3isp: try to fix dependencies Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46586956.hxqoJOmDbk@wuerfel \
--to=arnd@arndb.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox