From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, mchehab@osg.samsung.com,
hverkuil@xs4all.nl, shuahkh@osg.samsung.com
Subject: Re: [RFC 3/4] media: Properly handle user pointers
Date: Mon, 22 Feb 2016 15:28:51 +0200 [thread overview]
Message-ID: <4745454.esNGAZoyuI@avalon> (raw)
In-Reply-To: <1456090575-28354-4-git-send-email-sakari.ailus@linux.intel.com>
Hi Sakari,
Thank you for the patch.
On Sunday 21 February 2016 23:36:14 Sakari Ailus wrote:
> Mark pointers containing user pointers as such.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/media-device.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
> index 5ebb3cd..f001c27 100644
> --- a/drivers/media/media-device.c
> +++ b/drivers/media/media-device.c
> @@ -245,10 +245,10 @@ static long __media_device_get_topology(struct
> media_device *mdev, struct media_interface *intf;
> struct media_pad *pad;
> struct media_link *link;
> - struct media_v2_entity kentity, *uentity;
> - struct media_v2_interface kintf, *uintf;
> - struct media_v2_pad kpad, *upad;
> - struct media_v2_link klink, *ulink;
> + struct media_v2_entity kentity, __user *uentity;
> + struct media_v2_interface kintf, __user *uintf;
> + struct media_v2_pad kpad, __user *upad;
> + struct media_v2_link klink, __user *ulink;
> unsigned int i;
> int ret = 0;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-02-22 13:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 21:36 [RFC 0/4] MC v2 cleanups Sakari Ailus
2016-02-21 21:36 ` [RFC 1/4] media: Sanitise the reserved fields of the G_TOPOLOGY IOCTL arguments Sakari Ailus
2016-02-22 9:58 ` Mauro Carvalho Chehab
2016-02-22 10:00 ` Mauro Carvalho Chehab
2016-02-22 10:23 ` Mauro Carvalho Chehab
2016-02-22 19:52 ` Sakari Ailus
2016-02-21 21:36 ` [RFC 2/4] media: Rearrange the fields in the G_TOPOLOGY IOCTL argument Sakari Ailus
2016-02-22 9:54 ` Mauro Carvalho Chehab
2016-02-21 21:36 ` [RFC 3/4] media: Properly handle user pointers Sakari Ailus
2016-02-22 13:28 ` Laurent Pinchart [this message]
2016-02-21 21:36 ` [RFC 4/4] media: Drop media_get_uptr() macro Sakari Ailus
2016-02-22 9:52 ` Mauro Carvalho Chehab
2016-02-22 10:06 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4745454.esNGAZoyuI@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=sakari.ailus@linux.intel.com \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox