From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Dan Scally" <djrscally@gmail.com>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Hao Yao" <hao.yao@intel.com>,
"Bingbu Cao" <bingbu.cao@intel.com>, Duane <duanek@chorus.net>,
platform-driver-x86@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v2 6/9] platform/x86: int3472: Avoid GPIO regulator spikes
Date: Thu, 3 Apr 2025 11:43:34 +0200 [thread overview]
Message-ID: <474fe098-3cf0-4207-92a1-e033799a04af@redhat.com> (raw)
In-Reply-To: <CAHp75Vcok+-NPEGKFbZawiJcjhgJK5upbyfXfCEtezYiMspvRw@mail.gmail.com>
Hi,
On 2-Apr-25 11:04 PM, Andy Shevchenko wrote:
> On Wed, Apr 2, 2025 at 11:25 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Avoid the GPIO controlling the avdd regulator being driven low or high
>> for a very short time leading to spikes by adding an enable delay of 2 ms
>> and a minimum off to on delay of also 2 ms.
>
> How 2ms was derived? From experiments or is there any other hint
> (Intel published sources somewhere, etc)?
2 ms is the minimum time ovXXXX sensors need to have there
reset line driven logical high to properly register the reset.
So that seemed like a sane value to use here to me.
> The code looks good to me
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
Regards,
Hans
next prev parent reply other threads:[~2025-04-03 9:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 20:25 [PATCH v2 0/9] platform/x86: int3472: Add handshake pin support Hans de Goede
2025-04-02 20:25 ` [PATCH v2 1/9] platform/x86: int3472: Add skl_int3472_register_clock() helper Hans de Goede
2025-04-02 20:25 ` [PATCH v2 2/9] platform/x86: int3472: Stop setting a supply-name for GPIO regulators Hans de Goede
2025-04-02 20:25 ` [PATCH v2 3/9] platform/x86: int3472: Drop unused gpio field from struct int3472_gpio_regulator Hans de Goede
2025-04-02 20:25 ` [PATCH v2 4/9] platform/x86: int3472: Rework AVDD second sensor quirk handling Hans de Goede
2025-04-02 21:10 ` Andy Shevchenko
2025-04-02 20:25 ` [PATCH v2 5/9] platform/x86: int3472: Make regulator supply name configurable Hans de Goede
2025-04-02 21:08 ` Andy Shevchenko
2025-04-02 20:25 ` [PATCH v2 6/9] platform/x86: int3472: Avoid GPIO regulator spikes Hans de Goede
2025-04-02 21:04 ` Andy Shevchenko
2025-04-03 9:43 ` Hans de Goede [this message]
2025-04-03 14:05 ` Andy Shevchenko
2025-04-02 20:25 ` [PATCH v2 7/9] platform/x86: int3472: Prepare for registering more then 1 GPIO regulator Hans de Goede
2025-04-02 20:59 ` Andy Shevchenko
2025-04-02 20:25 ` [PATCH v2 8/9] platform/x86: int3472: Add handshake pin support Hans de Goede
2025-04-02 20:56 ` Andy Shevchenko
2025-04-16 11:06 ` Hans de Goede
2025-04-16 13:09 ` Andy Shevchenko
2025-04-16 13:09 ` Andy Shevchenko
2025-04-16 13:13 ` Hans de Goede
2025-04-02 20:25 ` [PATCH v2 9/9] platform/x86: int3472: Debug log when remapping pins Hans de Goede
2025-04-02 20:51 ` Andy Shevchenko
2025-04-02 21:02 ` [PATCH v2 0/9] platform/x86: int3472: Add handshake pin support Andy Shevchenko
2025-04-03 10:30 ` Hans de Goede
2025-04-03 14:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474fe098-3cf0-4207-92a1-e033799a04af@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=bingbu.cao@intel.com \
--cc=djrscally@gmail.com \
--cc=duanek@chorus.net \
--cc=hao.yao@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox