Re: [PATCH 1/4] media: dt-bindings: cedrus: Allow power domain references

Jernej Škrabec
2023-01-05T16:18:09Z

Dne sobota, 31. december 2022 ob 17:46:24 CET je Samuel Holland napisal(a):
> The Allwinner D1 SoC contains a separate power domain for its video
> engine, controlled via the "PPU" power controller. Allow the
> power-domains property so this can be represented in the devicetree.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> .../bindings/media/allwinner,sun4i-a10-video-engine.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.
> yaml
> b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.
> yaml index 541325f900a1..d5be7f604e8c 100644
> ---
> a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.
> yaml +++
> b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.
> yaml @@ -63,6 +63,9 @@ properties:
> CMA pool to use for buffers allocation instead of the default
> CMA pool.
>
> + power-domains:
> + maxItems: 1

Please add check if it's needed based on compatible. This yaml is one of the
few for sunxi platform which doesn't have strict checks. Same goes for sram
property.

Best regards,
Jernej

> +
> required:
> - compatible
> - reg