Re: [PATCH 3/4] media: cedrus: Make SRAM section claiming optional

Jernej Škrabec
2023-01-05T16:20:22Z

Dne sobota, 31. december 2022 ob 17:46:26 CET je Samuel Holland napisal(a):
> The video engine in the D1 family of SoCs does not have a switchable
> SRAM section. Allow the driver to probe even when the SRAM section
> reference is missing.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c index
> fa86a658fdc6..11e859617932 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> @@ -257,7 +257,7 @@ int cedrus_hw_probe(struct cedrus_dev *dev)
> }
>
> ret = sunxi_sram_claim(dev->dev);
> - if (ret) {
> + if (ret && ret != -ENOENT) {

What about more strict check based on quirks flag?

Best regards,
Jernej

> dev_err(dev->dev, "Failed to claim SRAM\n");
>
> goto err_mem;