From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC952C433EF for ; Thu, 7 Jul 2022 10:45:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233804AbiGGKpH (ORCPT ); Thu, 7 Jul 2022 06:45:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231710AbiGGKpG (ORCPT ); Thu, 7 Jul 2022 06:45:06 -0400 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C7BA4D16F for ; Thu, 7 Jul 2022 03:45:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1657190704; x=1688726704; h=subject:from:to:cc:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8i0KiZnnTEvukfs71VLtM78jYB05xcW36D8RuTcv8ls=; b=E9XWVrJxP9uGumEmhXi2Br8VWmrsAGggqODJh2RukNsJ9ULlvl2/2zno 6ReDtssjTyngsbHnBmymfgppKbUICSEK0mh3ikJlAs9ABvN0SAyfXrUUv O38qfvXR/Ra8XXptBwhlTrc+8/YJuXst7zQH9HpcspE17053Hima5+CQM BjmD6YgULnEAUrBjCiY207tZKtVARz/olcDQxq32acHo64oHm+mEo7yT2 FL8ATj1hjuw12J8Xq3r8eZlHV/qWqHDelxpiey94gFXSty5TZ/uhi7R2P 2cw3WSXnUi72KZxT6d7pPsGCe22so3QZS7iyviB8lTh3RYaTESUcpElxC Q==; X-IronPort-AV: E=Sophos;i="5.92,252,1650924000"; d="scan'208";a="24914421" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 07 Jul 2022 12:45:02 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Thu, 07 Jul 2022 12:45:02 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Thu, 07 Jul 2022 12:45:02 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1657190702; x=1688726702; h=from:to:cc:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding:subject; bh=8i0KiZnnTEvukfs71VLtM78jYB05xcW36D8RuTcv8ls=; b=ERKEFLveO1z755vRJ/qSDARKhb+TtkG8o76BQhk/epxgGxni908l23u9 PPZ9ImfsEq3aP52184R4mRO2O2gPWOryCKDw1RcF7FEsyrIfsgOahInbV XDA/3CDp/i0jNnv0oCDeJ76nM6234PcHNzfdurFi6soLX0MDxsnRiBPk3 HCMvGwIvhhCXJX5qQpJAHCrjnzKip6pEP2jQZJRX8FwmNMYv79KWfdLP4 5Frd6E831meYZYjC/smVbshs6oaXcWmeH3oZCcjQzhPBy7Wts7P09sUQh 29u0rA3Yl+LZtJJ4amAYjDwE5tCEBeu9v9pApBeg5uodEu8/jHE8dA3SW w==; X-IronPort-AV: E=Sophos;i="5.92,252,1650924000"; d="scan'208";a="24914419" Subject: Re: Re: [PATCH 00/50] staging: media: imx: Prepare destaging of imx7-media-csi Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 07 Jul 2022 12:45:02 +0200 Received: from steina-w.localnet (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 81108280075; Thu, 7 Jul 2022 12:45:01 +0200 (CEST) From: Alexander Stein To: Laurent Pinchart Cc: linux-media@vger.kernel.org, Rui Miguel Silva , Steve Longerbeam , Philipp Zabel , Jacopo Mondi , Martin Kepplinger , Dorota Czaplejewicz , kernel@pengutronix.de Date: Thu, 07 Jul 2022 12:45:01 +0200 Message-ID: <4780760.ElGaqSPkdT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20220510115859.19777-1-laurent.pinchart@ideasonboard.com> <8064452.T7Z3S40VBb@steina-w> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hello Laurent, Am Donnerstag, 7. Juli 2022, 02:23:55 CEST schrieb Laurent Pinchart: > Hi Alexander, > > On Wed, May 11, 2022 at 03:36:14PM +0200, Alexander Stein wrote: > > Hello Laurent, > > > > thanks for pushing out this huge set. > > > > Am Dienstag, 10. Mai 2022, 13:58:09 CEST schrieb Laurent Pinchart: > > > Hello, > > > > > > This patch series prepares the imx7-media-csi for destaging by > > > decoupling it from the helpers shared with the i.MX6 IPUv3. > > > > > > The strategy Paul and I have followed is to import copies of helper code > > > and, refactor it within the imx7-media-csi driver, and repeat until no > > > more shared helpers are used. There is still room for refactoring and > > > simplification of the imx7-media-csi driver, but I believe it is now in > > > a state clean enough to be moved out of staging. > > > > > > The series also includes a few fixes or improvements in supported > > > formats that are now made possible thanks to this refactoring. See > > > patches 45/50 and 46/50 for details. > > > > > > The code size has grown as a result. This is partly offset by code in > > > the shared helpers that can be removed or simplified, but I haven't > > > starting working on that. The helpers are now used for the i.MX6 IPUv3 > > > only, so I will leave this exercise to anyone who would be interested in > > > destaging that driver as well. > > > > > > Some of the items in the TODO file related to the imx7-media-csi driver > > > have been addressed. The two remaining items are frame interval monitor > > > support and restricting the list of supported formats to the SoC > > > version. The former isn't a destaging blocker in my opinion, as the > > > feature can be added later if desired (and frame interval monitoring > > > should then be moved to the V4L2 core). I believe the latter could also > > > be addressed after destaging the driver, but in any case, this is a > > > discussion for a future destaging series (which may come as soon as this > > > one is accepted). > > > > > > Alexander, this also could greatly simplify your "[PATCH v3 0/8] > > > imx7/imx8mm media / csi patches" series. > > > > Thanks for putting me on CC. I'll try to get my system running your > > patches > > ASAP. > > As only minor changes were needed, I ended up posting v1.1 of the > corresponding patches instead of spamming everybody with a full v2. For > your convenience, I've pushed the result to > > git://linuxtv.org/pinchartl/media.git imx7/destage > > I know it's a bit of a short notice, but I'd like to send a pull request > in time for v5.20, when do you think you would be able to test the > series ? I happen to have my setup already available, so I could test your updated series pretty fast. Accessing imx327 still works for WIP config. So Tested-by: Alexander Stein Best regards, Alexander