From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:42455 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751933AbaBGAti (ORCPT ); Thu, 6 Feb 2014 19:49:38 -0500 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, Hans Verkuil , Lars-Peter Clausen Subject: Re: [PATCH 06/47] v4l: Add pad-level DV timings subdev operations Date: Fri, 07 Feb 2014 01:50:36 +0100 Message-ID: <4784461.L01N9ONqSC@avalon> In-Reply-To: <20140206173323.GJ15635@valkosipuli.retiisi.org.uk> References: <1391618558-5580-1-git-send-email-laurent.pinchart@ideasonboard.com> <1391618558-5580-7-git-send-email-laurent.pinchart@ideasonboard.com> <20140206173323.GJ15635@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sakari, Thank you for the review. On Thursday 06 February 2014 19:33:23 Sakari Ailus wrote: > Hi Laurent, > > On Wed, Feb 05, 2014 at 05:41:57PM +0100, Laurent Pinchart wrote: > > Signed-off-by: Laurent Pinchart > > --- > > > > include/media/v4l2-subdev.h | 4 ++++ > > include/uapi/linux/videodev2.h | 8 ++++++-- > > 2 files changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h > > index d67210a..2c7355a 100644 > > --- a/include/media/v4l2-subdev.h > > +++ b/include/media/v4l2-subdev.h > > @@ -505,6 +505,10 @@ struct v4l2_subdev_pad_ops { > > > > struct v4l2_subdev_selection *sel); > > > > int (*get_edid)(struct v4l2_subdev *sd, struct v4l2_subdev_edid *edid); > > int (*set_edid)(struct v4l2_subdev *sd, struct v4l2_subdev_edid *edid); > > > > + int (*dv_timings_cap)(struct v4l2_subdev *sd, > > + struct v4l2_dv_timings_cap *cap); > > + int (*enum_dv_timings)(struct v4l2_subdev *sd, > > + struct v4l2_enum_dv_timings *timings); > > Do you think there would be use for these in the user space API? The > argument structs are defined in the user space header. The driver does also > export a sub-device node. Please have a look at [PATCH 27/47] v4l: Add support for DV timings ioctls on subdev nodes :-) -- Regards, Laurent Pinchart