From: Michael Krufky <mkrufky@linuxtv.org>
To: Tony Breeds <tony@bakeyournoodle.com>
Cc: video4linux-list@redhat.com,
"Toralf Förster" <toralf.foerster@gmx.de>,
linux-kernel@vger.kernel.org,
"Mauro Carvalho Chehab" <mchehab@infradead.org>,
"Steven Toth" <stoth@hauppauge.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: build #345 issue for v2.6.25-rc1 in tuner-core.c
Date: Mon, 11 Feb 2008 21:34:32 -0500 [thread overview]
Message-ID: <47B105B8.7010900@linuxtv.org> (raw)
In-Reply-To: <20080212004251.GT6887@bakeyournoodle.com>
Tony Breeds wrote:
> On Mon, Feb 11, 2008 at 11:54:31AM +0100, Toralf Förster wrote:
>
>> Hello,
>>
>> the build with the attached .config failed, make ending with:
>> ...
>> MODPOST vmlinux.o
>> WARNING: modpost: Found 12 section mismatch(es).
>> To see full details build your kernel with:
>> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
>> GEN .version
>> CHK include/linux/compile.h
>> UPD include/linux/compile.h
>> CC init/version.o
>> LD init/built-in.o
>> LD .tmp_vmlinux1
>> drivers/built-in.o: In function `set_type':
>> tuner-core.c:(.text+0x8879d): undefined reference to `xc5000_attach'
>> make: *** [.tmp_vmlinux1] Error 1
>>
>
> <snip>
> Fix Build error for xc5000 tuner when built as module.
>
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
>
Patch is correct. Not sure which tag is appropriate.....
Reviewed-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
This should go straight to Linus..... Andrew or Mauro, can one of you
take care of it?
Regards,
Mike
> ---
> Not 100% certain this is correct but it works for me :) Michael?
>
> drivers/media/dvb/frontends/xc5000.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/dvb/frontends/xc5000.h b/drivers/media/dvb/frontends/xc5000.h
> index e0e8456..32a5f1c 100644
> --- a/drivers/media/dvb/frontends/xc5000.h
> +++ b/drivers/media/dvb/frontends/xc5000.h
> @@ -45,7 +45,8 @@ struct xc5000_config {
> /* xc5000 callback command */
> #define XC5000_TUNER_RESET 0
>
> -#if defined(CONFIG_DVB_TUNER_XC5000) || defined(CONFIG_DVB_TUNER_XC5000_MODULE)
> +#if defined(CONFIG_DVB_TUNER_XC5000) || \
> + (defined(CONFIG_DVB_TUNER_XC5000_MODULE) && defined(MODULE))
> extern struct dvb_frontend* xc5000_attach(struct dvb_frontend *fe,
> struct i2c_adapter *i2c,
> struct xc5000_config *cfg);
>
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
next parent reply other threads:[~2008-02-12 2:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200802111154.31760.toralf.foerster@gmx.de>
[not found] ` <20080212004251.GT6887@bakeyournoodle.com>
2008-02-12 2:34 ` Michael Krufky [this message]
2008-02-12 14:59 ` build #345 issue for v2.6.25-rc1 in tuner-core.c Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B105B8.7010900@linuxtv.org \
--to=mkrufky@linuxtv.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=stoth@hauppauge.com \
--cc=tony@bakeyournoodle.com \
--cc=toralf.foerster@gmx.de \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox