Re: build #345 issue for v2.6.25-rc1 in tuner-core.c

Re: build #345 issue for v2.6.25-rc1 in tuner-core.c

[Michael Krufky]

Tony Breeds wrote:
> On Mon, Feb 11, 2008 at 11:54:31AM +0100, Toralf Förster wrote:
>   
>> Hello,
>>
>> the build with the attached .config failed, make ending with:
>> ...
>>   MODPOST vmlinux.o
>> WARNING: modpost: Found 12 section mismatch(es).
>> To see full details build your kernel with:
>> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
>>   GEN     .version
>>   CHK     include/linux/compile.h
>>   UPD     include/linux/compile.h
>>   CC      init/version.o
>>   LD      init/built-in.o
>>   LD      .tmp_vmlinux1
>> drivers/built-in.o: In function `set_type':
>> tuner-core.c:(.text+0x8879d): undefined reference to `xc5000_attach'
>> make: *** [.tmp_vmlinux1] Error 1
>>     
>
> <snip>
> Fix Build error for xc5000 tuner when built as module.
>
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
>   
Patch is correct.  Not sure which tag is appropriate.....

Reviewed-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>

This should go straight to Linus.....  Andrew or Mauro, can one of you
take care of it?

Regards,

Mike
> ---
> Not 100% certain this is correct but it works for me :) Michael?
>
>  drivers/media/dvb/frontends/xc5000.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/dvb/frontends/xc5000.h b/drivers/media/dvb/frontends/xc5000.h
> index e0e8456..32a5f1c 100644
> --- a/drivers/media/dvb/frontends/xc5000.h
> +++ b/drivers/media/dvb/frontends/xc5000.h
> @@ -45,7 +45,8 @@ struct xc5000_config {
>  /* xc5000 callback command */
>  #define XC5000_TUNER_RESET		0
>  
> -#if defined(CONFIG_DVB_TUNER_XC5000) || defined(CONFIG_DVB_TUNER_XC5000_MODULE)
> +#if defined(CONFIG_DVB_TUNER_XC5000) || \
> +    (defined(CONFIG_DVB_TUNER_XC5000_MODULE) && defined(MODULE))
>  extern struct dvb_frontend* xc5000_attach(struct dvb_frontend *fe,
>  					  struct i2c_adapter *i2c,
>  					  struct xc5000_config *cfg);
>   

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: build #345 issue for v2.6.25-rc1 in tuner-core.c

[Mauro Carvalho Chehab]

On Mon, 11 Feb 2008 21:34:32 -0500
Michael Krufky <mkrufky@linuxtv.org> wrote:

> Tony Breeds wrote:
> > On Mon, Feb 11, 2008 at 11:54:31AM +0100, Toralf Förster wrote:
> >   
> >> Hello,
> >>
> >> the build with the attached .config failed, make ending with:
> >> ...
> >>   MODPOST vmlinux.o
> >> WARNING: modpost: Found 12 section mismatch(es).
> >> To see full details build your kernel with:
> >> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> >>   GEN     .version
> >>   CHK     include/linux/compile.h
> >>   UPD     include/linux/compile.h
> >>   CC      init/version.o
> >>   LD      init/built-in.o
> >>   LD      .tmp_vmlinux1
> >> drivers/built-in.o: In function `set_type':
> >> tuner-core.c:(.text+0x8879d): undefined reference to `xc5000_attach'
> >> make: *** [.tmp_vmlinux1] Error 1
> >>     
> >
> > <snip>
> > Fix Build error for xc5000 tuner when built as module.
> >
> > Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
> >   
> Patch is correct.  Not sure which tag is appropriate.....
> 
> Reviewed-by: Michael Krufky <mkrufky@linuxtv.org>
> Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
> 
> This should go straight to Linus.....  Andrew or Mauro, can one of you
> take care of it?

I should forward today some patches to Linus. I'll add this one to the list.


Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list