Re: [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: When xc3028/xc2028 will be supported?

Re: [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: When xc3028/xc2028 will be supported?

[Daniel Gimpelevich]

On Tue, 29 Jan 2008 12:25:47 -0200, Mauro Carvalho Chehab wrote:

> Dâniel and others,
> 
>> > Having this tested is a very good news! I'll need to merge this patch with two
>> > other patches that adds DVB support for cx88/xc3028. If I can manage to have
>> > some time for this merge, I'll commit and ask Linus to add this to 2.6.25.
>> 
>> 	:)
> 
> I've merged some patches from several authors, that add xc3028 support for
> cx88.
> 
> The experimental tree is available at:
> 
> http://linuxtv.org/hg/~mchehab/cx88-xc2028
> 
> This patch series adds support for the following boards:
> 
>  59 -> DVICO HDTV5 PCI Nano                                [18ac:d530]
>  60 -> Pinnacle Hybrid PCTV                                [12ab:1788]
>  61 -> Winfast TV2000 XP Global                            [107d:6f18]
>  62 -> PowerColor Real Angel 330                           [14f1:ea3d]
>  63 -> Geniatech X8000-MT DVBT                             [14f1:8852]
>  64 -> DViCO FusionHDTV DVB-T PRO                          [18ac:db30]
> 
> In thesis, both analog and DVB support (for boards with DVB/ATSC) should be
> working (*). Maybe analog audio may need an additional configuration for some
> specific board (since they may require to add cfg.mts = 1 at xc3028
> initialization code, on cx88-cards).
> 
> Please test.
> 
> (*) Pinnacle Hybrid PCTV support for DVB is not available yet. 
> 
> Cheers,
> Mauro

About ten weeks ago, the only support for the Powercolor Real Angel 330
appeared to be in Markus's mercurial tree, so I tried it. It did not work,
because the GPIO settings were all wrong. I ran some tests, and fixed the
problems. I made Markus aware of my patch several times, and he always
said he would soon add it to his tree along with many others he received.
He apparently never got to it, and now his server seems to have
disappeared from the web. If anyone still has a copy of his repository,
the following patch against it makes all functions of this card work
perfectly:
http://pastebin.com/f44a13031
Today, I noticed the new cx88-xc2028 tree on which Mauro has begun some
work. I have not tried it, but in comparing the code to Markus's, most
support appears to be missing. I thought that maybe I could try merging
Markus's old tree with Mauro's new one, but the absence of Markus's server
means I can't. If anyone here would like my assistance in reconciling the
competing code in the two trees, please contact me off-list. Thank you.

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: When xc3028/xc2028 will be supported?

[Markus Rechberger]

On 2/16/08, Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us> wrote:
> On Tue, 29 Jan 2008 12:25:47 -0200, Mauro Carvalho Chehab wrote:
>
> > Dâniel and others,
> >
> >> > Having this tested is a very good news! I'll need to merge this patch
> with two
> >> > other patches that adds DVB support for cx88/xc3028. If I can manage to
> have
> >> > some time for this merge, I'll commit and ask Linus to add this to
> 2.6.25.
> >>
> >> 	:)
> >
> > I've merged some patches from several authors, that add xc3028 support for
> > cx88.
> >
> > The experimental tree is available at:
> >
> > http://linuxtv.org/hg/~mchehab/cx88-xc2028
> >
> > This patch series adds support for the following boards:
> >
> >  59 -> DVICO HDTV5 PCI Nano                                [18ac:d530]
> >  60 -> Pinnacle Hybrid PCTV                                [12ab:1788]
> >  61 -> Winfast TV2000 XP Global                            [107d:6f18]
> >  62 -> PowerColor Real Angel 330                           [14f1:ea3d]
> >  63 -> Geniatech X8000-MT DVBT                             [14f1:8852]
> >  64 -> DViCO FusionHDTV DVB-T PRO                          [18ac:db30]
> >
> > In thesis, both analog and DVB support (for boards with DVB/ATSC) should
> be
> > working (*). Maybe analog audio may need an additional configuration for
> some
> > specific board (since they may require to add cfg.mts = 1 at xc3028
> > initialization code, on cx88-cards).
> >
> > Please test.
> >
> > (*) Pinnacle Hybrid PCTV support for DVB is not available yet.
> >
> > Cheers,
> > Mauro
>
> About ten weeks ago, the only support for the Powercolor Real Angel 330
> appeared to be in Markus's mercurial tree, so I tried it. It did not work,
> because the GPIO settings were all wrong. I ran some tests, and fixed the
> problems. I made Markus aware of my patch several times, and he always
> said he would soon add it to his tree along with many others he received.
> He apparently never got to it, and now his server seems to have
> disappeared from the web. If anyone still has a copy of his repository,
> the following patch against it makes all functions of this card work
> perfectly:
> http://pastebin.com/f44a13031
> Today, I noticed the new cx88-xc2028 tree on which Mauro has begun some
> work. I have not tried it, but in comparing the code to Markus's, most
> support appears to be missing. I thought that maybe I could try merging
> Markus's old tree with Mauro's new one, but the absence of Markus's server
> means I can't. If anyone here would like my assistance in reconciling the
> competing code in the two trees, please contact me off-list. Thank you.
>

the server should be back on monday.. there's some maintainance going
on by the other admin.. I have to wait for it too..

Markus

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: When xc3028/xc2028 will be supported?

[Michael Krufky]

On Jan 29, 2008 9:25 AM, Mauro Carvalho Chehab <mchehab@infradead.org> wrote:
> Dâniel and others,
>
> > > Having this tested is a very good news! I'll need to merge this patch with two
> > > other patches that adds DVB support for cx88/xc3028. If I can manage to have
> > > some time for this merge, I'll commit and ask Linus to add this to 2.6.25.
> >
> >       :)
>
> I've merged some patches from several authors, that add xc3028 support for
> cx88.
>
> The experimental tree is available at:
>
> http://linuxtv.org/hg/~mchehab/cx88-xc2028
>
> This patch series adds support for the following boards:
>
>  59 -> DVICO HDTV5 PCI Nano                                [18ac:d530]
>  60 -> Pinnacle Hybrid PCTV                                [12ab:1788]
>  61 -> Winfast TV2000 XP Global                            [107d:6f18]
>  62 -> PowerColor Real Angel 330                           [14f1:ea3d]
>  63 -> Geniatech X8000-MT DVBT                             [14f1:8852]
>  64 -> DViCO FusionHDTV DVB-T PRO                          [18ac:db30]
>
> In thesis, both analog and DVB support (for boards with DVB/ATSC) should be
> working (*). Maybe analog audio may need an additional configuration for some
> specific board (since they may require to add cfg.mts = 1 at xc3028
> initialization code, on cx88-cards).
>
> Please test.

Mauro,

We spoke on Thursday, and you asked me to take a look at the code in
your 'cx88-xc2028' tree over the weekend and fix it, if possible.

The repository is broken after and including changeset ce6afd207b71 -
"Make xc3028 support more generic"  This changeset moves the
device-specific configuration out of the cx88-dvb.c device-specific
switch..case block, into a generic function.  This patch breaks
functionality, and imho, is not a good idea.

Your changes assume that the analog side of the driver will come up
before the digital side of the driver, which is not necessarily the
case.  Additionally, in some cases, the tuner itself is hidden behind
an i2c gate that is controlled by the dvb / atsc demodulator.  Because
of the i2c gate, communication to the tuner might not be available at
the time that the i2c bus is probed.  For those reasons, the attach
calls to the tuner driver should be fully qualified, relative to the
functionality of the side of the driver that is attaching it.

The device that I used to test is the FusionHDTV 5 PCI nano.  This
device uses an xc3008 (yes, that is xc3008 -- not a typo) and a
s5h1409 demod.  The device is capable of receiving ATSC digital
broadcasts and the driver does not yet support analog television.

Steve Toth made the patch that adds atsc support for that card, and
his patch worked without the additional changesets that were added
afterwards.  I made some small fixes and enabled IR support -- see the
bottom of this email for my pull request.

Your email above states that you've "merged some patches from several
authors".  What I recommend, in order to properly support each device,
would be to apply each patch for each card separately, as we do with
all card support additions.  We know that the original patches, as
submitted by the original authors work properly , since those authors
have conducted their own tests.

I understand that you've made some attempts to optimize the code in an
effort to reduce memory consumption.  Unfortunately, these efforts
have broken functionality of these devices.  I think that it would
make more sense to work on optimizations after the basic device
support patches are first applied in the standard manner.  This way,
you would have a good point of reference for "before" and "after" that
testers will be able to use for comparison (and bisection).

Since the only card that I can test is the PCI nano, please pull these
changesets into master for now.

Please pull from:

http://linuxtv.org/hg/~mkrufky/cx88-xc2028

for:

(91113b8955e2) 4 weeks ago	Steven Toth 	cx88: Add support for the
Dvico PCI Nano.
(394d249f03f1) 47 hours ago	Michael Krufky 	cx88: fix FusionHDTV 5 PCI
nano name and enable IR support

Regards,

Mike

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: When xc3028/xc2028 will be supported?

[Mauro Carvalho Chehab]

On Mon, 18 Feb 2008 23:44:33 -0500
"Michael Krufky" <mkrufky@linuxtv.org> wrote:

> On Jan 29, 2008 9:25 AM, Mauro Carvalho Chehab <mchehab@infradead.org> wrote:
> > Dâniel and others,
> >
> > > > Having this tested is a very good news! I'll need to merge this patch with two
> > > > other patches that adds DVB support for cx88/xc3028. If I can manage to have
> > > > some time for this merge, I'll commit and ask Linus to add this to 2.6.25.
> > >
> > >       :)
> >
> > I've merged some patches from several authors, that add xc3028 support for
> > cx88.
> >
> > The experimental tree is available at:
> >
> > http://linuxtv.org/hg/~mchehab/cx88-xc2028
> >
> > This patch series adds support for the following boards:
> >
> >  59 -> DVICO HDTV5 PCI Nano                                [18ac:d530]
> >  60 -> Pinnacle Hybrid PCTV                                [12ab:1788]
> >  61 -> Winfast TV2000 XP Global                            [107d:6f18]
> >  62 -> PowerColor Real Angel 330                           [14f1:ea3d]
> >  63 -> Geniatech X8000-MT DVBT                             [14f1:8852]
> >  64 -> DViCO FusionHDTV DVB-T PRO                          [18ac:db30]
> >
> > In thesis, both analog and DVB support (for boards with DVB/ATSC) should be
> > working (*). Maybe analog audio may need an additional configuration for some
> > specific board (since they may require to add cfg.mts = 1 at xc3028
> > initialization code, on cx88-cards).
> >
> > Please test.
> 
> Mauro,
> 
> We spoke on Thursday, and you asked me to take a look at the code in
> your 'cx88-xc2028' tree over the weekend and fix it, if possible.
> 
> The repository is broken after and including changeset ce6afd207b71 -
> "Make xc3028 support more generic"  This changeset moves the
> device-specific configuration out of the cx88-dvb.c device-specific
> switch..case block, into a generic function.  This patch breaks
> functionality, and imho, is not a good idea.
> 
> Your changes assume that the analog side of the driver will come up
> before the digital side of the driver, which is not necessarily the
> case.  Additionally, in some cases, the tuner itself is hidden behind
> an i2c gate that is controlled by the dvb / atsc demodulator.  Because
> of the i2c gate, communication to the tuner might not be available at
> the time that the i2c bus is probed.  For those reasons, the attach
> calls to the tuner driver should be fully qualified, relative to the
> functionality of the side of the driver that is attaching it.
> 
> The device that I used to test is the FusionHDTV 5 PCI nano.  This
> device uses an xc3008 (yes, that is xc3008 -- not a typo) and a
> s5h1409 demod.  The device is capable of receiving ATSC digital
> broadcasts and the driver does not yet support analog television.
> 
> Steve Toth made the patch that adds atsc support for that card, and
> his patch worked without the additional changesets that were added
> afterwards.  I made some small fixes and enabled IR support -- see the
> bottom of this email for my pull request.
> 
> Your email above states that you've "merged some patches from several
> authors".  What I recommend, in order to properly support each device,
> would be to apply each patch for each card separately, as we do with
> all card support additions.  We know that the original patches, as
> submitted by the original authors work properly , since those authors
> have conducted their own tests.
> 
> I understand that you've made some attempts to optimize the code in an
> effort to reduce memory consumption.  Unfortunately, these efforts
> have broken functionality of these devices.  I think that it would
> make more sense to work on optimizations after the basic device
> support patches are first applied in the standard manner.  This way,
> you would have a good point of reference for "before" and "after" that
> testers will be able to use for comparison (and bisection).
> 
> Since the only card that I can test is the PCI nano, please pull these
> changesets into master for now.
> 
> Please pull from:
> 
> http://linuxtv.org/hg/~mkrufky/cx88-xc2028
> 
> for:
> 
> (91113b8955e2) 4 weeks ago	Steven Toth 	cx88: Add support for the
> Dvico PCI Nano.
> (394d249f03f1) 47 hours ago	Michael Krufky 	cx88: fix FusionHDTV 5 PCI
> nano name and enable IR support

Michael,

It is not that simple. Steven patch works for DTV on PCI Nano; Christopher
patches for some other DiVCO boards (DTV also); my port of Markus patch for
other boards (tested by Dâniel Fraga - Analog TV).

The point is not saving memory. The point is that tuner-xc2028 requires just
one callback. The callback should work properly for DTV, Analog and Radio. It
makes no sense to have such generic callback inside cx88-dvb. It should be at
cx88xx module, instead.

We need one solution that works for all boards, not just yours.

That's said, maybe SET_TUNER_CONFIG is being called too early. Maybe the way to
fix this is to create an special function to initialize it, that would be
called later by cx8800 or cx8802.

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: When xc3028/xc2028 will be supported?

[Mauro Carvalho Chehab]

On Tue, 19 Feb 2008 06:51:09 -0300
Mauro Carvalho Chehab <mchehab@infradead.org> wrote:

> > The repository is broken after and including changeset ce6afd207b71 -
> That's said, maybe SET_TUNER_CONFIG is being called too early. Maybe the way to
> fix this is to create an special function to initialize it, that would be
> called later by cx8800 or cx8802.

After analysing the code, I noticed that "tuner" module is requested too late,
o both cx88 and saa7134 drivers. This explains why there are some instabilities
on those drivers with certain tuners.

I've did some changesets fixing both drivers at:
	http://linuxtv.org/hg/~mchehab/cx88-xc2028/

I expect that we should have better results after those changes. I also added
some newer printk's to cx88 driver. This way, we'll have a cleaner idea if an
error is still occurring.

Guys, please test.

Daniel Gimpelevich,

Could you please rebase your changesets fixing the gpio's for PowerColor Real
Angel 330 and send them to me?

Dâniel Fraga,

Please test if the gpio's from Daniel Gimpelvinch works for you, against the
newer tree. I suspect it will work. However, is it not uncommon to have two
cards with the same brand name, but needing different gpio settings.

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: When xc3028/xc2028 will be supported?

[Daniel Gimpelevich]

On Tue, 19 Feb 2008 13:38:45 -0300, Mauro Carvalho Chehab wrote:

> Could you please rebase your changesets fixing the gpio's for PowerColor Real
> Angel 330 and send them to me?

I intend to do exactly that sometime within the next couple of weeks.

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: When xc3028/xc2028 will be supported?

[Mauro Carvalho Chehab]

Hi Daniel,

On Tue, 19 Feb 2008 09:24:32 -0800
Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us> wrote:

> On Tue, 19 Feb 2008 13:38:45 -0300, Mauro Carvalho Chehab wrote:
> 
> > Could you please rebase your changesets fixing the gpio's for PowerColor Real
> > Angel 330 and send them to me?
> 
> I intend to do exactly that sometime within the next couple of weeks.

I've contacted Dâniel Fraga and fixed the remaining issue with his PowerColor
Real Angel 330: firmware should be version 2.5 in order to work. He also
confirmed that the GPIOs are the same as yours for his board.

I've already committed the fixes for it at cx88-xc3028. On his board, both radio
and TV worked fine.

To make easier for all I've changed the firmware extracting tool
to get the firmwares from cx88vid.sys. The extracting tool, and the generated
firmware still needs to be tested.

Dâniel & Daniel, could you please test ? Hopefully, I didn't make any mistake
when changing the extracting tool ;)

The tool is available at:

linuxt/Documentation/video4linux/extract_xc3028.pl

The instructions for usage written at the beginning of the file:

# For firmware version 2.5, you can use the following procedure:
#       1) Download the windows driver with something like:
#               wget http://www.power-color.com/drivers/real_angel/RA330_Driver_and_Appl
ication.zip
#                       or
#               wget ftp://driver1.cptech.com.tw/Driver/RA330TV/ra330_xp.zip
#
#       2) Extract the file cx88vid.sys from the zip into the current dir:
#               unzip -x RA330_Driver_and_Application.zip "Real Angel Driver & Application/Driver/Plug_Play/cx88vid.sys"
#       3) run the script:
#               ./extract_xc3028.pl cx88vid.sys
#       4) copy the generated file:
#               cp xc3028-v25.fw /lib/firmware

The real test were done using Dâniel's cx88vid.sys from his CD. I expect that
the site has the same file, otherwise, md5 will fail, and the firmware won't
be extracted.

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: When xc3028/xc2028 will be supported?

[Dâniel Fraga]

On Tue, 19 Feb 2008 18:20:26 -0300
Mauro Carvalho Chehab <mchehab@infradead.org> wrote:

> # For firmware version 2.5, you can use the following procedure:
> #       1) Download the windows driver with something like:
> #               wget http://www.power-color.com/drivers/real_angel/RA330_Driver_and_Appl
> ication.zip
> #                       or
> #               wget ftp://driver1.cptech.com.tw/Driver/RA330TV/ra330_xp.zip

	The cx88vid.sys I provided is the exact same file as
cx88vid.sys from the above site ;).

	But, something probably went wrong with the extraction tool

Feb 19 19:22:28 tux vmunix: xc2028 0-0061: Loading 60 firmware images from xc3028-v25.fw, type: xc2028 firmware, ver 2.5
Feb 19 19:22:28 tux vmunix: xc2028 0-0061: Reading firmware type BASE F8MHZ (3), id 0, size=6621.
Feb 19 19:22:28 tux vmunix: xc2028 0-0061: Reading firmware type BASE F8MHZ MTS (7), id 0, size=6617.
Feb 19 19:22:28 tux vmunix: xc2028 0-0061: Loading 60 firmware images from xc3028-v25.fw, type: xc2028 firmware, ver 2.5
Feb 19 19:22:28 tux vmunix: xc2028 0-0061: Reading firmware type BASE F8MHZ (3), id 0, size=6621.
Feb 19 19:22:28 tux vmunix: xc2028 0-0061: Reading firmware type BASE F8MHZ MTS (7), id 0, size=6617.
Feb 19 19:22:28 tux vmunix: xc2028 0-0061: Reading firmware type BASE FM (401), id 0, size=6517.
Feb 19 19:22:28 tux vmunix: xc2028 0-0061: Reading firmware type BASE FM INPUT1 (c01), id 0, size=6531.
Feb 19 19:22:28 tux vmunix: xc2028 0-0061: Reading firmware type BASE (1), id 0, size=6611.
Feb 19 19:22:28 tux vmunix: xc2028 0-0061: Reading firmware type BASE MTS (5), id 0, size=6595.
Feb 19 19:22:28 tux vmunix: xc2028 0-0061: Reading firmware type (0), id 100000007, size=161.
Feb 19 19:22:28 tux vmunix: xc2028 0-0061: Firmware type INIT1 F8MHZ D2620 DTV7 (408a), id 2012d00022000 is corrupted (size=10946, expected 786712)
Feb 19 19:22:28 tux vmunix: xc2028 0-0061: Error: firmware file is corrupted!
Feb 19 19:22:28 tux vmunix: xc2028 0-0061: Releasing partially loaded firmware file.
Feb 19 19:22:28 tux vmunix: xc2028 0-0061: Loading 60 firmware images from xc3028-v25.fw, type: xc2028 firmware, ver 2.5
Feb 19 19:22:28 tux vmunix: xc2028 0-0061: Reading firmware type BASE F8MHZ (3), id 0, size=6621.
Feb 19 19:22:29 tux vmunix: xc2028 0-0061: Error on line 1070: -121

	With the previous xc3028-v25.fw you provided me everything is ok.

	The result .fw file is:

50763 Feb 19 19:20 xc3028-v25.fw

md5sum: a32040cb492ea1ee52772c51ec967525

-- 
Linux 2.6.24: Arr Matey! A Hairy Bilge Rat!
http://u-br.net http://www.abusar.org/FELIZ_2008.html


--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: Wh en xc3028/xc2028 will be supported?

[mkrufky]

Mauro Carvalho Chehab wrote:
> On Mon, 18 Feb 2008 23:44:33 -0500
> "Michael Krufky" <mkrufky@linuxtv.org> wrote:
>
>   
>> On Jan 29, 2008 9:25 AM, Mauro Carvalho Chehab <mchehab@infradead.org>
wrote:
>>     
>>> Dâniel and others,
>>>
>>>       
>>>>> Having this tested is a very good news! I'll need to merge this patch
with two
>>>>> other patches that adds DVB support for cx88/xc3028. If I can manage
to have
>>>>> some time for this merge, I'll commit and ask Linus to add this to
2.6.25.
>>>>>           
>>>>       :)
>>>>         
>>> I've merged some patches from several authors, that add xc3028 support
for
>>> cx88.
>>>
>>> The experimental tree is available at:
>>>
>>> http://linuxtv.org/hg/~mchehab/cx88-xc2028
>>>
>>> This patch series adds support for the following boards:
>>>
>>>  59 -> DVICO HDTV5 PCI Nano                                [18ac:d530]
>>>  60 -> Pinnacle Hybrid PCTV                                [12ab:1788]
>>>  61 -> Winfast TV2000 XP Global                            [107d:6f18]
>>>  62 -> PowerColor Real Angel 330                           [14f1:ea3d]
>>>  63 -> Geniatech X8000-MT DVBT                             [14f1:8852]
>>>  64 -> DViCO FusionHDTV DVB-T PRO                          [18ac:db30]
>>>
>>> In thesis, both analog and DVB support (for boards with DVB/ATSC) should
be
>>> working (*). Maybe analog audio may need an additional configuration for
some
>>> specific board (since they may require to add cfg.mts = 1 at xc3028
>>> initialization code, on cx88-cards).
>>>
>>> Please test.
>>>       
>> Mauro,
>>
>> We spoke on Thursday, and you asked me to take a look at the code in
>> your 'cx88-xc2028' tree over the weekend and fix it, if possible.
>>
>> The repository is broken after and including changeset ce6afd207b71 -
>> "Make xc3028 support more generic"  This changeset moves the
>> device-specific configuration out of the cx88-dvb.c device-specific
>> switch..case block, into a generic function.  This patch breaks
>> functionality, and imho, is not a good idea.
>>
>> Your changes assume that the analog side of the driver will come up
>> before the digital side of the driver, which is not necessarily the
>> case.  Additionally, in some cases, the tuner itself is hidden behind
>> an i2c gate that is controlled by the dvb / atsc demodulator.  Because
>> of the i2c gate, communication to the tuner might not be available at
>> the time that the i2c bus is probed.  For those reasons, the attach
>> calls to the tuner driver should be fully qualified, relative to the
>> functionality of the side of the driver that is attaching it.
>>
>> The device that I used to test is the FusionHDTV 5 PCI nano.  This
>> device uses an xc3008 (yes, that is xc3008 -- not a typo) and a
>> s5h1409 demod.  The device is capable of receiving ATSC digital
>> broadcasts and the driver does not yet support analog television.
>>
>> Steve Toth made the patch that adds atsc support for that card, and
>> his patch worked without the additional changesets that were added
>> afterwards.  I made some small fixes and enabled IR support -- see the
>> bottom of this email for my pull request.
>>
>> Your email above states that you've "merged some patches from several
>> authors".  What I recommend, in order to properly support each device,
>> would be to apply each patch for each card separately, as we do with
>> all card support additions.  We know that the original patches, as
>> submitted by the original authors work properly , since those authors
>> have conducted their own tests.
>>
>> I understand that you've made some attempts to optimize the code in an
>> effort to reduce memory consumption.  Unfortunately, these efforts
>> have broken functionality of these devices.  I think that it would
>> make more sense to work on optimizations after the basic device
>> support patches are first applied in the standard manner.  This way,
>> you would have a good point of reference for "before" and "after" that
>> testers will be able to use for comparison (and bisection).
>>
>> Since the only card that I can test is the PCI nano, please pull these
>> changesets into master for now.
>>
>> Please pull from:
>>
>> http://linuxtv.org/hg/~mkrufky/cx88-xc2028
>>
>> for:
>>
>> (91113b8955e2) 4 weeks ago	Steven Toth 	cx88: Add support for the
>> Dvico PCI Nano.
>> (394d249f03f1) 47 hours ago	Michael Krufky 	cx88: fix FusionHDTV 5 PCI
>> nano name and enable IR support
>>     
>
> Michael,
>
> It is not that simple. Steven patch works for DTV on PCI Nano; Christopher
> patches for some other DiVCO boards (DTV also); my port of Markus patch
for
> other boards (tested by Dâniel Fraga - Analog TV).
>   

What does one board have to do with another?  Just because these boards 
all use xceive tuners does not mean that they should be grouped together.


> The point is not saving memory. The point is that tuner-xc2028 requires
just
> one callback. The callback should work properly for DTV, Analog and Radio.
It
> makes no sense to have such generic callback inside cx88-dvb. It should be
at
> cx88xx module, instead.
>   
I agree that there should be in a single callback.  The appropriate 
place for this callback should be inside cx88-cards.c , and you'll have 
to include a prototype for this callback function in cx88.h.

Because the user has the ability to load cx8800 without cx88-dvb, and 
likewise, the user has the ability to load cx88-dvb without cx8800, the 
attach call must be fully qualified such that the other side of the 
driver is not required to be loaded in order for the tuner to work.  
Each attach call will need to include a pointer to this callback.  The 
tuner driver should ignore the callback parameter in the attach function 
if the callback is already defined -- this will allow for a user that 
loads cx8800 without cx88-dvb to use the tuner.  Likewise, this will 
also allow users that load cx88-dvb but not cx8800 to successfully use 
the tuner.

In the case of FusionHDTV5 pci nano, there will never be an attach call 
from the analog side of the driver, since the tuner is hidden behind the 
s5h1409's i2c gate, and analog mode is not supported with the current 
driver.  If you set i2c_scan=1 on the PCI nano, the xceive tuner will 
not even show up in the scan.

> We need one solution that works for all boards, not just yours.
>
> That's said, maybe SET_TUNER_CONFIG is being called too early. Maybe the
way to
> fix this is to create an special function to initialize it, that would be
> called later by cx8800 or cx8802.
both cx8800 *and* cx8802 need this functionality.  Please keep in mind 
that some users do not ever use analog mode of these cards, and some 
have even blacklisted cx8800 from loading.  This is fine, because cx8800 
is not needed for cx88-dvb to function properly.  This is a level of 
flexibility that we do not want to remove.

The _real_ problem is that the tuner is being attached to the bridge 
driver in two locations -- analog side and digital side.  This problem 
will be entirely avoided once we are attaching the tuner driver in a 
single location, globally to the entire driver.  Such changes are 
planned to be dealt with in tuner refactor phase 4, but I am still 
dealing with refactoring the prerequisites for this scenario, in phase 3 
-- all will come in due time, but for now, we must provide a fully 
qualified attachment call each time we attach a tuner driver.

Regards,

Mike

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: Wh en xc3028/xc2028 will be supported?

[Mauro Carvalho Chehab]

> > It is not that simple. Steven patch works for DTV on PCI Nano; Christopher
> > patches for some other DiVCO boards (DTV also); my port of Markus patch
> for
> > other boards (tested by Dâniel Fraga - Analog TV).
> >   
> 
> What does one board have to do with another?  Just because these boards 
> all use xceive tuners does not mean that they should be grouped together.

No, but we have patches for all of them.

> Because the user has the ability to load cx8800 without cx88-dvb, and 
> likewise, the user has the ability to load cx88-dvb without cx8800, the 
> attach call must be fully qualified such that the other side of the 
> driver is not required to be loaded in order for the tuner to work.

If you take a look at the code, you'll see that all code is at cx88xx. This
module is loaded by cx8800, if you're using analog, or by cx8802, if you're
using cx88-dvb or cx88-blackbird.

The code initializes xc3028 before tuner attach.

> In the case of FusionHDTV5 pci nano, there will never be an attach call 
> from the analog side of the driver, since the tuner is hidden behind the 
> s5h1409's i2c gate, and analog mode is not supported with the current 
> driver.  If you set i2c_scan=1 on the PCI nano, the xceive tuner will 
> not even show up in the scan.

The proper fix is to open the i2c gate before loading tuner. This will allow
i2c_scan to work and both analog and digital modes will work. Btw, this
somewhat similar to what dvico_fusionhdtv_hybrid_init() does on cx88-cards.

I've added a patch that should open the bridge for s5h1409. Please test. 


> > We need one solution that works for all boards, not just yours.
> >
> > That's said, maybe SET_TUNER_CONFIG is being called too early. Maybe the
> way to
> > fix this is to create an special function to initialize it, that would be
> > called later by cx8800 or cx8802.
> both cx8800 *and* cx8802 need this functionality.  Please keep in mind 
> that some users do not ever use analog mode of these cards, and some 
> have even blacklisted cx8800 from loading.  This is fine, because cx8800 
> is not needed for cx88-dvb to function properly.  This is a level of 
> flexibility that we do not want to remove.
> 
> The _real_ problem is that the tuner is being attached to the bridge 
> driver in two locations -- analog side and digital side.  This problem 
> will be entirely avoided once we are attaching the tuner driver in a 
> single location, globally to the entire driver.  Such changes are 
> planned to be dealt with in tuner refactor phase 4, but I am still 
> dealing with refactoring the prerequisites for this scenario, in phase 3 
> -- all will come in due time, but for now, we must provide a fully 
> qualified attachment call each time we attach a tuner driver.

It would be really nice to avoid having to attach it later, on cx88-dvb,
although the double attach won't hurt. I'm not sure on how you want to avoid
this.


Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: Wh en xc3028/xc2028 will be supported?

[Michael Krufky]

Mauro Carvalho Chehab wrote:
>>> It is not that simple. Steven patch works for DTV on PCI Nano; Christopher
>>> patches for some other DiVCO boards (DTV also); my port of Markus patch
>>>       
>> for
>>     
>>> other boards (tested by Dâniel Fraga - Analog TV).
>>>   
>>>       
>> What does one board have to do with another?  Just because these boards 
>> all use xceive tuners does not mean that they should be grouped together.
>>     
>
> No, but we have patches for all of them.
>
>   
>> Because the user has the ability to load cx8800 without cx88-dvb, and 
>> likewise, the user has the ability to load cx88-dvb without cx8800, the 
>> attach call must be fully qualified such that the other side of the 
>> driver is not required to be loaded in order for the tuner to work.
>>     
>
> If you take a look at the code, you'll see that all code is at cx88xx. This
> module is loaded by cx8800, if you're using analog, or by cx8802, if you're
> using cx88-dvb or cx88-blackbird.
>
> The code initializes xc3028 before tuner attach.
>
>   
>> In the case of FusionHDTV5 pci nano, there will never be an attach call 
>> from the analog side of the driver, since the tuner is hidden behind the 
>> s5h1409's i2c gate, and analog mode is not supported with the current 
>> driver.  If you set i2c_scan=1 on the PCI nano, the xceive tuner will 
>> not even show up in the scan.
>>     
>
> The proper fix is to open the i2c gate before loading tuner. This will allow
> i2c_scan to work and both analog and digital modes will work. Btw, this
> somewhat similar to what dvico_fusionhdtv_hybrid_init() does on cx88-cards.
>
> I've added a patch that should open the bridge for s5h1409. Please test. 
Mauro,

It does not work.  See my prior email in this thread for the explanation.

[ 2912.355967] Linux video capture interface: v2.00
[ 2912.373470] cx88/0: cx2388x v4l2 driver version 0.0.6 loaded
[ 2912.373536] ACPI: PCI Interrupt 0000:02:07.0[A] -> GSI 19 (level,
low) -> IRQ 17
[ 2912.373601] cx88[0]: subsystem: 18ac:d530, board: DVICO HDTV5 PCI
Nano [card=59,autodetected]
[ 2912.373607] cx88[0]: TV tuner type 71, Radio tuner type -1
[ 2912.555088] cx88[0]: Asking xc2028/3028 to load firmware xc3028-v27.fw
[ 2912.555111] cx88[0]/0: found at 0000:02:07.0, rev: 5, irq: 17,
latency: 64, mmio: 0xe4000000
[ 2912.555184] cx88[0]/0: registered device video0 [v4l2]
[ 2912.555215] cx88[0]/0: registered device vbi0
[ 2936.013682] cx88/2: cx2388x MPEG-TS Driver Manager version 0.0.6 loaded
[ 2936.013886] cx88[0]/2: cx2388x 8802 Driver Manager
[ 2936.013910] ACPI: PCI Interrupt 0000:02:07.2[A] -> GSI 19 (level,
low) -> IRQ 17
[ 2936.013924] cx88[0]/2: found at 0000:02:07.2, rev: 5, irq: 17,
latency: 64, mmio: 0xe6000000
[ 2936.051716] cx88/2: cx2388x dvb driver version 0.0.6 loaded
[ 2936.051725] cx88/2: registering cx8802 driver, type: dvb access: shared
[ 2936.051733] cx88[0]/2: subsystem: 18ac:d530, board: DVICO HDTV5 PCI
Nano [card=59]
[ 2936.051737] cx88[0]/2: cx2388x based DVB/ATSC card
[ 2936.094831] xc2028 1-0061: type set to XCeive xc2028/xc3028 tuner
[ 2936.094837] cx88[0]/2: xc3028 attached
[ 2936.095819] DVB: registering new adapter (cx88[0])
[ 2936.095825] DVB: registering frontend 0 (Samsung S5H1409 QAM/8VSB
Frontend)...
[ 2943.273085] xc2028 1-0061: xc2028/3028 firmware name not set!
[ 2944.378510] xc2028 1-0061: xc2028/3028 firmware name not set!
[ 2945.483933] xc2028 1-0061: xc2028/3028 firmware name not set!
[ 2946.589366] xc2028 1-0061: xc2028/3028 firmware name not set!
[ 2946.594186] xc2028 1-0061: Error on line 1068: -121
[ 2948.664531] xc2028 1-0061: xc2028/3028 firmware name not set!
[ 2949.765979] xc2028 1-0061: xc2028/3028 firmware name not set!
[ 2950.867404] xc2028 1-0061: xc2028/3028 firmware name not set!
[ 2951.968841] xc2028 1-0061: xc2028/3028 firmware name not set!
[ 2953.070277] xc2028 1-0061: xc2028/3028 firmware name not set!
[ 2954.171711] xc2028 1-0061: xc2028/3028 firmware name not set!
[ 2955.273151] xc2028 1-0061: xc2028/3028 firmware name not set!
[ 2956.374804] xc2028 1-0061: xc2028/3028 firmware name not set!
[ 2957.476020] xc2028 1-0061: xc2028/3028 firmware name not set!
[ 2958.473772] xc2028 1-0061: Error on line 1068: -121


-Mike


--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: Wh en xc3028/xc2028 will be supported?

[Mauro Carvalho Chehab]

On Thu, 21 Feb 2008 20:38:09 -0500
Michael Krufky <mkrufky@linuxtv.org> wrote:

> Mauro Carvalho Chehab wrote:
> >>> It is not that simple. Steven patch works for DTV on PCI Nano; Christopher
> >>> patches for some other DiVCO boards (DTV also); my port of Markus patch
> >>>       
> >> for
> >>     
> >>> other boards (tested by Dâniel Fraga - Analog TV).
> >>>   
> >>>       
> >> What does one board have to do with another?  Just because these boards 
> >> all use xceive tuners does not mean that they should be grouped together.
> >>     
> >
> > No, but we have patches for all of them.
> >
> >   
> >> Because the user has the ability to load cx8800 without cx88-dvb, and 
> >> likewise, the user has the ability to load cx88-dvb without cx8800, the 
> >> attach call must be fully qualified such that the other side of the 
> >> driver is not required to be loaded in order for the tuner to work.
> >>     
> >
> > If you take a look at the code, you'll see that all code is at cx88xx. This
> > module is loaded by cx8800, if you're using analog, or by cx8802, if you're
> > using cx88-dvb or cx88-blackbird.
> >
> > The code initializes xc3028 before tuner attach.
> >
> >   
> >> In the case of FusionHDTV5 pci nano, there will never be an attach call 
> >> from the analog side of the driver, since the tuner is hidden behind the 
> >> s5h1409's i2c gate, and analog mode is not supported with the current 
> >> driver.  If you set i2c_scan=1 on the PCI nano, the xceive tuner will 
> >> not even show up in the scan.
> >>     
> >
> > The proper fix is to open the i2c gate before loading tuner. This will allow
> > i2c_scan to work and both analog and digital modes will work. Btw, this
> > somewhat similar to what dvico_fusionhdtv_hybrid_init() does on cx88-cards.
> >
> > I've added a patch that should open the bridge for s5h1409. Please test. 
> Mauro,
> 
> It does not work.  See my prior email in this thread for the explanation.
> 
> [ 2912.355967] Linux video capture interface: v2.00
> [ 2912.373470] cx88/0: cx2388x v4l2 driver version 0.0.6 loaded
> [ 2912.373536] ACPI: PCI Interrupt 0000:02:07.0[A] -> GSI 19 (level,
> low) -> IRQ 17
> [ 2912.373601] cx88[0]: subsystem: 18ac:d530, board: DVICO HDTV5 PCI
> Nano [card=59,autodetected]
> [ 2912.373607] cx88[0]: TV tuner type 71, Radio tuner type -1
> [ 2912.555088] cx88[0]: Asking xc2028/3028 to load firmware xc3028-v27.fw
		          ^^^^
The above message were generated by cx88-cards. So, as I said before, this were
called _before_ running dvb_register, defined at cx88-dvb.

The issue is simple: the i2c gate code were wrong. So, xc3028 is not visible on
that point of the code. With this, analog support will never work. The proper
fix is to enable xc3028 before enabling i2c, meaning to correct the code at
cx88_pci_nano_init().

After re-visiting s5h1409 code, I noticed that I've used the wrong sequence for
the gate. The state should be i2c closed, for xc3028 to work. The following
patch should fix:

http://linuxtv.org/hg/~mchehab/cx88-xc2028/rev/871db4e0451c

Please test it, with i2c_scan=1, and post the results.

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [linux-dvb] [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: Wh en xc3028/xc2028 will be supported?

[Michael Krufky]

Mauro Carvalho Chehab wrote:
> On Thu, 21 Feb 2008 20:38:09 -0500
> Michael Krufky <mkrufky@linuxtv.org> wrote:
>
>   
>> Mauro Carvalho Chehab wrote:
>>     
>>>>> It is not that simple. Steven patch works for DTV on PCI Nano; Christopher
>>>>> patches for some other DiVCO boards (DTV also); my port of Markus patch
>>>>>       
>>>>>           
>>>> for
>>>>     
>>>>         
>>>>> other boards (tested by Dâniel Fraga - Analog TV).
>>>>>   
>>>>>       
>>>>>           
>>>> What does one board have to do with another?  Just because these boards 
>>>> all use xceive tuners does not mean that they should be grouped together.
>>>>     
>>>>         
>>> No, but we have patches for all of them.
>>>
>>>   
>>>       
>>>> Because the user has the ability to load cx8800 without cx88-dvb, and 
>>>> likewise, the user has the ability to load cx88-dvb without cx8800, the 
>>>> attach call must be fully qualified such that the other side of the 
>>>> driver is not required to be loaded in order for the tuner to work.
>>>>     
>>>>         
>>> If you take a look at the code, you'll see that all code is at cx88xx. This
>>> module is loaded by cx8800, if you're using analog, or by cx8802, if you're
>>> using cx88-dvb or cx88-blackbird.
>>>
>>> The code initializes xc3028 before tuner attach.
>>>
>>>   
>>>       
>>>> In the case of FusionHDTV5 pci nano, there will never be an attach call 
>>>> from the analog side of the driver, since the tuner is hidden behind the 
>>>> s5h1409's i2c gate, and analog mode is not supported with the current 
>>>> driver.  If you set i2c_scan=1 on the PCI nano, the xceive tuner will 
>>>> not even show up in the scan.
>>>>     
>>>>         
>>> The proper fix is to open the i2c gate before loading tuner. This will allow
>>> i2c_scan to work and both analog and digital modes will work. Btw, this
>>> somewhat similar to what dvico_fusionhdtv_hybrid_init() does on cx88-cards.
>>>
>>> I've added a patch that should open the bridge for s5h1409. Please test. 
>>>       
>> Mauro,
>>
>> It does not work.  See my prior email in this thread for the explanation.
>>
>> [ 2912.355967] Linux video capture interface: v2.00
>> [ 2912.373470] cx88/0: cx2388x v4l2 driver version 0.0.6 loaded
>> [ 2912.373536] ACPI: PCI Interrupt 0000:02:07.0[A] -> GSI 19 (level,
>> low) -> IRQ 17
>> [ 2912.373601] cx88[0]: subsystem: 18ac:d530, board: DVICO HDTV5 PCI
>> Nano [card=59,autodetected]
>> [ 2912.373607] cx88[0]: TV tuner type 71, Radio tuner type -1
>> [ 2912.555088] cx88[0]: Asking xc2028/3028 to load firmware xc3028-v27.fw
>>     
> 		          ^^^^
> The above message were generated by cx88-cards. So, as I said before, this were
> called _before_ running dvb_register, defined at cx88-dvb.
>
> The issue is simple: the i2c gate code were wrong. So, xc3028 is not visible on
> that point of the code. With this, analog support will never work. The proper
> fix is to enable xc3028 before enabling i2c, meaning to correct the code at
> cx88_pci_nano_init().
>
> After re-visiting s5h1409 code, I noticed that I've used the wrong sequence for
> the gate. The state should be i2c closed, for xc3028 to work. The following
> patch should fix:
>
> http://linuxtv.org/hg/~mchehab/cx88-xc2028/rev/871db4e0451c
>
> Please test it, with i2c_scan=1, and post the results.
>   

Doesn't work.

[  795.056020] Linux video capture interface: v2.00
[  798.235564] cx88/0: cx2388x v4l2 driver version 0.0.6 loaded
[  798.235643] ACPI: PCI Interrupt 0000:02:07.0[A] -> GSI 19 (level,
low) -> IRQ 18
[  798.235718] cx88[0]: subsystem: 18ac:d530, board: DVICO HDTV5 PCI
Nano [card=59,autodetected]
[  798.235722] cx88[0]: TV tuner type 71, Radio tuner type -1
[  798.371224] cx88[0]: i2c scan: found device @ 0x32  [???]
[  798.371391] cx88[0]: i2c scan: found device @ 0x34  [???]
[  798.399887] cx88[0]: i2c scan: found device @ 0xa0  [eeprom]
[  798.400319] cx88[0]: i2c scan: found device @ 0xa2  [???]
[  798.400482] cx88[0]: i2c scan: found device @ 0xa4  [???]
[  798.400642] cx88[0]: i2c scan: found device @ 0xa6  [???]
[  798.400800] cx88[0]: i2c scan: found device @ 0xa8  [???]
[  798.400957] cx88[0]: i2c scan: found device @ 0xaa  [???]
[  798.401116] cx88[0]: i2c scan: found device @ 0xac  [???]
[  798.401272] cx88[0]: i2c scan: found device @ 0xae  [???]
[  798.411996] cx88[0]: i2c scan: found device @ 0xd6  [???]
[  798.488821] Closing s5h1409 i2c gate to allow xc3028 detection
[  798.489283] cx88[0]: Asking xc2028/3028 to load firmware xc3028-v27.fw
[  798.489301] cx88[0]/0: found at 0000:02:07.0, rev: 5, irq: 18,
latency: 64, mmio: 0xe4000000
[  798.489376] cx88[0]/0: registered device video0 [v4l2]
[  798.489408] cx88[0]/0: registered device vbi0
[  818.236239] cx88/2: cx2388x MPEG-TS Driver Manager version 0.0.6 loaded
[  818.236443] cx88[0]/2: cx2388x 8802 Driver Manager
[  818.236465] ACPI: PCI Interrupt 0000:02:07.2[A] -> GSI 19 (level,
low) -> IRQ 18
[  818.236480] cx88[0]/2: found at 0000:02:07.2, rev: 5, irq: 18,
latency: 64, mmio: 0xe6000000
[  818.254906] cx88/2: cx2388x dvb driver version 0.0.6 loaded
[  818.254913] cx88/2: registering cx8802 driver, type: dvb access: shared
[  818.254918] cx88[0]/2: subsystem: 18ac:d530, board: DVICO HDTV5 PCI
Nano [card=59]
[  818.254922] cx88[0]/2: cx2388x based DVB/ATSC card
[  818.309763] xc2028 1-0061: type set to XCeive xc2028/xc3028 tuner
[  818.309768] cx88[0]/2: xc3028 attached
[  818.310968] DVB: registering new adapter (cx88[0])
[  818.311080] DVB: registering frontend 0 (Samsung S5H1409 QAM/8VSB
Frontend)...
[  826.542292] xc2028 1-0061: xc2028/3028 firmware name not set!
[  827.643657] xc2028 1-0061: xc2028/3028 firmware name not set!
[  828.745093] xc2028 1-0061: xc2028/3028 firmware name not set!
[  829.846543] xc2028 1-0061: xc2028/3028 firmware name not set!
[  830.844337] xc2028 1-0061: Error on line 1068: -121

-Mike


--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [linux-dvb] [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: Wh en xc3028/xc2028 will be supported?

[Michael Krufky]

Michael Krufky wrote:
> Mauro Carvalho Chehab wrote:
>   
>> On Thu, 21 Feb 2008 20:38:09 -0500
>> Michael Krufky <mkrufky@linuxtv.org> wrote:
>>
>>   
>>     
>>> Mauro Carvalho Chehab wrote:
>>>     
>>>       
>>>>>> It is not that simple. Steven patch works for DTV on PCI Nano; Christopher
>>>>>> patches for some other DiVCO boards (DTV also); my port of Markus patch
>>>>>>       
>>>>>>           
>>>>>>             
>>>>> for
>>>>>     
>>>>>         
>>>>>           
>>>>>> other boards (tested by Dâniel Fraga - Analog TV).
>>>>>>   
>>>>>>       
>>>>>>           
>>>>>>             
>>>>> What does one board have to do with another?  Just because these boards 
>>>>> all use xceive tuners does not mean that they should be grouped together.
>>>>>     
>>>>>         
>>>>>           
>>>> No, but we have patches for all of them.
>>>>
>>>>   
>>>>       
>>>>         
>>>>> Because the user has the ability to load cx8800 without cx88-dvb, and 
>>>>> likewise, the user has the ability to load cx88-dvb without cx8800, the 
>>>>> attach call must be fully qualified such that the other side of the 
>>>>> driver is not required to be loaded in order for the tuner to work.
>>>>>     
>>>>>         
>>>>>           
>>>> If you take a look at the code, you'll see that all code is at cx88xx. This
>>>> module is loaded by cx8800, if you're using analog, or by cx8802, if you're
>>>> using cx88-dvb or cx88-blackbird.
>>>>
>>>> The code initializes xc3028 before tuner attach.
>>>>
>>>>   
>>>>       
>>>>         
>>>>> In the case of FusionHDTV5 pci nano, there will never be an attach call 
>>>>> from the analog side of the driver, since the tuner is hidden behind the 
>>>>> s5h1409's i2c gate, and analog mode is not supported with the current 
>>>>> driver.  If you set i2c_scan=1 on the PCI nano, the xceive tuner will 
>>>>> not even show up in the scan.
>>>>>     
>>>>>         
>>>>>           
>>>> The proper fix is to open the i2c gate before loading tuner. This will allow
>>>> i2c_scan to work and both analog and digital modes will work. Btw, this
>>>> somewhat similar to what dvico_fusionhdtv_hybrid_init() does on cx88-cards.
>>>>
>>>> I've added a patch that should open the bridge for s5h1409. Please test. 
>>>>       
>>>>         
>>> Mauro,
>>>
>>> It does not work.  See my prior email in this thread for the explanation.
>>>
>>> [ 2912.355967] Linux video capture interface: v2.00
>>> [ 2912.373470] cx88/0: cx2388x v4l2 driver version 0.0.6 loaded
>>> [ 2912.373536] ACPI: PCI Interrupt 0000:02:07.0[A] -> GSI 19 (level,
>>> low) -> IRQ 17
>>> [ 2912.373601] cx88[0]: subsystem: 18ac:d530, board: DVICO HDTV5 PCI
>>> Nano [card=59,autodetected]
>>> [ 2912.373607] cx88[0]: TV tuner type 71, Radio tuner type -1
>>> [ 2912.555088] cx88[0]: Asking xc2028/3028 to load firmware xc3028-v27.fw
>>>     
>>>       
>> 		          ^^^^
>> The above message were generated by cx88-cards. So, as I said before, this were
>> called _before_ running dvb_register, defined at cx88-dvb.
>>
>> The issue is simple: the i2c gate code were wrong. So, xc3028 is not visible on
>> that point of the code. With this, analog support will never work. The proper
>> fix is to enable xc3028 before enabling i2c, meaning to correct the code at
>> cx88_pci_nano_init().
>>
>> After re-visiting s5h1409 code, I noticed that I've used the wrong sequence for
>> the gate. The state should be i2c closed, for xc3028 to work. The following
>> patch should fix:
>>
>> http://linuxtv.org/hg/~mchehab/cx88-xc2028/rev/871db4e0451c
>>
>> Please test it, with i2c_scan=1, and post the results.
>>   
>>     
>
> Doesn't work.
>
> [  795.056020] Linux video capture interface: v2.00
> [  798.235564] cx88/0: cx2388x v4l2 driver version 0.0.6 loaded
> [  798.235643] ACPI: PCI Interrupt 0000:02:07.0[A] -> GSI 19 (level,
> low) -> IRQ 18
> [  798.235718] cx88[0]: subsystem: 18ac:d530, board: DVICO HDTV5 PCI
> Nano [card=59,autodetected]
> [  798.235722] cx88[0]: TV tuner type 71, Radio tuner type -1
> [  798.371224] cx88[0]: i2c scan: found device @ 0x32  [???]
> [  798.371391] cx88[0]: i2c scan: found device @ 0x34  [???]
> [  798.399887] cx88[0]: i2c scan: found device @ 0xa0  [eeprom]
> [  798.400319] cx88[0]: i2c scan: found device @ 0xa2  [???]
> [  798.400482] cx88[0]: i2c scan: found device @ 0xa4  [???]
> [  798.400642] cx88[0]: i2c scan: found device @ 0xa6  [???]
> [  798.400800] cx88[0]: i2c scan: found device @ 0xa8  [???]
> [  798.400957] cx88[0]: i2c scan: found device @ 0xaa  [???]
> [  798.401116] cx88[0]: i2c scan: found device @ 0xac  [???]
> [  798.401272] cx88[0]: i2c scan: found device @ 0xae  [???]
> [  798.411996] cx88[0]: i2c scan: found device @ 0xd6  [???]
> [  798.488821] Closing s5h1409 i2c gate to allow xc3028 detection
> [  798.489283] cx88[0]: Asking xc2028/3028 to load firmware xc3028-v27.fw
> [  798.489301] cx88[0]/0: found at 0000:02:07.0, rev: 5, irq: 18,
> latency: 64, mmio: 0xe4000000
> [  798.489376] cx88[0]/0: registered device video0 [v4l2]
> [  798.489408] cx88[0]/0: registered device vbi0
> [  818.236239] cx88/2: cx2388x MPEG-TS Driver Manager version 0.0.6 loaded
> [  818.236443] cx88[0]/2: cx2388x 8802 Driver Manager
> [  818.236465] ACPI: PCI Interrupt 0000:02:07.2[A] -> GSI 19 (level,
> low) -> IRQ 18
> [  818.236480] cx88[0]/2: found at 0000:02:07.2, rev: 5, irq: 18,
> latency: 64, mmio: 0xe6000000
> [  818.254906] cx88/2: cx2388x dvb driver version 0.0.6 loaded
> [  818.254913] cx88/2: registering cx8802 driver, type: dvb access: shared
> [  818.254918] cx88[0]/2: subsystem: 18ac:d530, board: DVICO HDTV5 PCI
> Nano [card=59]
> [  818.254922] cx88[0]/2: cx2388x based DVB/ATSC card
> [  818.309763] xc2028 1-0061: type set to XCeive xc2028/xc3028 tuner
> [  818.309768] cx88[0]/2: xc3028 attached
> [  818.310968] DVB: registering new adapter (cx88[0])
> [  818.311080] DVB: registering frontend 0 (Samsung S5H1409 QAM/8VSB
> Frontend)...
> [  826.542292] xc2028 1-0061: xc2028/3028 firmware name not set!
> [  827.643657] xc2028 1-0061: xc2028/3028 firmware name not set!
> [  828.745093] xc2028 1-0061: xc2028/3028 firmware name not set!
> [  829.846543] xc2028 1-0061: xc2028/3028 firmware name not set!
> [  830.844337] xc2028 1-0061: Error on line 1068: -121
>
> -Mike
>
>   


BTW, there was a build error -- I had to change your,

warn_printk("Closing s5h1409 i2c gate to allow xc3028 detection\n");

to:

warn_printk("Closing s5h1409 i2c gate to allow xc3028 detection\n");



-Mike


--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [linux-dvb] [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: Wh en xc3028/xc2028 will be supported?

[Vanessa Ezekowitz]

On Friday 22 February 2008 8:13:44 am Michael Krufky wrote:
> warn_printk("Closing s5h1409 i2c gate to allow xc3028 detection\n");
>
> to:
>
> warn_printk("Closing s5h1409 i2c gate to allow xc3028 detection\n");

I think you meant:

warn_printk(core, "Closing s5h1409 i2c gate to allow xc3028 detection\n");

(which makes changeset 871db4e0451c compile for me)

however, cx8802 still kernel-BUGs on me when loaded (see "Re: New(ish) card 
support needed, sorta").

-- 
"Life is full of happy and sad events.  If you take the time
to concentrate on the former, you'll get further in life."
Vanessa Ezekowitz  <vanessaezekowitz@gmail.com>

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [EXPERIMENTAL] cx88+xc3028 - tests are required - was: Re: When xc3028/xc2028 will be supported?

[Adam Pribyl]

I tried latest hg version on LifeView NOT PCI Hybrid! LV3H and fw version 
27 from linuxtv web. It is now loading the firmware but the result is like 
that:

cx88/0: cx2388x v4l2 driver version 0.0.6 loaded
ACPI: PCI Interrupt Link [LNKC] enabled at IRQ 10
ACPI: PCI Interrupt 0000:00:10.0[A] -> Link [LNKC] -> GSI 10 (level, low) -> IRQ 10
cx88[0]: subsystem: 14f1:8852, board: Geniatech X8000-MT DVBT [card=63,autodetected]
cx88[0]: TV tuner type 71, Radio tuner type 0
cx88/2: cx2388x MPEG-TS Driver Manager version 0.0.6 loaded
tuner' 1-0061: chip found @ 0xc2 (cx88[0])
xc2028 1-0061: type set to XCeive xc2028/xc3028 tuner
xc2028 1-0061: xc2028/3028 firmware name not set!
cx88[0]: Asking xc2028/3028 to load firmware xc3028-v27.fw
cx88[0]/0: found at 0000:00:10.0, rev: 5, irq: 10, latency: 64, mmio: 
0xdc000000
cx88[0]/0: registered device video0 [v4l2]
cx88[0]/0: registered device vbi0
cx88[0]/0: registered device radio0
xc2028 1-0061: Loading 80 firmware images from xc3028-v27.fw, type: xc2028 
firmware, ver 2.7
cx88[0]: Calling XC2028/3028 callback
xc2028 1-0061: Loading firmware for type=BASE MTS (5), id 0000000000000000.
cx88[0]: Calling XC2028/3028 callback
cx2388x alsa driver version 0.0.6 loaded
xc2028 1-0061: Loading firmware for type=MTS (4), id 000000000000b700.
xc2028 1-0061: Device is Xceive 3028 version 1.0, firmware version 2.7
cx88[0]: Calling XC2028/3028 callback
cx88[0]/2: cx2388x 8802 Driver Manager
cx88[0]/2: found at 0000:00:10.2, rev: 5, irq: 10, latency: 64, mmio: 0xde000000
Vortex: init.... <6>cx88/2: cx2388x dvb driver version 0.0.6 loaded
cx88/2: registering cx8802 driver, type: dvb access: shared
cx88[0]/2: subsystem: 14f1:8852, board: Geniatech X8000-MT DVBT [card=63]
cx88[0]/2: cx2388x based DVB/ATSC card
xc2028 1-0061: type set to XCeive xc2028/xc3028 tuner
cx88[0]/2: xc3028 attached
DVB: registering new adapter (cx88[0])
DVB: registering frontend 0 (Zarlink ZL10353 DVB-T)...

...
cx88[0]: irq aud [0x1001] dn_risci1* dn_sync*
cx88[0]: irq aud [0x1001] dn_risci1* dn_sync*
cx88[0]: irq aud [0x1001] dn_risci1* dn_sync*
...
cx88[0]/1: IRQ loop detected, disabling interrupts
cx88[0]: irq aud [0x1101] dn_risci1* dnf_of dn_sync*
cx88[0]: Calling XC2028/3028 callback
xc2028 1-0061: Loading firmware for type=BASE F8MHZ MTS (7), id 
0000000000000000.
cx88[0]: Calling XC2028/3028 callback
MTS (4), id 00000000000000f7:
xc2028 1-0061: Loading firmware for type=MTS (4), id 0000000100000007.
xc2028 1-0061: Device is Xceive 0 version 0.0, firmware version 0.0
xc2028 1-0061: Incorrect readback of firmware version.
cx88[0]: Calling XC2028/3028 callback
xc2028 1-0061: Loading firmware for type=BASE F8MHZ MTS (7), id 
0000000000000000.
cx88[0]: Calling XC2028/3028 callback
i2c-adapter i2c-1: sendbytes: error - bailout.
xc2028 1-0061: i2c output error: rc = -14 (should be 4)
xc2028 1-0061: -14 returned from send
xc2028 1-0061: Error -22 while loading base firmware
cx88[0]: Calling XC2028/3028 callback
xc2028 1-0061: Loading firmware for type=BASE F8MHZ MTS (7), id 
0000000000000000.
...

In windows driver there is no cx88*.sys, there is just av88base.sys md5 
dcc17e434bd3863e458dc19eac3359ea

Adam Pribyl

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list