Re: [linux-dvb] DVBFE_SET_PARAMS / delsys from fe_info ioctl ?

[Manu Abraham <abraham.manu@gmail.com>]

Florian Lohoff wrote:
> Hi,
> i was wondering why i have a problem in my application that i need to
> run scan once after loading the module, otherwise my DVBFE_SET_PARAMS
> fails - I couldnt explain it until i looked into the kernel code - In
> the dvb_frontend.c i see this code:
> 
> 1738         case DVBFE_SET_PARAMS: {
> 1739                 struct dvb_frontend_tune_settings fetunesettings;
> 1740                 enum dvbfe_delsys delsys = fepriv->fe_info.delivery;
> ...
> 1783                 } else {
> 1784                         /* default values */
> 1785                         switch (fepriv->fe_info.delivery) {
> ...
> 1817                         default:
> 1818                                 up(&fepriv->sem);
> 1819                                 return -EINVAL;
> 1820                         }
> 
> Should the code use fepriv->feparam.delivery instead of
> fepriv->fe_info.delivery to sense the right delivery system ?

Which demodulator driver are you using to test your application ?

Though a bug, but that won't make any difference to what you are looking at,
since the delay and others are used in the case of swzigzag, which 
doesn't exist
at least for the existing demods using the track() callback at all.

This would be a fix for any demod drivers using the set_params() callback.

Regards,
Manu


_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb