From: e9hack <e9hack@googlemail.com>
To: linux-dvb@linuxtv.org
Subject: Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards
Date: Sat, 22 Mar 2008 12:31:12 +0100 [thread overview]
Message-ID: <47E4EE00.9080207@gmail.com> (raw)
In-Reply-To: <200803212024.17198.christophpfister@gmail.com>
Christoph Pfister schrieb:
> Hi,
>
> Can somebody please pick up those patches (descriptions inlined)?
>
> Thanks,
>
> Christoph
diff -r 1886a5ea2f84 -r f252381440c1 linux/drivers/media/dvb/ttpci/budget-av.c
--- a/linux/drivers/media/dvb/ttpci/budget-av.c Fri Mar 21 08:04:55 2008 -0300
+++ b/linux/drivers/media/dvb/ttpci/budget-av.c Fri Mar 21 19:29:15 2008 +0100
@@ -178,7 +178,7 @@ static int ciintf_read_cam_control(struc
udelay(1);
result = ttpci_budget_debiread(&budget_av->budget, DEBICICAM, address & 3, 1, 0, 0);
- if ((result == -ETIMEDOUT) || ((result == 0xff) && ((address & 3) < 2))) {
+ if ((result == -ETIMEDOUT) || ((result == 0xff) && ((address & 3) == 1))) {
ciintf_slot_shutdown(ca, slot);
printk(KERN_INFO "budget-av: cam ejected 3\n");
return -ETIMEDOUT;
IMHO you should remove the test for 0xff . Without your patch, it wasn't possible to read
0xff from address 0 and 1. Now it isn't possible to read 0xff from address 1.
I've described this problem some time ago:
http://linuxtv.org/pipermail/linux-dvb/2007-July/019436.html
-Hartmut
_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
next prev parent reply other threads:[~2008-03-22 11:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 19:24 [linux-dvb] CI/CAM fixes for knc1 dvb-s cards Christoph Pfister
2008-03-22 6:32 ` Oliver Endriss
2008-03-22 12:56 ` Christoph Pfister
2008-03-28 17:20 ` Christoph Pfister
2008-03-28 21:57 ` Christoph Pfister
2008-04-03 23:33 ` Oliver Endriss
2008-04-05 13:14 ` Christoph Pfister
2008-04-11 22:01 ` Oliver Endriss
2008-03-22 11:31 ` e9hack [this message]
2008-03-22 13:13 ` Christoph Pfister
2008-03-22 15:46 ` thomas schorpp
2008-03-28 10:45 ` Arthur Konovalov
2008-03-28 14:35 ` Christoph Pfister
2008-03-28 15:06 ` Arthur Konovalov
2008-03-28 17:16 ` Christoph Pfister
2008-03-28 20:22 ` Arthur Konovalov
2008-03-28 22:02 ` Christoph Pfister
2008-03-28 23:59 ` Arthur Konovalov
2008-03-29 15:00 ` Christoph Pfister
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E4EE00.9080207@gmail.com \
--to=e9hack@googlemail.com \
--cc=linux-dvb@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox