[linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Christoph Pfister]

[-- Attachment #1: Type: text/plain, Size: 91 bytes --]

Hi,

Can somebody please pick up those patches (descriptions inlined)?

Thanks,

Christoph

[-- Attachment #2: fix-budget-av-cam.diff --]
[-- Type: text/x-diff, Size: 1186 bytes --]

# HG changeset patch
# User Christoph Pfister <pfister@linuxtv.org>
# Date 1206124155 -3600
# Node ID f252381440c1f36ae6f3e0daded1451806d0bd8b
# Parent  1886a5ea2f84935a8356b926e0820db04e0adc84
Fix support for certain cams in buget-av
The current ci implementation doesn't accept 0xff when reading data bytes (address == 0),
thus breaks cams which report a buffer size of 0x--ff like my orion one.
Limit the 0xff check to the only register left, the status register.
Signed-off-by: Christoph Pfister <pfister@linuxtv.org>

diff -r 1886a5ea2f84 -r f252381440c1 linux/drivers/media/dvb/ttpci/budget-av.c
--- a/linux/drivers/media/dvb/ttpci/budget-av.c	Fri Mar 21 08:04:55 2008 -0300
+++ b/linux/drivers/media/dvb/ttpci/budget-av.c	Fri Mar 21 19:29:15 2008 +0100
@@ -178,7 +178,7 @@ static int ciintf_read_cam_control(struc
 	udelay(1);
 
 	result = ttpci_budget_debiread(&budget_av->budget, DEBICICAM, address & 3, 1, 0, 0);
-	if ((result == -ETIMEDOUT) || ((result == 0xff) && ((address & 3) < 2))) {
+	if ((result == -ETIMEDOUT) || ((result == 0xff) && ((address & 3) == 1))) {
 		ciintf_slot_shutdown(ca, slot);
 		printk(KERN_INFO "budget-av: cam ejected 3\n");
 		return -ETIMEDOUT;

[-- Attachment #3: fix-knc1-dvbs-ci.diff --]
[-- Type: text/x-diff, Size: 1162 bytes --]

# HG changeset patch
# User Christoph Pfister <pfister@linuxtv.org>
# Date 1206125034 -3600
# Node ID dc4505c2491d301a28ec06a669b272b3e47168b1
# Parent  f252381440c1f36ae6f3e0daded1451806d0bd8b
Fix CI interface on (some) KNC1 DVBS cards
Quoting the commit introducing reinitialise_demod (3984 / by adq):
"These cards [KNC1 DVBT and DVBC] need special handling for CI - reinitialising the frontend
device when the CI module is reset."
Apparently my 1894:0010 also needs that fix, because once you initialise CI/CAM you lose lock.
Signed-off-by: Christoph Pfister <pfister@linuxtv.org>

diff -r f252381440c1 -r dc4505c2491d linux/drivers/media/dvb/ttpci/budget-av.c
--- a/linux/drivers/media/dvb/ttpci/budget-av.c	Fri Mar 21 19:29:15 2008 +0100
+++ b/linux/drivers/media/dvb/ttpci/budget-av.c	Fri Mar 21 19:43:54 2008 +0100
@@ -943,6 +943,7 @@ static void frontend_init(struct budget_
 	case SUBID_DVBS_KNC1:
 	case SUBID_DVBS_KNC1_PLUS:
 	case SUBID_DVBS_EASYWATCH_1:
+		budget_av->reinitialise_demod = 1;
 		if (saa->pci->subsystem_vendor == 0x1894) {
 			fe = dvb_attach(stv0299_attach, &cinergy_1200s_1894_0010_config,
 					     &budget_av->budget.i2c_adap);

[-- Attachment #4: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Oliver Endriss]

Christoph Pfister wrote:
> Hi,
> 
> Can somebody please pick up those patches (descriptions inlined)?

Are these patches well-tested?

> <<<fix-budget-av-cam.diff>>>
Looks ok to me.

@budget-av users who own a CAM:

Please test this patch!


> <<<fix-knc1-dvbs-ci.diff>>>
>        case SUBID_DVBS_KNC1:
>        case SUBID_DVBS_KNC1_PLUS:
>        case SUBID_DVBS_EASYWATCH_1:
>+               budget_av->reinitialise_demod = 1;

> Fix CI interface on (some) KNC1 DVBS cards
> Quoting the commit introducing reinitialise_demod (3984 / by adq):
> "These cards [KNC1 DVBT and DVBC] need special handling for CI - reinitialising the frontend
> device when the CI module is reset."
> Apparently my 1894:0010 also needs that fix, because once you initialise CI/CAM you lose lock.
> Signed-off-by: Christoph Pfister <pfister@linuxtv.org>

Are you _sure_ that 'reinitialise_demod = 1' is required by all 3 card
types, and does not hurt for SUBID_DVBS_KNC1_PLUS (1131:0011, 1894:0011)
and SUBID_DVBS_EASYWATCH_1 (1894:001a)?

CU
Oliver

-- 
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
----------------------------------------------------------------

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Christoph Pfister]

Am Samstag 22 März 2008 schrieb Oliver Endriss:
> Christoph Pfister wrote:
> > Hi,
> >
> > Can somebody please pick up those patches (descriptions inlined)?
>
> Are these patches well-tested?

It's the initial post; so far it's only me who tested them carefully :)

The first one is pretty straightforward and shouldn't have any negative side 
effects (because it changes behaviour in the case where the current code 
simply fails with "ejected 3" error).
The second one is used in the same way for "similar" cards.

> > <<<fix-budget-av-cam.diff>>>
>
> Looks ok to me.
>
> @budget-av users who own a CAM:
>
> Please test this patch!
>
> > <<<fix-knc1-dvbs-ci.diff>>>
> >        case SUBID_DVBS_KNC1:
> >        case SUBID_DVBS_KNC1_PLUS:
> >        case SUBID_DVBS_EASYWATCH_1:
> >+               budget_av->reinitialise_demod = 1;
> >
> > Fix CI interface on (some) KNC1 DVBS cards
> > Quoting the commit introducing reinitialise_demod (3984 / by adq):
> > "These cards [KNC1 DVBT and DVBC] need special handling for CI -
> > reinitialising the frontend device when the CI module is reset."
> > Apparently my 1894:0010 also needs that fix, because once you initialise
> > CI/CAM you lose lock. Signed-off-by: Christoph Pfister
> > <pfister@linuxtv.org>
>
> Are you _sure_ that 'reinitialise_demod = 1' is required by all 3 card
> types,

Of course not - I don't own a heap of cards ;)
I applied it to all 3 types because Andrew did the same for a couple of 
dvb-c/t cards - at the moment all dvb-c/t cards inside budget-av use 
reinitialise_demod = 1.
(It could even be needed for one of the remaining dvb-s cards - who knows ...)

> and does not hurt for SUBID_DVBS_KNC1_PLUS (1131:0011, 1894:0011) 
> and SUBID_DVBS_EASYWATCH_1 (1894:001a)?

It's quite unlikely that there are any negative side effects given that it's 
quite widespread inside budget-av. As long as you don't use a cam the effect 
is zero anyway - for the other case I can't give guarantees (an unnecessary 
demod reinit after resetting the cam likely seems to be the only possible 
drawback).

> CU
> Oliver

Thanks,

Christoph

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Christoph Pfister]

Am Samstag 22 März 2008 schrieb Oliver Endriss:
> Christoph Pfister wrote:
> > Hi,
> >
> > Can somebody please pick up those patches (descriptions inlined)?
>
> Are these patches well-tested?
>
> > <<<fix-budget-av-cam.diff>>>
>
> Looks ok to me.
>
> @budget-av users who own a CAM:
>
> Please test this patch!
>
> > <<<fix-knc1-dvbs-ci.diff>>>
> >        case SUBID_DVBS_KNC1:
> >        case SUBID_DVBS_KNC1_PLUS:
> >        case SUBID_DVBS_EASYWATCH_1:
> >+               budget_av->reinitialise_demod = 1;
> >
> > Fix CI interface on (some) KNC1 DVBS cards
> > Quoting the commit introducing reinitialise_demod (3984 / by adq):
> > "These cards [KNC1 DVBT and DVBC] need special handling for CI -
> > reinitialising the frontend device when the CI module is reset."
> > Apparently my 1894:0010 also needs that fix, because once you initialise
> > CI/CAM you lose lock. Signed-off-by: Christoph Pfister
> > <pfister@linuxtv.org>
>
> Are you _sure_ that 'reinitialise_demod = 1' is required by all 3 card
> types, and does not hurt for SUBID_DVBS_KNC1_PLUS (1131:0011, 1894:0011)
> and SUBID_DVBS_EASYWATCH_1 (1894:001a)?

Do you want me to limit reinitialise_demod to the one type of card I'm using 
or is it ok for you this way?

(I'll repost a modified version of the first patch removing the 0xff check 
altogether later today ...)

> CU
> Oliver

Christoph

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Christoph Pfister]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

2008/3/28, Christoph Pfister <christophpfister@gmail.com>:
<snip>
>  > Are you _sure_ that 'reinitialise_demod = 1' is required by all 3 card
>  > types, and does not hurt for SUBID_DVBS_KNC1_PLUS (1131:0011, 1894:0011)
>  > and SUBID_DVBS_EASYWATCH_1 (1894:001a)?
>
>
> Do you want me to limit reinitialise_demod to the one type of card I'm using
>  or is it ok for you this way?
>
>  (I'll repost a modified version of the first patch removing the 0xff check
>  altogether later today ...)
<snip>

Here it is.

Christoph

[-- Attachment #2: fix-budget-av-cam.diff --]
[-- Type: text/plain, Size: 1159 bytes --]

# HG changeset patch
# User Christoph Pfister <pfister@linuxtv.org>
# Date 1206741187 -3600
# Node ID f93c302c14e51dc7dbf2a2625cfc08423c608389
# Parent  0776e480199128519666cc75fa94c4ed64db83f2
Fix support for certain cams in buget-av
The current ci implementation doesn't accept 0xff when reading data bytes (address == 0),
thus breaks cams which report a buffer size of 0x--ff like my orion one.
Remove the 0xff check altogether, because validation is really the job of a higher layer.
Signed-off-by: Christoph Pfister <pfister@linuxtv.org>

diff -r 0776e4801991 -r f93c302c14e5 linux/drivers/media/dvb/ttpci/budget-av.c
--- a/linux/drivers/media/dvb/ttpci/budget-av.c	Fri Mar 28 14:52:44 2008 -0300
+++ b/linux/drivers/media/dvb/ttpci/budget-av.c	Fri Mar 28 22:53:07 2008 +0100
@@ -178,7 +178,7 @@ static int ciintf_read_cam_control(struc
 	udelay(1);
 
 	result = ttpci_budget_debiread(&budget_av->budget, DEBICICAM, address & 3, 1, 0, 0);
-	if ((result == -ETIMEDOUT) || ((result == 0xff) && ((address & 3) < 2))) {
+	if (result == -ETIMEDOUT) {
 		ciintf_slot_shutdown(ca, slot);
 		printk(KERN_INFO "budget-av: cam ejected 3\n");
 		return -ETIMEDOUT;

[-- Attachment #3: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Oliver Endriss]

Christoph Pfister wrote:
> > > <<<fix-knc1-dvbs-ci.diff>>>
> > >        case SUBID_DVBS_KNC1:
> > >        case SUBID_DVBS_KNC1_PLUS:
> > >        case SUBID_DVBS_EASYWATCH_1:
> > >+               budget_av->reinitialise_demod = 1;
> > >
> > > Fix CI interface on (some) KNC1 DVBS cards
> > > Quoting the commit introducing reinitialise_demod (3984 / by adq):
> > > "These cards [KNC1 DVBT and DVBC] need special handling for CI -
> > > reinitialising the frontend device when the CI module is reset."
> > > Apparently my 1894:0010 also needs that fix, because once you initialise
> > > CI/CAM you lose lock. Signed-off-by: Christoph Pfister
> > > <pfister@linuxtv.org>
> >
> > Are you _sure_ that 'reinitialise_demod = 1' is required by all 3 card
> > types, and does not hurt for SUBID_DVBS_KNC1_PLUS (1131:0011, 1894:0011)
> > and SUBID_DVBS_EASYWATCH_1 (1894:001a)?
> 
> Do you want me to limit reinitialise_demod to the one type of card I'm using 
> or is it ok for you this way?

Yes, please. We should not add a quirk unless we have verified that it
is really required. It is easier to add a hack than to remove it. ;-)

> (I'll repost a modified version of the first patch removing the 0xff check 
> altogether later today ...)

OK. I'll commit your patches this weekend.

-- 
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
----------------------------------------------------------------

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Christoph Pfister]

[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]

Am Freitag 04 April 2008 schrieb Oliver Endriss:
> Christoph Pfister wrote:
> > > > <<<fix-knc1-dvbs-ci.diff>>>
> > > >        case SUBID_DVBS_KNC1:
> > > >        case SUBID_DVBS_KNC1_PLUS:
> > > >        case SUBID_DVBS_EASYWATCH_1:
> > > >+               budget_av->reinitialise_demod = 1;
> > > >
> > > > Fix CI interface on (some) KNC1 DVBS cards
> > > > Quoting the commit introducing reinitialise_demod (3984 / by adq):
> > > > "These cards [KNC1 DVBT and DVBC] need special handling for CI -
> > > > reinitialising the frontend device when the CI module is reset."
> > > > Apparently my 1894:0010 also needs that fix, because once you
> > > > initialise CI/CAM you lose lock. Signed-off-by: Christoph Pfister
> > > > <pfister@linuxtv.org>
> > >
> > > Are you _sure_ that 'reinitialise_demod = 1' is required by all 3 card
> > > types, and does not hurt for SUBID_DVBS_KNC1_PLUS (1131:0011,
> > > 1894:0011) and SUBID_DVBS_EASYWATCH_1 (1894:001a)?
> >
> > Do you want me to limit reinitialise_demod to the one type of card I'm
> > using or is it ok for you this way?
>
> Yes, please. We should not add a quirk unless we have verified that it
> is really required. It is easier to add a hack than to remove it. ;-)

Ok.

> > (I'll repost a modified version of the first patch removing the 0xff
> > check altogether later today ...)
>
> OK. I'll commit your patches this weekend.

Here is the final version - thanks :)

Christoph

[-- Attachment #2: fix-knc1-dvbs-ci.diff --]
[-- Type: text/x-diff, Size: 1254 bytes --]

# HG changeset patch
# User Christoph Pfister <pfister@linuxtv.org>
# Date 1207400970 -7200
# Node ID 107968b904703af90f0d242b7759e460caf5e454
# Parent  5f32121d01cf58806df26a7a3e5be4f5e63576ac
Fix CI interface on (some) KNC1 DVBS cards
Quoting the commit introducing reinitialise_demod (3984 / by adq):
"These cards [KNC1 DVBT and DVBC] need special handling for CI - reinitialising the frontend
device when the CI module is reset."
Apparently my 1894:0010 also needs that fix, because once you initialise CI/CAM you lose lock.
Signed-off-by: Christoph Pfister <pfister@linuxtv.org>

diff -r 5f32121d01cf -r 107968b90470 linux/drivers/media/dvb/ttpci/budget-av.c
--- a/linux/drivers/media/dvb/ttpci/budget-av.c	Sat Apr 05 14:56:16 2008 +0200
+++ b/linux/drivers/media/dvb/ttpci/budget-av.c	Sat Apr 05 15:09:30 2008 +0200
@@ -941,6 +941,12 @@ static void frontend_init(struct budget_
 	switch (saa->pci->subsystem_device) {
 
 	case SUBID_DVBS_KNC1:
+		/*
+		 * maybe that setting is needed for other dvb-s cards as well,
+		 * but so far it has been only confirmed for this type
+		 */
+		budget_av->reinitialise_demod = 1;
+		/* fall through */
 	case SUBID_DVBS_KNC1_PLUS:
 	case SUBID_DVBS_EASYWATCH_1:
 		if (saa->pci->subsystem_vendor == 0x1894) {

[-- Attachment #3: fix-budget-av-cam.diff --]
[-- Type: text/x-diff, Size: 1159 bytes --]

# HG changeset patch
# User Christoph Pfister <pfister@linuxtv.org>
# Date 1207400176 -7200
# Node ID 5f32121d01cf58806df26a7a3e5be4f5e63576ac
# Parent  1abbd650fe07ab0ea0a18dfbd1213d431dd29ccd
Fix support for certain cams in buget-av
The current ci implementation doesn't accept 0xff when reading data bytes (address == 0),
thus breaks cams which report a buffer size of 0x--ff like my orion one.
Remove the 0xff check altogether, because validation is really the job of a higher layer.
Signed-off-by: Christoph Pfister <pfister@linuxtv.org>

diff -r 1abbd650fe07 -r 5f32121d01cf linux/drivers/media/dvb/ttpci/budget-av.c
--- a/linux/drivers/media/dvb/ttpci/budget-av.c	Thu Apr 03 17:08:04 2008 -0300
+++ b/linux/drivers/media/dvb/ttpci/budget-av.c	Sat Apr 05 14:56:16 2008 +0200
@@ -178,7 +178,7 @@ static int ciintf_read_cam_control(struc
 	udelay(1);
 
 	result = ttpci_budget_debiread(&budget_av->budget, DEBICICAM, address & 3, 1, 0, 0);
-	if ((result == -ETIMEDOUT) || ((result == 0xff) && ((address & 3) < 2))) {
+	if (result == -ETIMEDOUT) {
 		ciintf_slot_shutdown(ca, slot);
 		printk(KERN_INFO "budget-av: cam ejected 3\n");
 		return -ETIMEDOUT;

[-- Attachment #4: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Oliver Endriss]

Christoph Pfister wrote:
> Am Freitag 04 April 2008 schrieb Oliver Endriss:
> > Christoph Pfister wrote:
> > > > > <<<fix-knc1-dvbs-ci.diff>>>
> > > > >        case SUBID_DVBS_KNC1:
> > > > >        case SUBID_DVBS_KNC1_PLUS:
> > > > >        case SUBID_DVBS_EASYWATCH_1:
> > > > >+               budget_av->reinitialise_demod = 1;
> > > > >
> > > > > Fix CI interface on (some) KNC1 DVBS cards
> > > > > Quoting the commit introducing reinitialise_demod (3984 / by adq):
> > > > > "These cards [KNC1 DVBT and DVBC] need special handling for CI -
> > > > > reinitialising the frontend device when the CI module is reset."
> > > > > Apparently my 1894:0010 also needs that fix, because once you
> > > > > initialise CI/CAM you lose lock. Signed-off-by: Christoph Pfister
> > > > > <pfister@linuxtv.org>
> > > >
> > > > Are you _sure_ that 'reinitialise_demod = 1' is required by all 3 card
> > > > types, and does not hurt for SUBID_DVBS_KNC1_PLUS (1131:0011,
> > > > 1894:0011) and SUBID_DVBS_EASYWATCH_1 (1894:001a)?
> > >
> > > Do you want me to limit reinitialise_demod to the one type of card I'm
> > > using or is it ok for you this way?
> >
> > Yes, please. We should not add a quirk unless we have verified that it
> > is really required. It is easier to add a hack than to remove it. ;-)
> 
> Ok.
> 
> > > (I'll repost a modified version of the first patch removing the 0xff
> > > check altogether later today ...)
> >
> > OK. I'll commit your patches this weekend.
> 
> Here is the final version - thanks :)

FYI, these patches are in HG master now.

CU
Oliver

-- 
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
----------------------------------------------------------------

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[e9hack]

Christoph Pfister schrieb:
> Hi,
> 
> Can somebody please pick up those patches (descriptions inlined)?
> 
> Thanks,
> 
> Christoph

diff -r 1886a5ea2f84 -r f252381440c1 linux/drivers/media/dvb/ttpci/budget-av.c
--- a/linux/drivers/media/dvb/ttpci/budget-av.c	Fri Mar 21 08:04:55 2008 -0300
+++ b/linux/drivers/media/dvb/ttpci/budget-av.c	Fri Mar 21 19:29:15 2008 +0100
@@ -178,7 +178,7 @@ static int ciintf_read_cam_control(struc
  	udelay(1);

  	result = ttpci_budget_debiread(&budget_av->budget, DEBICICAM, address & 3, 1, 0, 0);
-	if ((result == -ETIMEDOUT) || ((result == 0xff) && ((address & 3) < 2))) {
+	if ((result == -ETIMEDOUT) || ((result == 0xff) && ((address & 3) == 1))) {
  		ciintf_slot_shutdown(ca, slot);
  		printk(KERN_INFO "budget-av: cam ejected 3\n");
  		return -ETIMEDOUT;


IMHO you should remove the test for 0xff . Without your patch, it wasn't possible to read 
0xff from address 0 and 1. Now it isn't possible to read 0xff from address 1.

I've described this problem some time ago: 
http://linuxtv.org/pipermail/linux-dvb/2007-July/019436.html

-Hartmut

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Christoph Pfister]

Am Samstag 22 März 2008 schrieb e9hack:
> Christoph Pfister schrieb:
> > Hi,
> >
> > Can somebody please pick up those patches (descriptions inlined)?
> >
> > Thanks,
> >
> > Christoph
>
> diff -r 1886a5ea2f84 -r f252381440c1
> linux/drivers/media/dvb/ttpci/budget-av.c ---
> a/linux/drivers/media/dvb/ttpci/budget-av.c	Fri Mar 21 08:04:55 2008 -0300
> +++ b/linux/drivers/media/dvb/ttpci/budget-av.c	Fri Mar 21 19:29:15 2008
> +0100 @@ -178,7 +178,7 @@ static int ciintf_read_cam_control(struc
>   	udelay(1);
>
>   	result = ttpci_budget_debiread(&budget_av->budget, DEBICICAM, address &
> 3, 1, 0, 0); -	if ((result == -ETIMEDOUT) || ((result == 0xff) && ((address
> & 3) < 2))) { +	if ((result == -ETIMEDOUT) || ((result == 0xff) &&
> ((address & 3) == 1))) { ciintf_slot_shutdown(ca, slot);
>   		printk(KERN_INFO "budget-av: cam ejected 3\n");
>   		return -ETIMEDOUT;
>
>
> IMHO you should remove the test for 0xff . Without your patch, it wasn't
> possible to read 0xff from address 0 and 1. Now it isn't possible to read
> 0xff from address 1.

Address 1 is the status register; bits 2-5 are reserved according to en50221 
and should be zero, so this case is less problematic with regards to 0xff 
checking.

On second thoughts it's probably better to remove the check altogether, 
because a) budget-av isn't here to check standards conformance - the higher 
layers know better how to deal with the content and b) who should care if the 
other status bits work correctly ;)

> I've described this problem some time ago:
> http://linuxtv.org/pipermail/linux-dvb/2007-July/019436.html

Argh, would have saved some work for me ...

> -Hartmut

Christoph

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[thomas schorpp]

Christoph Pfister wrote:
> Am Samstag 22 März 2008 schrieb e9hack:
>> Christoph Pfister schrieb:
>>> Hi,
>>>
>>> Can somebody please pick up those patches (descriptions inlined)?
>>>
>>> Thanks,
>>>
>>> Christoph
>> diff -r 1886a5ea2f84 -r f252381440c1
>> linux/drivers/media/dvb/ttpci/budget-av.c ---
>> a/linux/drivers/media/dvb/ttpci/budget-av.c	Fri Mar 21 08:04:55 2008 -0300
>> +++ b/linux/drivers/media/dvb/ttpci/budget-av.c	Fri Mar 21 19:29:15 2008
>> +0100 @@ -178,7 +178,7 @@ static int ciintf_read_cam_control(struc
>>   	udelay(1);
>>
>>   	result = ttpci_budget_debiread(&budget_av->budget, DEBICICAM, address &
>> 3, 1, 0, 0); -	if ((result == -ETIMEDOUT) || ((result == 0xff) && ((address
>> & 3) < 2))) { +	if ((result == -ETIMEDOUT) || ((result == 0xff) &&
>> ((address & 3) == 1))) { ciintf_slot_shutdown(ca, slot);
>>   		printk(KERN_INFO "budget-av: cam ejected 3\n");
>>   		return -ETIMEDOUT;
>>
>>
>> IMHO you should remove the test for 0xff . Without your patch, it wasn't
>> possible to read 0xff from address 0 and 1. Now it isn't possible to read
>> 0xff from address 1.
> 
> Address 1 is the status register; bits 2-5 are reserved according to en50221 
> and should be zero, so this case is less problematic with regards to 0xff 
> checking.
> 
> On second thoughts it's probably better to remove the check altogether, 
> because a) budget-av isn't here to check standards conformance - the higher 
> layers know better how to deal with the content and b) who should care if the 
> other status bits work correctly ;)

Better remove all CI stuff from that wrong place.
Why is all that CI and tuner frontend (which dvb budget card has got a analogtv demod?) 
code in the budget__AV__ module ?
Pls move it to budget__CI__  and budget modules, and have the budget_av/_ci 
stuff detected there and loaded and utilized *if* needed, the current ci-code  
blocks saa7113 analog capture on plus cards and could, according to manu's research, 
confuse a knc1 dvb-s2 card completely.

and who needs cam polling? do we have got a majority of users hotswapping cams?
i want that be clarified before sending rejectable patches.

>> -Hartmut
> 
> Christoph

y
tom

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Arthur Konovalov]

Christoph Pfister wrote:
> Hi,
> 
> Can somebody please pick up those patches (descriptions inlined)?
> 
> Thanks,
> 
> Christoph

Hi!
I tried those patches, but got no picture and audio with my Terratec Cinergy 
1200 DVB-C and TechniCAM CX Conax CAM (either FTA or scrambled).

After modules loading dmesg output (I have 2 cards: DVB-T and DVB-C):

b2c2-flexcop: B2C2 FlexcopII/II(b)/III digital TV receiver chip loaded successfully
flexcop-pci: will use the HW PID filter.
flexcop-pci: card revision 2
ACPI: PCI Interrupt 0000:02:02.0[A] -> GSI 17 (level, low) -> IRQ 20
DVB: registering new adapter (FlexCop Digital TV device)
b2c2-flexcop: MAC address = 00:d0:d7:09:e0:87
b2c2-flexcop: i2c master_xfer failed
b2c2-flexcop: i2c master_xfer failed
b2c2-flexcop: found the mt352 at i2c address: 0x0f
DVB: registering frontend 0 (Zarlink MT352 DVB-T)...
b2c2-flexcop: initialization of 'Air2PC/AirStar 2 DVB-T' at the 'PCI' bus 
controlled by a 'FlexCopIIb' complete
Linux video capture interface: v2.00
saa7146: register extension 'budget_av'.
ACPI: PCI Interrupt 0000:02:01.0[A] -> GSI 22 (level, low) -> IRQ 22
saa7146: found saa7146 @ mem e0f26000 (revision 1, irq 22) (0x153b,0x1156).
saa7146 (0): dma buffer size 192512
DVB: registering new adapter (Terratec Cinergy 1200 DVB-C)
adapter failed MAC signature check
encoded MAC from EEPROM was 
ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff
KNC1-1: MAC addr = 00:0a:ac:11:00:21
TDA10021: i2c-addr = 0x0c, id = 0x7c
DVB: registering frontend 1 (Philips TDA10021 DVB-C)...
budget-av: ci interface initialised.
budget-av: cam inserted A


Now, when trying to run vdr it seems like loop in budget-av module:

budget-av: cam inserted A
DVB: TDA10021(1): _tda10021_writereg, writereg error (reg == 0x00, val == 0x73, 
ret == -121)
dvb_ca adapter 1: DVB CAM detected and initialised successfully
budget-av: cam inserted A
dvb_ca adapter 1: DVB CAM detected and initialised successfully
budget-av: cam inserted A
dvb_ca adapter 1: DVB CAM detected and initialised successfully
budget-av: cam inserted A
dvb_ca adapter 1: DVB CAM detected and initialised successfully
budget-av: cam inserted A
dvb_ca adapter 1: DVB CAM detected and initialised successfully
budget-av: cam inserted A
dvb_ca adapter 1: DVB CAM detected and initialised successfully
budget-av: cam inserted A
dvb_ca adapter 1: DVB CAM detected and initialised successfully


Corresponding log file:

Mar 28 12:15:36 vdr kernel: budget-av: cam inserted A
Mar 28 12:16:09 vdr last message repeated 9 times

Any idea to fix this?
Please...



_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Christoph Pfister]

Am Freitag 28 März 2008 schrieb Arthur Konovalov:
> Christoph Pfister wrote:
> > Hi,
> >
> > Can somebody please pick up those patches (descriptions inlined)?
> >
> > Thanks,
> >
> > Christoph
>
> Hi!
> I tried those patches, but got no picture and audio with my Terratec
> Cinergy 1200 DVB-C and TechniCAM CX Conax CAM (either FTA or scrambled).

But scrambled channels don't work without those patches either, right? (Hmm - 
fta could be broken if the cam is in an invalid state - but it would still 
work without the cam; just that people don't think this is a regression 
because of the patches ... :)

<snip>
> dvb_ca adapter 1: DVB CAM detected and initialised successfully
> budget-av: cam inserted A
> dvb_ca adapter 1: DVB CAM detected and initialised successfully
<snip>
> Any idea to fix this?
> Please...

Paste the strace output of vdr or try kaffeine ...

Christoph

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Arthur Konovalov]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

Christoph Pfister wrote:
> But scrambled channels don't work without those patches either, right?
Yes, You are right. Only black screen in xine.
> Paste the strace output of vdr or try kaffeine ...
>
>   
vdr strace log attached.

Regards,
Arthur

[-- Attachment #2: putty.zip --]
[-- Type: application/octet-stream, Size: 22564 bytes --]

[-- Attachment #3: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Christoph Pfister]

Am Freitag 28 März 2008 schrieb Arthur Konovalov:
> Christoph Pfister wrote:
> > But scrambled channels don't work without those patches either, right?
>
> Yes, You are right. Only black screen in xine.
>
> > Paste the strace output of vdr or try kaffeine ...
>
> vdr strace log attached.
>
> Regards,
> Arthur

Try removing the following three lines from 
linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c and see whether it works:

989 				/* clear down an old CI slot if necessary */
990 				if (ca->slot_info[slot].slot_state != DVB_CA_SLOTSTATE_NONE)
991 					dvb_ca_en50221_slot_shutdown(ca, slot);

If it doesn't work load budget-core with module param debug=255 and dvb-core 
with module param cam_debug=1 (likely you need to unload them first); please 
paste dmesg in any case.

Christoph

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Arthur Konovalov]

[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]

Christoph Pfister wrote:
> Am Freitag 28 März 2008 schrieb Arthur Konovalov:
> Try removing the following three lines from 
> linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c and see whether it works:
> 
> 989 				/* clear down an old CI slot if necessary */
> 990 				if (ca->slot_info[slot].slot_state != DVB_CA_SLOTSTATE_NONE)
> 991 					dvb_ca_en50221_slot_shutdown(ca, slot);

Done.

> If it doesn't work load budget-core with module param debug=255 and dvb-core 
> with module param cam_debug=1 (likely you need to unload them first); please 
> paste dmesg in any case.

I haven't xine GUI at moment, but regarding to logs I suspect that it 
doesn't works...

Attached files are:
dmesg_load_modules - dmesg after modules load.
dmesg_start_vdr - dmesg after vdr start.
syslog - syslog after vdr start.

I noticed some suspicious rows in logs:

budget_av: saa7113_init(): saa7113 not found on KNC card

DVB: TDA10021(0): _tda10021_writereg, writereg error (reg == 0x01, val 
== 0x6a, ret == -121)


I hope it helps and wish quick solution :) .

Regards,
Arthur


[-- Attachment #2: syslog.zip --]
[-- Type: application/octet-stream, Size: 11175 bytes --]

[-- Attachment #3: dmesg_load_modules.zip --]
[-- Type: application/octet-stream, Size: 1489 bytes --]

[-- Attachment #4: dmesg_start_vdr.zip --]
[-- Type: application/octet-stream, Size: 2008 bytes --]

[-- Attachment #5: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Christoph Pfister]

[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]

2008/3/28, Arthur Konovalov <kasjas@hot.ee>:
> Christoph Pfister wrote:
>  > Am Freitag 28 März 2008 schrieb Arthur Konovalov:
>  > Try removing the following three lines from
>  > linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c and see whether it works:
>  >
>  > 989                           /* clear down an old CI slot if necessary */
>  > 990                           if (ca->slot_info[slot].slot_state != DVB_CA_SLOTSTATE_NONE)
>  > 991                                   dvb_ca_en50221_slot_shutdown(ca, slot);
>
>  Done.
>
>  > If it doesn't work load budget-core with module param debug=255 and dvb-core
>  > with module param cam_debug=1 (likely you need to unload them first); please
>  > paste dmesg in any case.
>
>  I haven't xine GUI at moment, but regarding to logs I suspect that it
>  doesn't works...

Hmm.
Can you please try the attached patch (still with the modification
described above ^^) and send dmesg?

>  Attached files are:
>  dmesg_load_modules - dmesg after modules load.
>  dmesg_start_vdr - dmesg after vdr start.
>  syslog - syslog after vdr start.
>
>  I noticed some suspicious rows in logs:
>
>  budget_av: saa7113_init(): saa7113 not found on KNC card

That's no problem.

>  DVB: TDA10021(0): _tda10021_writereg, writereg error (reg == 0x01, val
>  == 0x6a, ret == -121)

That's also present in your original log ...

>  I hope it helps and wish quick solution :) .
>
>  Regards,
>
> Arthur

Christoph

[-- Attachment #2: patch.diff --]
[-- Type: text/plain, Size: 380 bytes --]

diff -r 0776e4801991 linux/drivers/media/dvb/ttpci/budget-av.c
--- a/linux/drivers/media/dvb/ttpci/budget-av.c	Fri Mar 28 14:52:44 2008 -0300
+++ b/linux/drivers/media/dvb/ttpci/budget-av.c	Fri Mar 28 22:40:22 2008 +0100
@@ -241,6 +241,8 @@ static int ciintf_slot_shutdown(struct d
 
 	if (slot != 0)
 		return -EINVAL;
+
+	WARN_ON(1);
 
 	dprintk(1, "ciintf_slot_shutdown\n");
 

[-- Attachment #3: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Arthur Konovalov]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

Christoph Pfister wrote:

> Can you please try the attached patch (still with the modification
> described above ^^) and send dmesg?

Yes, no problem. Here we are...

Arthur

[-- Attachment #2: syslog_warn.zip --]
[-- Type: application/octet-stream, Size: 17939 bytes --]

[-- Attachment #3: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[Christoph Pfister]

2008/3/29, Arthur Konovalov <kasjas@hot.ee>:
> Christoph Pfister wrote:
>
>  > Can you please try the attached patch (still with the modification
>  > described above ^^) and send dmesg?
>
>
> Yes, no problem. Here we are...
>
>  Arthur

Can you join #linuxtv (on irc.freenode.net)? My nick is christoph4 ...

Christoph

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb