Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards

[thomas schorpp <thomas.schorpp@googlemail.com>]

Christoph Pfister wrote:
> Am Samstag 22 März 2008 schrieb e9hack:
>> Christoph Pfister schrieb:
>>> Hi,
>>>
>>> Can somebody please pick up those patches (descriptions inlined)?
>>>
>>> Thanks,
>>>
>>> Christoph
>> diff -r 1886a5ea2f84 -r f252381440c1
>> linux/drivers/media/dvb/ttpci/budget-av.c ---
>> a/linux/drivers/media/dvb/ttpci/budget-av.c	Fri Mar 21 08:04:55 2008 -0300
>> +++ b/linux/drivers/media/dvb/ttpci/budget-av.c	Fri Mar 21 19:29:15 2008
>> +0100 @@ -178,7 +178,7 @@ static int ciintf_read_cam_control(struc
>>   	udelay(1);
>>
>>   	result = ttpci_budget_debiread(&budget_av->budget, DEBICICAM, address &
>> 3, 1, 0, 0); -	if ((result == -ETIMEDOUT) || ((result == 0xff) && ((address
>> & 3) < 2))) { +	if ((result == -ETIMEDOUT) || ((result == 0xff) &&
>> ((address & 3) == 1))) { ciintf_slot_shutdown(ca, slot);
>>   		printk(KERN_INFO "budget-av: cam ejected 3\n");
>>   		return -ETIMEDOUT;
>>
>>
>> IMHO you should remove the test for 0xff . Without your patch, it wasn't
>> possible to read 0xff from address 0 and 1. Now it isn't possible to read
>> 0xff from address 1.
> 
> Address 1 is the status register; bits 2-5 are reserved according to en50221 
> and should be zero, so this case is less problematic with regards to 0xff 
> checking.
> 
> On second thoughts it's probably better to remove the check altogether, 
> because a) budget-av isn't here to check standards conformance - the higher 
> layers know better how to deal with the content and b) who should care if the 
> other status bits work correctly ;)

Better remove all CI stuff from that wrong place.
Why is all that CI and tuner frontend (which dvb budget card has got a analogtv demod?) 
code in the budget__AV__ module ?
Pls move it to budget__CI__  and budget modules, and have the budget_av/_ci 
stuff detected there and loaded and utilized *if* needed, the current ci-code  
blocks saa7113 analog capture on plus cards and could, according to manu's research, 
confuse a knc1 dvb-s2 card completely.

and who needs cam polling? do we have got a majority of users hotswapping cams?
i want that be clarified before sending rejectable patches.

>> -Hartmut
> 
> Christoph

y
tom

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb