From: Mike Rapoport <mike@compulab.co.il>
To: Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>
Cc: video4linux-list@redhat.com,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: PATCH v2] pxa_camera: Add support for YUV modes
Date: Wed, 09 Apr 2008 08:32:41 +0300 [thread overview]
Message-ID: <47FC54F9.1020300@compulab.co.il> (raw)
In-Reply-To: <Pine.LNX.4.64.0804081729040.4987@axis700.grange>
Guennadi Liakhovetski wrote:
> On Tue, 8 Apr 2008, Mike Rapoport wrote:
>
>> + struct pxa_cam_dma *buf_dma;
>> + struct pxa_cam_dma *act_dma;
>> + int channels = 1;
>> + int nents;
>> + int i;
>> +
>> + if (buf->fmt->fourcc == V4L2_PIX_FMT_YUV422P)
>> + channels = 3;
>> +
>> + for (i = 0; i < channels; i++) {
>> + buf_dma = &buf->dmas[i];
>> + act_dma = &active->dmas[0];
>
> ^^^^^^^
>
> Just came across this accidentally, is the "[0]" above correct?
It should be "[i]" ...
> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski
>
--
Sincerely yours,
Mike.
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
prev parent reply other threads:[~2008-04-09 5:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 5:48 PATCH v2] pxa_camera: Add support for YUV modes Mike Rapoport
2008-04-08 15:31 ` Guennadi Liakhovetski
2008-04-09 5:32 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FC54F9.1020300@compulab.co.il \
--to=mike@compulab.co.il \
--cc=g.liakhovetski@pengutronix.de \
--cc=mchehab@infradead.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox