Re: [PATCH] pxa_camera: Add support for YUV modes

[Mike Rapoport <mike@compulab.co.il>]

Guennadi Liakhovetski wrote:
> On Sun, 6 Apr 2008, Mike Rapoport wrote:
> 
>>>> +			DCSR(pcdev->dma_chans[i]) = DCSR_RUN;
>>>> +#ifdef DEBUG
>>>> +			if (CISR & CISR_IFO_0) {
>>>> +				dev_warn(pcdev->dev, "FIFO overrun\n");
>>>> +				for (i = 0; i < channels; i++)
>>>> +					DDADR(pcdev->dma_chans[i]) =
>>>> +						pcdev->active->dmas[i].sg_dma;
>>>> +
>>>> +				CICR0 &= ~CICR0_ENB;
>>>> +				CIFR |= CIFR_RESET_F;
>>>> +				for (i = 0; i < channels; i++)
>>>> +					DCSR(pcdev->dma_chans[0]) = DCSR_RUN;
>>>> +				CICR0 |= CICR0_ENB;
>>>> +			} else {
>>>> +				for (i = 0; i < channels; i++)
>>>> +					DCSR(pcdev->dma_chans[0]) = DCSR_RUN;
>>>> +			}
>>> These three loops don't look right. At least because they use the same 
>>> index i. And you're iterating over channels inside a loop over channels, 
>>> and you have dma_chans[0] instead of [i]. Please fix.
>> Here I'm not quite sure what exactly should be done as I never got overruns.
>> For now I move this code out of the loop and in case of overrun re-enable
>> all three DMAs. BTW, the 'else' here is completely redundant, so I just removed it.
> 
> Mike, you probably saw the recent thread on this list, where the overrun 
> problem did come up: http://marc.info/?t=120732439600006&r=1&w=2 and my 
> last post in this thread with a patch. Could you, please, test it with 
> your YCbCr setup? Would be great, if you could test it with the 
> application, that fengxin quoted in his mail 
> http://marc.info/?l=linux-video&m=120762092820785&w=2, see if you too get 
> overruns with it, and see if my patch fixes them.

Sorry for the delay, and as far as I can see you've already have a fix. :)
If you'd like I can test it with YUV setup. I'll apreciate if you can send me
the entire updated pxa_camera.c, to save time on merge conflicts.

> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski
> 

-- 
Sincerely yours,
Mike.

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list