public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hansg@kernel.org>
To: Antti Laakso <antti.laakso@linux.intel.com>, linux-media@vger.kernel.org
Cc: linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	linusw@kernel.org, brgl@kernel.org, sakari.ailus@linux.intel.com,
	mchehab@kernel.org, dan.scally@ideasonboard.com,
	ilpo.jarvinen@linux.intel.com, hverkuil+cisco@kernel.org,
	sre@kernel.org, hao.yao@intel.com, jimmy.su@intel.com,
	miguel.vadillo@intel.com, kees@kernel.org, ribalda@chromium.org
Subject: Re: [PATCH v2 3/5] platform: int3472: Add gpio software node
Date: Wed, 11 Mar 2026 15:33:13 +0100	[thread overview]
Message-ID: <480d3808-caba-43ac-aed7-1ca2738bb029@kernel.org> (raw)
In-Reply-To: <20260311131910.835513-4-antti.laakso@linux.intel.com>

Hi,

On 11-Mar-26 14:19, Antti Laakso wrote:
> The tps68470 supports i2c daisy chain, which need to be configured by
> gpio-tps68470 driver. Add daisy chain information to software node.

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

Regards,

Hans



> 
> Signed-off-by: Antti Laakso <antti.laakso@linux.intel.com>
> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
> ---
>  drivers/platform/x86/intel/int3472/tps68470.c | 1 +
>  drivers/platform/x86/intel/int3472/tps68470.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/platform/x86/intel/int3472/tps68470.c b/drivers/platform/x86/intel/int3472/tps68470.c
> index a496075c0d2a..a77ed32abe55 100644
> --- a/drivers/platform/x86/intel/int3472/tps68470.c
> +++ b/drivers/platform/x86/intel/int3472/tps68470.c
> @@ -197,6 +197,7 @@ static int skl_int3472_tps68470_probe(struct i2c_client *client)
>  		cells[1].platform_data = (void *)board_data->tps68470_regulator_pdata;
>  		cells[1].pdata_size = sizeof(struct tps68470_regulator_platform_data);
>  		cells[2].name = "tps68470-gpio";
> +		cells[2].swnode = board_data->tps68470_gpio_swnode;
>  
>  		for (i = 0; i < board_data->n_gpiod_lookups; i++)
>  			gpiod_add_lookup_table(board_data->tps68470_gpio_lookup_tables[i]);
> diff --git a/drivers/platform/x86/intel/int3472/tps68470.h b/drivers/platform/x86/intel/int3472/tps68470.h
> index 35915e701593..3bbaade96c57 100644
> --- a/drivers/platform/x86/intel/int3472/tps68470.h
> +++ b/drivers/platform/x86/intel/int3472/tps68470.h
> @@ -17,6 +17,7 @@ struct tps68470_regulator_platform_data;
>  struct int3472_tps68470_board_data {
>  	const char *dev_name;
>  	const struct tps68470_regulator_platform_data *tps68470_regulator_pdata;
> +	const struct software_node *tps68470_gpio_swnode;
>  	unsigned int n_gpiod_lookups;
>  	struct gpiod_lookup_table *tps68470_gpio_lookup_tables[];
>  };


  reply	other threads:[~2026-03-11 14:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 13:19 [PATCH v2 0/5] platform: int3472: Add MSI prestige 14 AI EVO data Antti Laakso
2026-03-11 13:19 ` [PATCH v2 1/5] media: i2c: ov5675: Wait for endpoint Antti Laakso
2026-03-11 14:31   ` Hans de Goede
2026-03-11 19:10   ` Dan Scally
2026-03-11 13:19 ` [PATCH v2 2/5] media: ipu-bridge: Add ov5675 sensor Antti Laakso
2026-03-17 12:52   ` Sakari Ailus
2026-03-11 13:19 ` [PATCH v2 3/5] platform: int3472: Add gpio software node Antti Laakso
2026-03-11 14:33   ` Hans de Goede [this message]
2026-03-11 14:43   ` Bartosz Golaszewski
2026-03-17 11:53   ` Ilpo Järvinen
2026-03-11 13:19 ` [PATCH v2 4/5] gpio: tps68470: Add i2c daisy chain support Antti Laakso
2026-03-11 14:33   ` Hans de Goede
2026-03-11 14:42   ` Bartosz Golaszewski
2026-03-11 13:19 ` [PATCH v2 5/5] platform: int3472: Add MSI prestige board data Antti Laakso
2026-03-11 14:35   ` Hans de Goede
2026-03-12 21:00     ` Sakari Ailus
2026-03-11 14:43   ` Bartosz Golaszewski
2026-03-11 19:27   ` Dan Scally
2026-03-17 11:52   ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=480d3808-caba-43ac-aed7-1ca2738bb029@kernel.org \
    --to=hansg@kernel.org \
    --cc=antti.laakso@linux.intel.com \
    --cc=brgl@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=hao.yao@intel.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jimmy.su@intel.com \
    --cc=kees@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=miguel.vadillo@intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=ribalda@chromium.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox