From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m3PGuPZ5025166 for ; Fri, 25 Apr 2008 12:56:25 -0400 Received: from smtp50.hccnet.nl (smtp50.hccnet.nl [62.251.0.47]) by mx3.redhat.com (8.13.8/8.13.8) with ESMTP id m3PGu9eD031228 for ; Fri, 25 Apr 2008 12:56:10 -0400 Message-ID: <48120D15.3010109@hccnet.nl> Date: Fri, 25 Apr 2008 18:55:49 +0200 From: Gert Vervoort MIME-Version: 1.0 To: Mauro Carvalho Chehab References: <480A5CC3.6030408@pickworth.me.uk> <480B26FC.50204@hccnet.nl> <480B3673.3040707@pickworth.me.uk> <1208696771.3349.49.camel@pc10.localdom.local> <480B6CD8.7040702@hccnet.nl> <1208726202.5682.44.camel@pc10.localdom.local> <1209009328.3402.9.camel@pc10.localdom.local> <20080425105618.08c5c471@gaivota> <37219a840804250740k6b1bb64er633cff7a4e377798@mail.gmail.com> <20080425120307.69a71e17@gaivota> In-Reply-To: <20080425120307.69a71e17@gaivota> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: DVB ML , video4linux-list@redhat.com, Michael Krufky Subject: Re: Hauppauge WinTV regreession from 2.6.24 to 2.6.25 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: video4linux-list-bounces@redhat.com Errors-To: video4linux-list-bounces@redhat.com List-ID: Mauro Carvalho Chehab wrote: > On Fri, 25 Apr 2008 10:40:14 -0400 > "Michael Krufky" wrote: > > >> On Fri, Apr 25, 2008 at 9:56 AM, Mauro Carvalho Chehab >> wrote: >> >>> On Thu, 24 Apr 2008 05:55:28 +0200 >>> hermann pitton wrote: >>> >>> > > > >>>> I am testing a kernel upgrade from 2.6.24.to 2.6.25, and the drivers >>> > > > >>>> for the Hauppauge WinTV appear to have suffered some regression >>> > > > >>>> between the two kernel versions. >>> >>> >>> >>>> do you see the auto detection issue? >>>> >>> > >>> > Either tell it is just nothing, what I very seriously doubt, or please >>> > comment. >>> > >>> > I don't like to end up on LKML again getting told that written rules >>> > don't exist ;) >>> >>> Sorry for now answer earlier. Too busy here, due to the merge window. >>> >>> This seems to be an old bug. On several cases, tuner_type information came from >>> some sort of autodetection schema, but the proper setup is not sent to tuner. >>> >>> Please test the enclosed patch. It warrants that TUNER_SET_TYPE_ADDR is called >>> at saa7134_board_init2() for all those boards: >>> >>> SAA7134_BOARD_ADS_DUO_CARDBUS_PTV331 >>> SAA7134_BOARD_ASUS_EUROPA2_HYBRID >>> SAA7134_BOARD_ASUSTeK_P7131_DUAL >>> SAA7134_BOARD_ASUSTeK_P7131_HYBRID_LNA >>> SAA7134_BOARD_AVERMEDIA_SUPER_007 >>> SAA7134_BOARD_BEHOLD_COLUMBUS_TVFM >>> SAA7134_BOARD_BMK_MPEX_NOTUNER >>> SAA7134_BOARD_BMK_MPEX_TUNER >>> SAA7134_BOARD_CINERGY_HT_PCI >>> SAA7134_BOARD_CINERGY_HT_PCMCIA >>> SAA7134_BOARD_CREATIX_CTX953 >>> SAA7134_BOARD_FLYDVBT_HYBRID_CARDBUS >>> SAA7134_BOARD_FLYDVB_TRIO >>> SAA7134_BOARD_HAUPPAUGE_HVR1110 >>> SAA7134_BOARD_KWORLD_ATSC110 >>> SAA7134_BOARD_KWORLD_DVBT_210 >>> SAA7134_BOARD_MD7134 >>> SAA7134_BOARD_MEDION_MD8800_QUADRO >>> SAA7134_BOARD_PHILIPS_EUROPA >>> SAA7134_BOARD_PHILIPS_TIGER >>> SAA7134_BOARD_PHILIPS_TIGER_S >>> SAA7134_BOARD_PINNACLE_PCTV_310i >>> SAA7134_BOARD_TEVION_DVBT_220RF >>> SAA7134_BOARD_TWINHAN_DTV_DVB_3056 >>> SAA7134_BOARD_VIDEOMATE_DVBT_200 >>> SAA7134_BOARD_VIDEOMATE_DVBT_200A >>> SAA7134_BOARD_VIDEOMATE_DVBT_300 >>> >>> It is important to test the above boards, to be sure that no regression is >>> caused. >>> >>> Signed-off-by: Mauro Carvalho Chehab >>> >>> diff -r 60110897e86a linux/drivers/media/video/saa7134/saa7134-cards.c >>> --- a/linux/drivers/media/video/saa7134/saa7134-cards.c Fri Apr 25 08:04:54 2008 -0300 >>> +++ b/linux/drivers/media/video/saa7134/saa7134-cards.c Fri Apr 25 10:44:16 2008 -0300 >>> >> Mauro, >> >> I didn't review your patch yet, and it needs to be tested, however, >> the bug reported in this thread deals with the same regression that >> you are attempting to repair, but on the cx88 driver -- not the >> saa7134 driver. >> >> Both drivers need to be tested to make sure that this regression has been fixed. >> > > Ok, this is a cx88 version. Of course, needs testing. > > Signed-off-by: Mauro Carvalho Chehab > > diff -r 5c9a4decb57b linux/drivers/media/video/cx88/cx88-cards.c > --- a/linux/drivers/media/video/cx88/cx88-cards.c Fri Apr 25 11:02:29 2008 -0300 > +++ b/linux/drivers/media/video/cx88/cx88-cards.c Fri Apr 25 12:01:48 2008 -0300 > @@ -2495,26 +2495,27 @@ > > This does not make a difference for me: tuner' 1-0043: chip found @ 0x86 (cx88[0]) tda9887 1-0043: tda988[5/6/7] found All bytes are equal. It is not a TEA5767 tuner' 1-0060: chip found @ 0xc0 (cx88[0]) tuner-simple 1-0060: type set to 44 (Philips 4 in 1 (ATI TV Wonder Pro/Conexant)) cx88[0]: Leadtek Winfast 2000XP Expert config: tuner=38, eeprom[0]=0x01 input: cx88 IR (Leadtek Winfast 2000XP as /class/input/input6 cx88[0]/0: found at 0000:00:0a.0, rev: 5, irq: 18, latency: 32, mmio: 0xe2000000 cx88[0]/0: registered device video0 [v4l2] cx88[0]/0: registered device vbi0 cx88[0]/0: registered device radio0 The wrong tuner type has already been set, before the eeprom with the correct tuner type is read. Gert -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list