From: Hartmut Hackmann <hartmut.hackmann@t-online.de>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Video-4l-list <video4linux-list@redhat.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [BUG] sound is unmuted by default with 2.6.26-rc1 on my FlyVideo 2000
Date: Wed, 07 May 2008 23:35:16 +0200 [thread overview]
Message-ID: <48222094.2020200@t-online.de> (raw)
In-Reply-To: <200805071436.03569.maximlevitsky@gmail.com>
Hi, Maxim
Maxim Levitsky schrieb:
> Hi,
>
> I was very busy, thus I didn't follow kernel development lately.
> I skipped whole 2.6.25 cycle.
>
> Now I have a bit more free time, so I updated kernel to 2.6.25, and then
> to latest -git.
>
> In latest git I noticed that sound output of my TV card is unmuted by default.
>
> commit 7bff4b4d3ad2b9ff42b4087f409076035af1d165, clears all GPIO lines,
> and on my card mute is implemented with external chip which is connected via GPIO,
> and this results in the above bug.
>
> The code that clears all gpios executed last, thus it undoes the saa7134_tvaudio_setmute
> in saa7134_video_init2.
>
> moving saa7134_tvaudio_setmute after gpio clearing doesn't help, bacause this function is
> "smart" thus it remembers last mute state and touches the hardware only if this state changes.
> (And first time it is called from video_mux, thus explict call from saa7134_video_init2 isn't necessary I think)
>
> I once had trouble with this thing, when wrote the resume code, thus I added a flag (dev->insuspend
> that made this function set mute state always when set.
> (This is a bit hackish, but I had to use this flag anyway in other places, so I decided that this is ok)
>
> I could remove this "smart" check, but I tested and found that this function is called qute often from tvaudio thread, and thus this check probably is correct.
>
>
>
> Best regards,
> Maxim Levitsky
>
Hm, it clears the gpios defined in the gpiomask, not all...
But i see the problem.
The conflict is that on many recent hybrid cards, gpios are used to switch between
analog and digital mode. And these need to be in a defined state even when analog
mode never was activated. This was a bug.
I am not sure yet but for me things look like we need the gpio initialization only
at the first start and we can do this earlier.
Hartmut
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
next prev parent reply other threads:[~2008-05-07 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 11:36 [BUG] sound is unmuted by default with 2.6.26-rc1 on my FlyVideo 2000 Maxim Levitsky
2008-05-07 21:35 ` Hartmut Hackmann [this message]
2008-05-08 0:35 ` hermann pitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48222094.2020200@t-online.de \
--to=hartmut.hackmann@t-online.de \
--cc=maximlevitsky@gmail.com \
--cc=mchehab@infradead.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox