From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m47LZeaQ014675 for ; Wed, 7 May 2008 17:35:40 -0400 Received: from mailout05.t-online.de (mailout05.t-online.de [194.25.134.82]) by mx3.redhat.com (8.13.8/8.13.8) with ESMTP id m47LZTKB025127 for ; Wed, 7 May 2008 17:35:29 -0400 Message-ID: <48222094.2020200@t-online.de> Date: Wed, 07 May 2008 23:35:16 +0200 From: Hartmut Hackmann MIME-Version: 1.0 To: Maxim Levitsky References: <200805071436.03569.maximlevitsky@gmail.com> In-Reply-To: <200805071436.03569.maximlevitsky@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Video-4l-list , Mauro Carvalho Chehab Subject: Re: [BUG] sound is unmuted by default with 2.6.26-rc1 on my FlyVideo 2000 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: video4linux-list-bounces@redhat.com Errors-To: video4linux-list-bounces@redhat.com List-ID: Hi, Maxim Maxim Levitsky schrieb: > Hi, > > I was very busy, thus I didn't follow kernel development lately. > I skipped whole 2.6.25 cycle. > > Now I have a bit more free time, so I updated kernel to 2.6.25, and then > to latest -git. > > In latest git I noticed that sound output of my TV card is unmuted by default. > > commit 7bff4b4d3ad2b9ff42b4087f409076035af1d165, clears all GPIO lines, > and on my card mute is implemented with external chip which is connected via GPIO, > and this results in the above bug. > > The code that clears all gpios executed last, thus it undoes the saa7134_tvaudio_setmute > in saa7134_video_init2. > > moving saa7134_tvaudio_setmute after gpio clearing doesn't help, bacause this function is > "smart" thus it remembers last mute state and touches the hardware only if this state changes. > (And first time it is called from video_mux, thus explict call from saa7134_video_init2 isn't necessary I think) > > I once had trouble with this thing, when wrote the resume code, thus I added a flag (dev->insuspend > that made this function set mute state always when set. > (This is a bit hackish, but I had to use this flag anyway in other places, so I decided that this is ok) > > I could remove this "smart" check, but I tested and found that this function is called qute often from tvaudio thread, and thus this check probably is correct. > > > > Best regards, > Maxim Levitsky > Hm, it clears the gpios defined in the gpiomask, not all... But i see the problem. The conflict is that on many recent hybrid cards, gpios are used to switch between analog and digital mode. And these need to be in a defined state even when analog mode never was activated. This was a bug. I am not sure yet but for me things look like we need the gpio initialization only at the first start and we can do this earlier. Hartmut -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list