public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Krufky <mkrufky@linuxtv.org>
To: Andy Walls <awalls@radix.net>
Cc: video4linux-list@redhat.com, mkrufky@linuxtv.org, Stoth@hauppauge.com
Subject: Re: cx18-0: ioremap failed, perhaps increasing __VMALLOC_RESERVE in page.h
Date: Thu, 15 May 2008 08:57:08 -0400	[thread overview]
Message-ID: <482C3324.1020804@linuxtv.org> (raw)
In-Reply-To: <1210818265.3202.25.camel@palomino.walls.org>

Andy Walls wrote:
> On Mon, 2008-05-12 at 10:48 -0400, mkrufky@linuxtv.org wrote:
>   
>> Steven Toth wrote:
>>     
>>> Steven Toth wrote:
>>>       
>>>>>         if (cx->dev)
>>>>>                 cx18_iounmap(cx);
>>>>>           
>>>> This doesn't feel right.
>>>>         
>>> Hans / Andy,
>>>
>>> Any comments?
>>>       
>> For the record, I've tested again with today's tip ( d87638488880 ) -- 
>> same exact behavior.
>>
>> When I load the modules for the first time, everything is fine.
>>
>> If I unload the cx18 module, I am unable to load it again, the same 
>> error is displayed as I posted in my original message.
>>     
>
> Mike,
>
> Could you apply the attached patch and run this test
>
> 	(precondition: cx18.ko hasn't been loaded once yet)
> 	# cat /proc/iomem /proc/meminfo > ~/memstats
> 	# modprobe cx18 debug=3
> 	# cat /proc/iomem /proc/meminfo >> ~/memstats
> 	# modprobe -r cx18
> 	# cat /proc/iomem /proc/meminfo >> ~/memstats
> 	# modprobe cx18 debug=3
> 	# cat /proc/iomem /proc/meminfo >> ~/memstats
>
> and provide the contents of dmesg (or /var/log/messages) and memstats?
>
> The patch will let me see if the contents of cx->enc_mem are bogus on
> iounmap() and if iounmap() is even being called.
>
> I also want to verify that "cx18 encoder" doesn't get removed
> from /proc/iomem and that "VmallocUsed" doesn't return to it's previous
> size when the module is unloaded.  That would show that the iounmap()
> fails.
>
> I'd also want to ensure there is no overlap in /proc/iomem with "cx18
> encoder" and something else.  The kernel should prevent it, but I want
> to make sure.
>
>
> (Hopefully the patch applies cleanly, the line numbers won't quite match
> up with the latest hg version.)
>
> Regards,
> Andy
>
>   
>> Regards,
>>
>> Mike
>>
>>     
>> ------------------------------------------------------------------------
>>
>> --
>> video4linux-list mailing list
>> Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
>> https://www.redhat.com/mailman/listinfo/video4linux-list







Andy,

I'm out of town right now, and things will be hectic when I get 
back....  I most likely won't get to this until the middle of the week, 
perhaps even next weekend.

-Mike

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

  reply	other threads:[~2008-05-15 12:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-02 12:59 cx18-0: ioremap failed, perhaps increasing __VMALLOC_RESERVE in page.h Michael Krufky
2008-05-02 13:47 ` Andy Walls
2008-05-02 15:22   ` Steven Toth
2008-05-12 14:42     ` Steven Toth
2008-05-12 14:48       ` mkrufky
2008-05-15  2:24         ` Andy Walls
2008-05-15 12:57           ` Michael Krufky [this message]
2008-05-15 23:53             ` Andy Walls
2008-05-12 14:48       ` Hans Verkuil
2008-05-12 23:20         ` Andy Walls
2008-05-02 15:00 ` Steven Toth
2008-05-03  2:43 ` [PATCH] Fix potential cx18_cards[] entry leaks Andy Walls
2008-05-03 13:33   ` [PATCH] 2nd try: " Andy Walls
2008-05-12 15:05   ` [PATCH] " Hans Verkuil
2008-05-12 23:30     ` Andy Walls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482C3324.1020804@linuxtv.org \
    --to=mkrufky@linuxtv.org \
    --cc=Stoth@hauppauge.com \
    --cc=awalls@radix.net \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox