From: Pauli Borodulin <pauli@borodulin.fi>
To: Roland Scheidegger <sroland@tungstengraphics.com>
Cc: linux-dvb@linuxtv.org
Subject: Re: [linux-dvb] Updated Mantis VP-2033 remote control patch for Manu's jusst.de Mantis branch
Date: Mon, 19 May 2008 21:51:43 +0300 [thread overview]
Message-ID: <4831CC3F.803@borodulin.fi> (raw)
In-Reply-To: <4831B70D.8050809@tungstengraphics.com>
Heya!
Roland Scheidegger wrote:
> [...]
> No offense, but I like my patch much better :-) [1]. I fail to see why
> polling has to be done - just for half-working (at best on some cards,
> not at all if the native repeat rate is too low) "improved" auto-repeat.
Ah, sorry. My bad, I missed your patch. It surely looks better.
What comes to auto-repeat... With your version of the patch it works
equally well/badly on 2033 as it did with the earlier version.
> I was under the impression that using cancel_rearming_delayed_work
> instead of cancel_delayed_work (as I did in my patch) would make it
> unnecessary to call flush_scheduled_work (but I just followed some other
> drivers and could be easily wrong).
After reading some kernel source code, I agree that
cancel_rearming_delayed_work is better suited.
> [...]
Regards,
Pauli Borodulin <pauli@borodulin.fi>
_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
next prev parent reply other threads:[~2008-05-19 18:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 22:57 [linux-dvb] Updated Mantis VP-2033 remote control patch for Manu's jusst.de Mantis branch Pauli Borodulin
2008-05-16 23:21 ` Markus Rechberger
2008-05-19 16:52 ` Pauli Borodulin
2008-05-19 17:47 ` Roland Scheidegger
[not found] ` <4831B70D.8050809@tungstengraphics.com>
2008-05-19 18:51 ` Pauli Borodulin [this message]
2008-05-19 23:47 ` Roland Scheidegger
[not found] ` <48320E0B.8090501@tungstengraphics.com>
2008-05-20 6:16 ` Pauli Borodulin
2008-05-20 12:05 ` Roland Scheidegger
2008-05-20 12:30 ` Pauli Borodulin
2008-05-24 2:22 ` Chris Hodgkins
2008-05-24 2:21 ` Chris Hodgkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4831CC3F.803@borodulin.fi \
--to=pauli@borodulin.fi \
--cc=linux-dvb@linuxtv.org \
--cc=sroland@tungstengraphics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox