From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-dvb-bounces+mchehab=infradead.org@linuxtv.org>
Received: from viefep18-int.chello.at ([213.46.255.22]
	helo=viefep23-int.chello.at)
	by www.linuxtv.org with esmtp (Exim 4.63)
	(envelope-from <rscheidegger_lists@hispeed.ch>) id 1JyF57-0003Zx-Fx
	for linux-dvb@linuxtv.org; Tue, 20 May 2008 01:47:57 +0200
Received: from [192.168.1.157] (really [77.57.60.184])
	by viefep23-int.chello.at
	(InterMail vM.7.08.02.00 201-2186-121-20061213) with ESMTP
	id <20080519234720.GYEG5554.viefep23-int.chello.at@[192.168.1.157]>
	for <linux-dvb@linuxtv.org>; Tue, 20 May 2008 01:47:20 +0200
Message-ID: <48321189.3060901@hispeed.ch>
Date: Tue, 20 May 2008 01:47:21 +0200
From: Roland Scheidegger <rscheidegger_lists@hispeed.ch>
MIME-Version: 1.0
CC: linux-dvb@linuxtv.org
References: <482E114E.1000609@borodulin.fi>	<d9def9db0805161621n1a291192n8c15db11949b3dad@mail.gmail.com>	<4831B058.1030107@borodulin.fi>	<4831B70D.8050809@tungstengraphics.com>
	<4831CC3F.803@borodulin.fi>
In-Reply-To: <4831CC3F.803@borodulin.fi>
Subject: Re: [linux-dvb] Updated Mantis VP-2033 remote control patch for
 Manu's jusst.de Mantis branch
List-Unsubscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb>,
	<mailto:linux-dvb-request@linuxtv.org?subject=unsubscribe>
List-Archive: <http://www.linuxtv.org/pipermail/linux-dvb>
List-Post: <mailto:linux-dvb@linuxtv.org>
List-Help: <mailto:linux-dvb-request@linuxtv.org?subject=help>
List-Subscribe: <http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb>,
	<mailto:linux-dvb-request@linuxtv.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: linux-dvb-bounces@linuxtv.org
Errors-To: linux-dvb-bounces+mchehab=infradead.org@linuxtv.org
List-ID: <linux-dvb@linuxtv.org>

On 19.05.2008 20:51, Pauli Borodulin wrote:
> Heya!
> 
> Roland Scheidegger wrote:
>  > [...]
>> No offense, but I like my patch much better :-) [1]. I fail to see why
>> polling has to be done - just for half-working (at best on some cards,
>> not at all if the native repeat rate is too low) "improved" auto-repeat.
> 
> Ah, sorry. My bad, I missed your patch. It surely looks better.
> 
> What comes to auto-repeat... With your version of the patch it works 
> equally well/badly on 2033 as it did with the earlier version.
Just curious, what's the native repeat rate (what it prints out with
verbose set time between irqs) with this card?

> 
>> I was under the impression that using cancel_rearming_delayed_work
>> instead of cancel_delayed_work (as I did in my patch) would make it
>> unnecessary to call flush_scheduled_work (but I just followed some other
>> drivers and could be easily wrong).
> 
> After reading some kernel source code, I agree that 
> cancel_rearming_delayed_work is better suited.

Roland


_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb