public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Oberritter <obi@linuxtv.org>
To: Anssi Hannula <anssi.hannula@gmail.com>
Cc: linux-dvb@linuxtv.org
Subject: Re: [linux-dvb] [multiproto patch] add support for using multiproto drivers with old api
Date: Fri, 23 May 2008 17:28:11 +0200	[thread overview]
Message-ID: <4836E28B.5000405@linuxtv.org> (raw)
In-Reply-To: <4836DBC1.5000608@gmail.com>

Hello Anssi,

Anssi Hannula wrote:
> The attached adds support for using multiproto drivers with the old api.

there seems to be a needlessly duplicated line in your patch:

+	/* set delivery system to the default old-API one */
+	if (fe->ops.set_delsys) {
+		switch(fe->ops.info.type) {
+		case FE_QPSK:
+			fe->ops.set_delsys(fe, DVBFE_DELSYS_DVBS);
+			fe->ops.set_delsys(fe, DVBFE_DELSYS_DVBS);

Regards,
Andreas


_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

  reply	other threads:[~2008-05-23 15:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-23 14:59 [linux-dvb] [multiproto patch] add support for using multiproto drivers with old api Anssi Hannula
2008-05-23 15:28 ` Andreas Oberritter [this message]
2008-05-23 15:38   ` Anssi Hannula
2008-05-23 16:36     ` Faruk A
2008-05-23 16:58       ` Goga777
2008-05-23 17:33         ` Faruk A
2008-05-24  8:37         ` ChaosMedia > WebDev
     [not found] <mailman.1.1219312801.18695.linux-dvb@linuxtv.org>
2008-08-21 14:31 ` Stefan Ellenberger
2008-09-07  6:18   ` Manu Abraham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4836E28B.5000405@linuxtv.org \
    --to=obi@linuxtv.org \
    --cc=anssi.hannula@gmail.com \
    --cc=linux-dvb@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox