From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m54L6uKD019713 for ; Wed, 4 Jun 2008 17:06:56 -0400 Received: from mail.hauppauge.com (mail.hauppauge.com [167.206.143.4]) by mx3.redhat.com (8.13.8/8.13.8) with ESMTP id m54L6i0w003543 for ; Wed, 4 Jun 2008 17:06:45 -0400 Message-ID: <484703B9.7070107@linuxtv.org> From: mkrufky@linuxtv.org To: mchehab@infradead.org Date: Wed, 4 Jun 2008 17:06:01 -0400 MIME-Version: 1.0 in-reply-to: <20080604172221.6c7448e7@gaivota> Content-Type: text/plain; charset="iso-8859-1" Cc: tony@atomide.com, video4linux-list@redhat.com, eduardo.valentin@indt.org.br, sakari.ailus@nokia.com Subject: Re: [PATCH 0/1] Add support for TEA5761 (from linux-omap) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: video4linux-list-bounces@redhat.com Errors-To: video4linux-list-bounces@redhat.com List-ID: Mauro Carvalho Chehab wrote: > On Wed, 4 Jun 2008 16:13:57 -0400 > "Eduardo Valentin" wrote: > > >> Hi Mike, >> >> On Wed, Jun 4, 2008 at 11:20 AM, wrote: >> >>> Mauro Carvalho Chehab wrote: >>> >>>> Hi Eduardo, >>>> >>>> On Wed, 4 Jun 2008 10:25:23 -0400 >>>> "Eduardo Valentin" wrote: >>>> >>>> >>>> >>>>> Hi Mauro and Michael, >>>>> >>>>> Thanks for pointing that there were a duplicated work. If there is any >>>>> update on the current driver, I'll contact you. I'm not the author of >>>>> this driver, but I'm interested in some points here. >>>>> >>>>> This chip is used on n800 FM radio. That's why this version came from >>>>> linux-omap. >>>>> Anyway, one quest that came from my mind, taking a brief look into >>>>> this two drivers, >>>>> I see they use different interfaces to register a FM radio driver, and >>>>> more they are located >>>>> under different places inside the tree. So, what is more recommended >>>>> for FM radio drivers? >>>>> being under drivers/media/radio/ or under drivers/media/common/tunners/ ? >>>>> What is the API more recommended dvb_tuner_ops or video_device ? I >>>>> wonder also what current applications are using. >>>>> >>>>> >>>> Good point. some radio tuners are used inside video boards. Before, this >>>> >>> were >>> >>>> located inside drivers/media/video. Now, they are at common/tuners. This >>>> >>> seems >>> >>>> to be a better place. >>>> >>>> It should be noticed that tea5761 is an I2C device. So, you'll probably >>>> >>> need a >>> >>>> counterpart module, at media/radio, that will provice I2C access methods >>>> >>> needed >>> >>>> on N800. >>>> >>>> >>> Basically, what you will have to do is create a n800 driver under >>> media/radio. This n800 driver will provide the userspace interface via >>> v4l2, and it will use internal tuner API to interface to the tea5761 module. >>> >>> >> Yeah, true. >> >> >>> When all is said and done, most likely all of the tea5761-specific code >>> would be removed from the driver that you submit -- the remaining code >>> would merely handle glue between userspace and internal tuner api. >>> >> Humm.. some code may remain inside this driver. Functions to power on/down >> the device, for example. They are not exported through this tuner API. >> > > Please map what functions you're needing. It makes sense to extend tuner API to > handle such things. In the case of power down, I think there's one callback for > it already. .sleep for power down .init for power up It's all there. Is there anything else missing, Eduardo? -Mike -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list