public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: Thierry Merle <thierry.merle@free.fr>
Cc: video4linux-list@redhat.com, v4l2 library <v4l2-library@linuxtv.org>
Subject: PATCH: libv4l-pac207-comments.patch
Date: Fri, 04 Jul 2008 13:09:59 +0200	[thread overview]
Message-ID: <486E0507.5050609@hhs.nl> (raw)

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

<now with attachment (wipes egg from face)>

Hi,

Add comments to pac207.c about what todays experiments have teached us about
the pac207 compression.

Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>

Regards,

Hans

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list


[-- Attachment #2: libv4l-pac207-comments.patch --]
[-- Type: text/plain, Size: 1228 bytes --]

Add comments to pac207.c about what todays experiments have teached us about
the pac207 compression.

Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>

diff -r 61deeffda900 v4l2-apps/lib/libv4l/libv4lconvert/pac207.c
--- a/v4l2-apps/lib/libv4l/libv4lconvert/pac207.c	Fri Jul 04 07:21:55 2008 +0200
+++ b/v4l2-apps/lib/libv4l/libv4lconvert/pac207.c	Fri Jul 04 13:06:08 2008 +0200
@@ -170,15 +170,12 @@
 	    inp += pac_decompress_row(inp, outp, width);
 	    break;
 
-	default:
+	case 0x2DD2: /* prefix for "stronger" compressed lines, currently the
+			kernel driver programs the cam so that we should not
+			get any of these */
+
+	default: /* corrupt frame */
 	    /* FIXME add error reporting */
-	    /* Notice this seems to happen with high framerates (low exposure
-	       setting due to much light and bad compressible images, so most
-	       likely the usb just cannot keep us and we miss parts of some
-	       frames (sometimes of many frames in a row) messing things up
-	       completely. It might be worth to try changing the compression
-	       balance setting to see if that can compensate for this.
-	       However currently I cannot reproduce this (no daylight) */
 	    return;
 	}
 	outp += width;

[-- Attachment #3: Type: text/plain, Size: 164 bytes --]

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

             reply	other threads:[~2008-07-04 11:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-04 11:09 Hans de Goede [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-07-04 11:07 PATCH: libv4l-pac207-comments.patch Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=486E0507.5050609@hhs.nl \
    --to=j.w.r.degoede@hhs.nl \
    --cc=thierry.merle@free.fr \
    --cc=v4l2-library@linuxtv.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox