From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: video4linux-list@redhat.com
Subject: PATCH: gspca-default-comp_fac.patch <resend>
Date: Sat, 05 Jul 2008 10:34:56 +0200 [thread overview]
Message-ID: <486F3230.2040501@hhs.nl> (raw)
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
Jean,
This patch changes the default gspca comp_fac as 30% sometimes causes
issues with the spca561, whose bayer compression does not allways
achieve 30%.
I notice that you didn't apply this patch with the latest merging of my
patches. Note that this patch is _really_ needed for the spca561 to
work. Without it it works most of the time, but with some images it
doesn't get a high enough compression and fails.
An other solution would be to add a cam specific get_buff_size op to the
spca561 driver.
Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>
Regards,
Hans
[-- Attachment #2: gspca-default-comp_fac.patch --]
[-- Type: text/plain, Size: 765 bytes --]
This patch changes the default gspca comp_fac as 30% sometimes causes issues
with the spca561, whose bayer compression does not allways achieve 30%.
Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>
diff -r 15974504cec1 linux/drivers/media/video/gspca/gspca.c
--- a/linux/drivers/media/video/gspca/gspca.c Fri Jul 04 10:51:37 2008 +0200
+++ b/linux/drivers/media/video/gspca/gspca.c Fri Jul 04 10:53:35 2008 +0200
@@ -48,7 +48,9 @@
static int video_nr = -1;
-static int comp_fac = 30; /* Buffer size ratio when compressed in % */
+static int comp_fac = 40; /* Buffer size ratio when compressed in %,
+ Note 30% is too small for bayer level
+ compression like the spca561 */
#ifdef CONFIG_VIDEO_ADV_DEBUG
int gspca_debug = D_ERR | D_PROBE;
[-- Attachment #3: file:///tmp/nsmail-2.tmp --]
[-- Type: text/plain, Size: 165 bytes --]
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
[-- Attachment #4: Type: text/plain, Size: 164 bytes --]
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
reply other threads:[~2008-07-05 8:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486F3230.2040501@hhs.nl \
--to=j.w.r.degoede@hhs.nl \
--cc=moinejf@free.fr \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox