public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: video4linux-list@redhat.com
Subject: PATCH: gspca-pac207-framesize.patch
Date: Sun, 06 Jul 2008 08:12:23 +0200	[thread overview]
Message-ID: <48706247.8080500@hhs.nl> (raw)

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

Hi,

The pac207 only does compression when the usb bandwidth mandates it, so when
in full ress mode but doing low framerates (high exposure) setting it does not
compress. Adjust full res bufsize for this, otherwise things stop working when
the framerate gets too low.

Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>

Regards,

Hans


[-- Attachment #2: gspca-pac207-framesize.patch --]
[-- Type: text/x-patch, Size: 877 bytes --]

The pac207 only does compression when the usb bandwidth mandates it, so when
in full ress mode but doing low framerates (high exposure) setting it does not
compress. Adjust full res bufsize for this, otherwise things stop working when
the framerate gets too low.

Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>

diff -r 3bbf8991628b linux/drivers/media/video/gspca/pac207.c
--- a/linux/drivers/media/video/gspca/pac207.c	Sat Jul 05 13:49:20 2008 +0200
+++ b/linux/drivers/media/video/gspca/pac207.c	Sun Jul 06 08:08:19 2008 +0200
@@ -166,7 +166,9 @@
 		.priv = 1},
 	{352, 288, V4L2_PIX_FMT_PAC207, V4L2_FIELD_NONE,
 		.bytesperline = 352,
-		.sizeimage = 352 * 288 / 2,	/* compressed */
+			/* compressed, but only when needed (not compressed
+			   when the framerate is low) */
+		.sizeimage = (352 + 2) * 288,
 		.colorspace = V4L2_COLORSPACE_SRGB,
 		.priv = 0},
 };

[-- Attachment #3: Type: text/plain, Size: 164 bytes --]

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

                 reply	other threads:[~2008-07-06  6:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48706247.8080500@hhs.nl \
    --to=j.w.r.degoede@hhs.nl \
    --cc=moinejf@free.fr \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox