Re: [PATCH] videodev: fix kobj ref count

[Hans de Goede <j.w.r.degoede@hhs.nl>]

David Ellingsworth wrote:
> Mauro,
> 
> If Laurent approves, please apply the following patch to the devel
> branch. I've been using it locally for the past five days or so
> without issue.
> 
> This patch increments the kobject reference count during video_open
> and decrements it during video_close. Doing so allows
> video_unregister_device to be called during the disconnect callback of
> usb and pci devices. It also ensures that the video_device struct is
> not freed while it is still in use and that the kobject release
> callback occurs at the appropriate time. With this patch, the
> following sequence is now possible and no longer results in a crash.
> 
> video_open
>   disconnect
>     video_unregister_device
>       video_ioctl2 (crash was here)
>         video_close
>           video_release
> 

I like this patch, I really do, as currently this refcounting needs to 
be done in all v4l devices seperately, and an video_ioctl2 wrapper needs 
to be used to stop the crash (check if device was disconnected and thus 
video_unregister_device was called and ifso don't call video_ioctl2).

So I've taken a good look and this, and I cannot find any issues.

Regards,

Hans

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list