From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: video4linux-list@redhat.com
Subject: PATCH: gspca-sonixb-fix-sif-cams.patch
Date: Mon, 14 Jul 2008 22:44:19 +0200 [thread overview]
Message-ID: <487BBAA3.5030804@hhs.nl> (raw)
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
Hi,
One of the sn9c103 + ov7660 patches has hardcoded the bridge registers 0x15
and 0x16 (H-size and V-size in units of 16 pixels) to 0x28 0x1e, which will
only work for 640x480 res sensors and not for 352x288 res sensors. This patch
restores the old behavior of reading these register from the per sensor bridge
init settings, and fixes the ov7660_3 init settings to correctly set these
registers to 0x28, 0x1e.
This fixes my 2 sn9c10x test cams:
0c45:6005 Microdia Sweex Mini WebCam tas5110
0c45:6011 Microdia PC Camera (SN9C102) ov6550
Which BTW can be set green on your cam test matrix :)
Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>
Regards,
Hans
[-- Attachment #2: gspca-sonixb-fix-sif-cams.patch --]
[-- Type: text/x-patch, Size: 1943 bytes --]
One of the sn9c103 + ov7660 patches has hardcoded the bridge registers 0x15
and 0x16 (H-size and V-size in units of 16 pixels) to 0x28 0x1e, which will
only work for 640x480 res sensors and not for 352x288 res sensors. This patch
restores the old behavior of reading these register from the per sensor bridge
init settings, and fixes the ov7660_3 init settings to correctly set these
registers to 0x28, 0x1e.
This fixes my 2 sn9c10x test cams:
0c45:6005 Microdia Sweex Mini WebCam tas5110
0c45:6011 Microdia PC Camera (SN9C102) ov6550
Which BTW can be set green on your cam test matrix :)
Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>
diff -r fa6e3138e75c linux/drivers/media/video/gspca/sonixb.c
--- a/linux/drivers/media/video/gspca/sonixb.c Mon Jul 14 18:53:03 2008 +0200
+++ b/linux/drivers/media/video/gspca/sonixb.c Mon Jul 14 22:28:56 2008 +0200
@@ -270,7 +270,7 @@
0x44, 0x44, 0x00, 0x1a, 0x20, 0x20, 0x20, 0x80, /* r01 .. r08 */
0x21, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x04, /* r09 .. r10 */
0x00, 0x01, 0x01, 0x0a, /* r11 .. r14 */
- 0x16, 0x12, /* H & V sizes r15 .. r16 */
+ 0x28, 0x1e, /* H & V sizes r15 .. r16 */
0x68, 0x8f, MCK_INIT1, /* r17 .. r19 */
0x1d, 0x10, 0x02, 0x03, 0x0f, 0x0c, 0x00, /* r1a .. r20 */
0x10, 0x20, 0x30, 0x40, 0x50, 0x60, 0x70, 0x80, /* r21 .. r28 */
@@ -811,7 +811,6 @@
const __u8 *sn9c10x;
__u8 reg01, reg17;
__u8 reg17_19[3];
- static const __u8 reg15[2] = { 0x28, 0x1e };
mode = gspca_dev->cam.cam_mode[(int) gspca_dev->curr_mode].priv;
switch (sd->sensor) {
@@ -931,8 +930,8 @@
sizeof tas5130_sensor_init);
break;
}
- /* H_size V_size 0x28, 0x1e maybe 640x480 */
- reg_w(gspca_dev, 0x15, reg15, 2);
+ /* H_size V_size 0x28, 0x1e -> 640x480. 0x16, 0x12 -> 352x288 */
+ reg_w(gspca_dev, 0x15, &sn9c10x[0x15 - 1], 2);
/* compression register */
reg_w(gspca_dev, 0x18, ®17_19[1], 1);
if (sd->sensor != SENSOR_OV7630_3) {
[-- Attachment #3: Type: text/plain, Size: 164 bytes --]
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
reply other threads:[~2008-07-14 20:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487BBAA3.5030804@hhs.nl \
--to=j.w.r.degoede@hhs.nl \
--cc=moinejf@free.fr \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox