Re: CONFIG_VIDEO_ADV_DEBUG question

[Hans de Goede <j.w.r.degoede@hhs.nl>]

Jean-Francois Moine wrote:
> On Tue, 2008-07-29 at 14:10 +0200, Hans Verkuil wrote:
>> Hans de Goede wrote:
>>> CONFIG_VIDEO_ADV_DEBUG enables additional debugging output in the gscpa
>>> driver, which then becomes "active" when a module option gets passed. So
>> 	[snip]
>> But the way gspca uses it is not correct. I would remove the test on
>> CONFIG_VIDEO_ADV_DEBUG there altogether, or replace it with a test of a
> 
> Hello Hans and Hans,
> 
> OK. So I see 3 options:
> 1) add a new kernel config option, say CONFIG_GSPCA_DEBUG,
> 2) always set an internal compile option GSPCA_DEBUG,
> 3) have the option GSPCA_DEBUG, but unset by default.
> 
> Which is the best for you, Hans (de Goede)?
> 

My vote goes to 2, so that when users using distro kernels (which will soon 
have gspca v2, Fedora's development kernel already has it) we can tell them to 
add the necessary module option and get debug output from them without them 
having to rebuild a kernel (module).

Regards,

Hans

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list